Hi Robert,
Once virtual, always virtual, i.e., it isn't necessary to add
virtual to
any overridden virtual functions, and in fact it's not possible to
unvirtualize once virtualized. I do try to maintain them as a
stylistic
convention, but even I fall short sometimes ;-). Thanks for
committed.
Rob
===
- Original Message -
From: Gary R. Van Sickle [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Thursday, December 20, 2001 5:19 PM
Subject: [PATCH] Update 2 - Setup.exe property sheet patch
Changes as per your (Rob) last email, plus a few other improvements.
Diff, new
files
Having had a good close look, there is a little more that is needed
before committing to CVS.
1) You've skipped at least one dialog - IDD_S_FROM_CWD - which is what
was breaking local_dir. (Oh, and the functions weren't virtual in some
child classes :}).
2) See download.cc - is next_dialog still
Changes as per your (Rob) last email, plus a few other improvements. Diff, new
files, and ChangeLog attached.
--
Gary R. Van Sickle
Brewer. Patriot.
setup.diff.bz2
Description: Binary data
setup-newfiles.tar.bz2
Description: Binary data
setup.ChangeLog
Description: Binary data
