Re: [PATCH] Use automake (v3)

2020-12-08 Thread Jon Turney
On 02/12/2020 19:03, Corinna Vinschen via Cygwin-patches wrote: On Dec 2 13:33, Yaakov Selkowitz via Cygwin-patches wrote: On Wed, 2020-12-02 at 18:03 +, Jon Turney wrote: On 02/12/2020 17:05, Corinna Vinschen via Cygwin-patches wrote: On Dec 2 15:36, Jon Turney wrote: On 01/12/2020

Re: [PATCH] Use automake (v3)

2020-12-02 Thread Corinna Vinschen via Cygwin-patches
On Dec 2 13:33, Yaakov Selkowitz via Cygwin-patches wrote: > On Wed, 2020-12-02 at 18:03 +, Jon Turney wrote: > > On 02/12/2020 17:05, Corinna Vinschen via Cygwin-patches wrote: > > > On Dec 2 15:36, Jon Turney wrote: > > > > On 01/12/2020 09:18, Corinna Vinschen wrote: > > > > > What bugs

Re: [PATCH] Use automake (v3)

2020-12-02 Thread Yaakov Selkowitz via Cygwin-patches
On Wed, 2020-12-02 at 18:03 +, Jon Turney wrote: > On 02/12/2020 17:05, Corinna Vinschen via Cygwin-patches wrote: > > On Dec 2 15:36, Jon Turney wrote: > > > On 01/12/2020 09:18, Corinna Vinschen wrote: > > > > What bugs me is that the mingw executables are built in > > > > utils/mingw, > >

Re: [PATCH] Use automake (v3)

2020-12-02 Thread Jon Turney
On 02/12/2020 17:05, Corinna Vinschen via Cygwin-patches wrote: On Dec 2 15:36, Jon Turney wrote: On 01/12/2020 09:18, Corinna Vinschen wrote: What bugs me is that the mingw executables are built in utils/mingw, but the object files are still in utils. Any problem generating the object

Re: [PATCH] Use automake (v3)

2020-12-02 Thread Corinna Vinschen via Cygwin-patches
On Dec 2 15:36, Jon Turney wrote: > On 01/12/2020 09:18, Corinna Vinschen wrote: > > > > What bugs me is that the mingw executables are built in utils/mingw, > > but the object files are still in utils. Any problem generating the > > object files in utils/mingw, too? > > Not easily. > > This

Re: [PATCH] Use automake (v3)

2020-12-02 Thread Corinna Vinschen via Cygwin-patches
On Dec 2 16:08, Jon Turney wrote: > On 01/12/2020 10:07, Corinna Vinschen wrote: > > > > I also don't like how test-driver is generated in the toplevel > > source dir. It should either be generated in source level winsup, > > I assume the placement of this file is controlled by

Re: [PATCH] Use automake (v3)

2020-12-02 Thread Jon Turney
On 01/12/2020 10:07, Corinna Vinschen wrote: I also don't like how test-driver is generated in the toplevel source dir. It should either be generated in source level winsup, I assume the placement of this file is controlled by AC_CONFIG_AUX_DIR. if it's a file to be added to the repo (like

Re: [PATCH] Use automake (v3)

2020-12-02 Thread Jon Turney
On 01/12/2020 09:18, Corinna Vinschen wrote: What bugs me is that the mingw executables are built in utils/mingw, but the object files are still in utils. Any problem generating the object files in utils/mingw, too? Not easily. This behaviour can be turned off by not using the

Re: [PATCH] Use automake (v3)

2020-12-01 Thread Corinna Vinschen
On Dec 1 10:18, Corinna Vinschen wrote: > Hi Jon, > > On Nov 30 17:02, Jon Turney wrote: > > On 30/11/2020 10:47, Corinna Vinschen wrote: > > [...] > > >CXXLDpath-testsuite.exe > > > /usr/lib/gcc/x86_64-w64-mingw32/9.2.1/../../../../x86_64-w64-mingw32/bin/ld: > > > > > >

Re: [PATCH] Use automake (v3)

2020-12-01 Thread Corinna Vinschen
Hi Jon, On Nov 30 17:02, Jon Turney wrote: > On 30/11/2020 10:47, Corinna Vinschen wrote: > > On Nov 30 11:25, Corinna Vinschen wrote: > > > > Also, after applying the patch and autogen-ing, a full build from > > top-level fails with some warnings and a final undefined symbol: > > The warnings

Re: [PATCH] Use automake (v3)

2020-11-30 Thread Jon Turney
On 30/11/2020 10:47, Corinna Vinschen wrote: On Nov 30 11:25, Corinna Vinschen wrote: Also, after applying the patch and autogen-ing, a full build from top-level fails with some warnings and a final undefined symbol: The warnings are expected at this stage. make[5]: Entering directory

Re: [PATCH] Use automake (v3)

2020-11-30 Thread Jon Turney
On 30/11/2020 10:25, Corinna Vinschen wrote: Hi Jon, On Nov 24 13:37, Jon Turney wrote: For ease of reviewing, this patch doesn't contain changes to generated files which would be made by running ./autogen.sh. v2: * Include tzmap.h in BUILT_SOURCES * Make per-file flags appear after

Re: [PATCH] Use automake (v3)

2020-11-30 Thread Corinna Vinschen
On Nov 30 11:25, Corinna Vinschen wrote: > Hi Jon, > > On Nov 24 13:37, Jon Turney wrote: > > For ease of reviewing, this patch doesn't contain changes to generated > > files which would be made by running ./autogen.sh. > > > > v2: > > * Include tzmap.h in BUILT_SOURCES > > * Make per-file flags

Re: [PATCH] Use automake (v3)

2020-11-30 Thread Corinna Vinschen
Hi Jon, On Nov 24 13:37, Jon Turney wrote: > For ease of reviewing, this patch doesn't contain changes to generated > files which would be made by running ./autogen.sh. > > v2: > * Include tzmap.h in BUILT_SOURCES > * Make per-file flags appear after user-supplied CXXFLAGS, so they can >

[PATCH] Use automake (v3)

2020-11-24 Thread Jon Turney
For ease of reviewing, this patch doesn't contain changes to generated files which would be made by running ./autogen.sh. v2: * Include tzmap.h in BUILT_SOURCES * Make per-file flags appear after user-supplied CXXFLAGS, so they can override optimization level. * Correct .o files used to define