Re: [PATCH] Use automake (v5)

2021-05-04 Thread Jon Turney
On 03/05/2021 11:43, Corinna Vinschen wrote: On May 2 16:28, Jon Turney wrote: On 20/04/2021 21:13, Jon Turney wrote: For ease of reviewing, this patch doesn't contain changes to generated files which would be made by running ./autogen.sh. Some possible items of future work I noted: *

Re: [PATCH] Use automake (v5)

2021-05-03 Thread Corinna Vinschen
On May 2 16:28, Jon Turney wrote: > On 20/04/2021 21:13, Jon Turney wrote: > > For ease of reviewing, this patch doesn't contain changes to generated > > files which would be made by running ./autogen.sh. > > Some possible items of future work I noted: > > * Documentation is now always built

Re: [PATCH] Use automake (v5)

2021-05-03 Thread Corinna Vinschen
On May 2 12:25, Brian Inglis wrote: > On 2021-05-02 09:28, Jon Turney wrote: > > Some possible items of future work I noted: > > > * -Wimplicit-fallthrough, -Werror could (should?) be set in top-level > > Makefile.am.common, rather than individual subdirs Careful, the implicit-fallthrough

Re: [PATCH] Use automake (v5)

2021-05-02 Thread Brian Inglis
On 2021-05-02 09:28, Jon Turney wrote: Some possible items of future work I noted: * -Wimplicit-fallthrough, -Werror could (should?) be set in top-level Makefile.am.common, rather than individual subdirs Perhaps keep -Werror for Cygwin sources only where we can directly deal with new

Re: [PATCH] Use automake (v5)

2021-05-02 Thread Jon Turney
On 20/04/2021 21:13, Jon Turney wrote: For ease of reviewing, this patch doesn't contain changes to generated files which would be made by running ./autogen.sh. Some possible items of future work I noted: * Documentation is now always built (rather than dangerously ignoring any errors)

Re: [PATCH] Use automake (v5)

2021-04-27 Thread Jon Turney
On 27/04/2021 18:00, Ken Brown wrote: On 4/27/2021 12:52 PM, Ken Brown wrote: On 4/27/2021 11:50 AM, Jon Turney wrote: On 20/04/2021 21:13, Jon Turney wrote: For ease of reviewing, this patch doesn't contain changes to generated files which would be made by running ./autogen.sh.   I pushed

Re: [PATCH] Use automake (v5)

2021-04-27 Thread Ken Brown
On 4/27/2021 12:52 PM, Ken Brown wrote: On 4/27/2021 11:50 AM, Jon Turney wrote: On 20/04/2021 21:13, Jon Turney wrote: For ease of reviewing, this patch doesn't contain changes to generated files which would be made by running ./autogen.sh.   I pushed this patch. If you have an existing

Re: [PATCH] Use automake (v5)

2021-04-27 Thread Ken Brown
On 4/27/2021 11:50 AM, Jon Turney wrote: On 20/04/2021 21:13, Jon Turney wrote: For ease of reviewing, this patch doesn't contain changes to generated files which would be made by running ./autogen.sh.  I pushed this patch. If you have an existing build directory, while you might get away

Re: [PATCH] Use automake (v5)

2021-04-27 Thread Jon Turney
On 26/04/2021 16:03, Corinna Vinschen wrote: On Apr 22 13:57, Corinna Vinschen wrote: On Apr 21 18:40, Corinna Vinschen wrote: On Apr 20 21:15, Jon Turney wrote: On 20/04/2021 21:13, Jon Turney wrote: * some object files are in a unexpected places in the build file hierarchy (compared to

Re: [PATCH] Use automake (v5)

2021-04-27 Thread Jon Turney
On 20/04/2021 21:13, Jon Turney wrote: For ease of reviewing, this patch doesn't contain changes to generated files which would be made by running ./autogen.sh. I pushed this patch. If you have an existing build directory, while you might get away with invoking 'make' at the top-level, I

Re: [PATCH] Use automake (v5)

2021-04-26 Thread Corinna Vinschen
On Apr 22 13:57, Corinna Vinschen wrote: > On Apr 21 18:40, Corinna Vinschen wrote: > > On Apr 20 21:15, Jon Turney wrote: > > > On 20/04/2021 21:13, Jon Turney wrote: > > > > For ease of reviewing, this patch doesn't contain changes to generated > > > > files which would be made by running

Re: [PATCH] Use automake (v5)

2021-04-22 Thread Corinna Vinschen
On Apr 21 18:40, Corinna Vinschen wrote: > On Apr 20 21:15, Jon Turney wrote: > > On 20/04/2021 21:13, Jon Turney wrote: > > > For ease of reviewing, this patch doesn't contain changes to generated > > > files which would be made by running ./autogen.sh. > > > > Sorry about getting distracted

Re: [PATCH] Use automake (v5)

2021-04-21 Thread Corinna Vinschen
On Apr 20 21:15, Jon Turney wrote: > On 20/04/2021 21:13, Jon Turney wrote: > > For ease of reviewing, this patch doesn't contain changes to generated > > files which would be made by running ./autogen.sh. > > Sorry about getting distracted from this. To summarize what I believe were > the

Re: [PATCH] Use automake (v5)

2021-04-20 Thread Jon Turney
On 20/04/2021 21:13, Jon Turney wrote: For ease of reviewing, this patch doesn't contain changes to generated files which would be made by running ./autogen.sh. Sorry about getting distracted from this. To summarize what I believe were the outstanding issues with v3 [1]: [1]

[PATCH] Use automake (v5)

2021-04-20 Thread Jon Turney
For ease of reviewing, this patch doesn't contain changes to generated files which would be made by running ./autogen.sh. v2: * Include tzmap.h in BUILT_SOURCES * Make per-file flags appear after user-supplied CXXFLAGS, so they can override optimization level. * Correct .o files used to define