Re: [PATCH] fix profiling

Christopher Faylor wrote: > Please use your best judgement about the +r/=r thing given Dave's > comments. I think Dave's right, because when I compile with +r I get a "may be used uninitialized" warning, so I'll just leave it as it is. Both patches are now committed. I wonder how long this was

Re: [PATCH] fix profiling

On Mon, Aug 04, 2008 at 10:11:04PM -0700, Brian Dessent wrote: >2008-08-04 Brian Dessent > > * config/i386/profile.h (mcount): Mark asms volatile. Go ahead and check this in and I'll roll a new release. Please use your best judgement about the +r/=r thing given Dave's comments. cgf

RE: [PATCH] fix profiling

Brian Dessent wrote on 05 August 2008 06:28: > Brian Dessent wrote: > >> Since this code is lifted from the BSDs I did check that this change was >> made there as well, e.g. >> .

Re: [PATCH] fix profiling

Brian Dessent wrote: > Since this code is lifted from the BSDs I did check that this change was > made there as well, e.g. > . Actually, I also missed that the above version uses

[PATCH] fix profiling

Long story short: some asm()s have missing volatile modifiers. The mcount() profiling hook is implemented with a short wrapper around the actual mcount function. The wrapper's purpose is to get the pc of the caller as well as the return value of the caller's frame, and pass those on as arguments