Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-19 Thread Corinna Vinschen
On Jun 16 21:52, Philippe Cerfon wrote: > On Fri, Jun 16, 2023 at 9:49 PM Corinna Vinschen > wrote: > > Even a SSD has "disk" in it's name :) > > That actually stands for drive :-) Huh, ok. To me it always was "solid state disk", but it's certainly not the first time I'm wrong :))) > > Let's

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-16 Thread Philippe Cerfon
On Fri, Jun 16, 2023 at 9:49 PM Corinna Vinschen wrote: > Even a SSD has "disk" in it's name :) That actually stands for drive :-) > Let's keep it at that. I pushed your patchset. Thanks for merging! :-) Any rough estimate when this will be in a live release? Regards and best wishes,

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-16 Thread Corinna Vinschen
On Jun 16 17:43, Philippe Cerfon wrote: > Hey. > > On Fri, Jun 16, 2023 at 5:04 PM Corinna Vinschen > wrote: > > Oh well. Now that I see it in real life, my idea to use the entire > > expression inline wasn't that great, it seems... > > ^^ > > > > I didn't want to keep MAX_EA_NAME_LEN because

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-16 Thread Philippe Cerfon
Hey. On Fri, Jun 16, 2023 at 5:04 PM Corinna Vinschen wrote: > Oh well. Now that I see it in real life, my idea to use the entire > expression inline wasn't that great, it seems... ^^ > I didn't want to keep MAX_EA_NAME_LEN because now that we have an > official name for the value, having an

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-16 Thread Corinna Vinschen
Hi Philippe, On Jun 16 16:09, Philippe Cerfon wrote: > Hey Corinna. > > On Wed, Jun 7, 2023 at 12:06 PM Corinna Vinschen > wrote: > > Hmm, the comparisons would have to check for XATTR_NAME_MAX anyway, > > so maybe inlining is cleaner in this case. > > Please have a look at the updated and

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-16 Thread Philippe Cerfon
Hey Corinna. On Wed, Jun 7, 2023 at 12:06 PM Corinna Vinschen wrote: > Hmm, the comparisons would have to check for XATTR_NAME_MAX anyway, > so maybe inlining is cleaner in this case. Please have a look at the updated and attached patches. Thanks, Philippe. From

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-07 Thread Corinna Vinschen
On Jun 6 17:17, Philippe Cerfon wrote: > On Tue, Jun 6, 2023 at 3:28 PM Corinna Vinschen > wrote: > > Yes, it is wrong, because the value of MAX_EA_NAME_LEN / XATTR_NAME_MAX > > is used for array size definitions as well as comparisons. > > Do you prefer to keep MAX_EA_NAME_LEN and just have

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-06 Thread Philippe Cerfon
On Tue, Jun 6, 2023 at 3:28 PM Corinna Vinschen wrote: > Yes, it is wrong, because the value of MAX_EA_NAME_LEN / XATTR_NAME_MAX > is used for array size definitions as well as comparisons. Do you prefer to keep MAX_EA_NAME_LEN and just have that set like, perhaps with an additional comment that

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-06 Thread Corinna Vinschen
Hi Philippe, On Jun 6 03:14, Philippe Cerfon wrote: > Hey Corinna, et al. > > On Mon, Jun 5, 2023 at 9:05 PM Corinna Vinschen > wrote: > > - Whatever that's good for, we actually allow bigger values right > > now. For compat reasons we only allow attributes starting with > > the "user."

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-05 Thread Philippe Cerfon
Hey Corinna, et al. On Mon, Jun 5, 2023 at 9:05 PM Corinna Vinschen wrote: > - Whatever that's good for, we actually allow bigger values right > now. For compat reasons we only allow attributes starting with > the "user." prefix, and the *trailing* part after "user." is > allowed to be

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-05 Thread Corinna Vinschen
[dropping newlib from the recipient list] Hi Philippe, On May 30 14:04, Brian Inglis wrote: > On Tue, 30 May 2023 13:25:38 +0200, Philippe Cerfon wrote: > > Hey there. > > > > Linux exports XATTR_{NAME,SIZE,LIST}_MAX in it's linux/limits.h and > > e.g. the CPython interpreter uses them for it's

[PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-05-30 Thread Brian Inglis
On Tue, 30 May 2023 13:25:38 +0200, Philippe Cerfon wrote: Hey there. Linux exports XATTR_{NAME,SIZE,LIST}_MAX in it's linux/limits.h and e.g. the CPython interpreter uses them for it's XATTRs functions. I made a corresponding PR at CPython https://github.com/python/cpython/pull/105075 to get