Re: [PATCH 08/11] path.cc: Allow to skip filesystem checks

2021-01-19 Thread Corinna Vinschen via Cygwin-patches
On Jan 18 18:15, Ben wrote: > > > On 18-01-2021 12:36, Corinna Vinschen via Cygwin-patches wrote: > > On Jan 15 14:45, Ben Wijen wrote: > > > > Without any code setting the flag, this doesn't seem to make any > > sense. At least the commit message should reflect on the reasons > > for this chan

Re: [PATCH 08/11] path.cc: Allow to skip filesystem checks

2021-01-18 Thread Ben
On 18-01-2021 12:36, Corinna Vinschen via Cygwin-patches wrote: > On Jan 15 14:45, Ben Wijen wrote: > > Without any code setting the flag, this doesn't seem to make any > sense. At least the commit message should reflect on the reasons > for this change. > Something like this: path.cc: Al

Re: [PATCH 08/11] path.cc: Allow to skip filesystem checks

2021-01-18 Thread Corinna Vinschen via Cygwin-patches
On Jan 15 14:45, Ben Wijen wrote: > When file attributes are of no concern, > there is no point to query them. Without any code setting the flag, this doesn't seem to make any sense. At least the commit message should reflect on the reasons for this change. > --- > winsup/cygwin/path.cc | 3 +++

[PATCH 08/11] path.cc: Allow to skip filesystem checks

2021-01-15 Thread Ben Wijen
When file attributes are of no concern, there is no point to query them. --- winsup/cygwin/path.cc | 3 +++ winsup/cygwin/path.h | 1 + 2 files changed, 4 insertions(+) diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc index abd3687df..f00707e86 100644 --- a/winsup/cygwin/path.cc +++ b/