Re: [PATCH 2/8] Drop STDINCFLAGS overrides

2020-10-13 Thread Corinna Vinschen
On Oct 13 18:36, Jon Turney wrote: > On 13/10/2020 13:10, Corinna Vinschen wrote: > > On Oct 12 20:29, Jon Turney wrote: > > > This used to turn off -nostdinc on a per-file basis, but has no effect > > > since 4c36016b. > > > > I'd prefer a longer SHA-1, at least 12 chars. Maybe we should > >

Re: [PATCH 2/8] Drop STDINCFLAGS overrides

2020-10-13 Thread Jon Turney
On 13/10/2020 13:10, Corinna Vinschen wrote: On Oct 12 20:29, Jon Turney wrote: This used to turn off -nostdinc on a per-file basis, but has no effect since 4c36016b. I'd prefer a longer SHA-1, at least 12 chars. Maybe we should With ~20K commits in the repository, the chance of a hash

Re: [PATCH 2/8] Drop STDINCFLAGS overrides

2020-10-13 Thread Corinna Vinschen
On Oct 12 20:29, Jon Turney wrote: > This used to turn off -nostdinc on a per-file basis, but has no effect > since 4c36016b. I'd prefer a longer SHA-1, at least 12 chars. Maybe we should add a "Fixes: ..." along the lines of the Linux kernel from now on? Ideally we'd get rid of ccwrap/c++wrap,

[PATCH 2/8] Drop STDINCFLAGS overrides

2020-10-12 Thread Jon Turney
This used to turn off -nostdinc on a per-file basis, but has no effect since 4c36016b. --- winsup/cygwin/Makefile.in | 4 1 file changed, 4 deletions(-) diff --git a/winsup/cygwin/Makefile.in b/winsup/cygwin/Makefile.in index f775f0691..3a7a73adb 100644 --- a/winsup/cygwin/Makefile.in +++