Re: [PATCH v2 1/3] Posix asynchronous I/O support: aio files

2018-05-15 Thread Mark Geisert
On Wed, 2 May 2018, Brian Inglis wrote: On 2018-05-02 02:21, Mark Geisert wrote: I found a discrepancy in the Cygwin source tree and would like input on how to resolve it... On Thu, 19 Apr 2018, Corinna Vinschen wrote: +static void +aionotify (struct aiocb *aio) +{ +  /* if signal notification

Re: [PATCH v2 1/3] Posix asynchronous I/O support: aio files

2018-05-02 Thread Brian Inglis
On 2018-05-02 02:21, Mark Geisert wrote: > I found a discrepancy in the Cygwin source tree and would like input on how to > resolve it... > On Thu, 19 Apr 2018, Corinna Vinschen wrote: >>> +static void >>> +aionotify (struct aiocb *aio) >>> +{ >>> +  /* if signal notification wanted, send

Re: [PATCH v2 1/3] Posix asynchronous I/O support: aio files

2018-05-02 Thread Mark Geisert
Hi Corinna, I found a discrepancy in the Cygwin source tree and would like input on how to resolve it... On Thu, 19 Apr 2018, Corinna Vinschen wrote: +static void +aionotify (struct aiocb *aio) +{ + /* if signal notification wanted, send AIO-complete signal */ + //XXX Is sigqueue() the best

Re: [PATCH v2 1/3] Posix asynchronous I/O support: aio files

2018-04-19 Thread Corinna Vinschen
On Apr 19 01:04, Mark Geisert wrote: > This is the core of the AIO implementation: aio.cc and aio.h. The > latter is used within Cygwin by aio.cc and the fhandler* modules, as > well as by user programs wanting the AIO functionality. > > This is the 2nd WIP patch set for AIO. The string XXX

[PATCH v2 1/3] Posix asynchronous I/O support: aio files

2018-04-19 Thread Mark Geisert
This is the core of the AIO implementation: aio.cc and aio.h. The latter is used within Cygwin by aio.cc and the fhandler* modules, as well as by user programs wanting the AIO functionality. This is the 2nd WIP patch set for AIO. The string XXX marks issues I'm specifically requesting comments