Re: [Patch]: mkdir -p and network drives

2005-05-24 Thread Christopher Faylor
On Wed, May 18, 2005 at 02:42:12PM -0400, Pierre A. Humblet wrote: >- Original Message - >From: "Corinna Vinschen" >To: >Sent: Wednesday, May 18, 2005 12:48 PM >Subject: Re: [Patch]: mkdir -p and network drives > > >> Hi Pierre, >> >> I do

Re: [Patch]: mkdir -p and network drives

2005-05-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Wrong list. Redirecting. According to Vance Turner on 5/18/2005 11:06 PM: > I usually don't write you guys, I follow the thread to see how development > is going. > > Just a note. The ls command is't quite right. > > Ls -lRC wil not recursively li

RE: [Patch]: mkdir -p and network drives

2005-05-19 Thread Dave Korn
Original Message >From: Christopher Faylor >Sent: 19 May 2005 06:13 > On Wed, May 18, 2005 at 10:09:35PM -0700, Vance Turner wrote: >> Additional note >> >> ls -lRC - not working >> ls -RCl - working >> >> If you point out the source I will fix it. > > 1) This is not a bug reporting lis

Re: [Patch]: mkdir -p and network drives

2005-05-18 Thread Christopher Faylor
On Wed, May 18, 2005 at 10:09:35PM -0700, Vance Turner wrote: >Additional note > >ls -lRC - not working >ls -RCl - working > >If you point out the source I will fix it. 1) This is not a bug reporting list. 2) This does not, as far as I can tell, have anything to do with the subject of this messag

RE: [Patch]: mkdir -p and network drives

2005-05-18 Thread Vance Turner
Additional note ls -lRC - not working ls -RCl - working If you point out the source I will fix it.

RE: [Patch]: mkdir -p and network drives

2005-05-18 Thread Vance Turner
PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Pierre A. Humblet Sent: Wednesday, May 18, 2005 11:42 AM To: cygwin-patches@cygwin.com Subject: Re: [Patch]: mkdir -p and network drives - Original Message - From: "Corinna Vinschen" To: Sent: Wednesday, May 18, 2005 12:48 PM Subject

Re: [Patch]: mkdir -p and network drives

2005-05-18 Thread Pierre A. Humblet
- Original Message - From: "Corinna Vinschen" To: Sent: Wednesday, May 18, 2005 12:48 PM Subject: Re: [Patch]: mkdir -p and network drives > Hi Pierre, > > I don't see a reason why you moved telldir just a few lines up. > Any reasoning, perhaps together wi

Re: [Patch]: mkdir -p and network drives

2005-05-18 Thread Corinna Vinschen
Hi Pierre, On May 18 08:22, Pierre A. Humblet wrote: > Here is the implementation of mkdir and rmdir with fhandlers. Thanks for the patch. Chris is going to reply later today, but I have some questions beforehand. > +_off64_t > +fhandler_disk_file::telldir (DIR *dir) > +{ > + return dir->__d_p

Re: [Patch]: mkdir -p and network drives

2005-05-18 Thread Pierre A. Humblet
Here is the implementation of mkdir and rmdir with fhandlers. To prepare the day where proc_registry will allow writes, I have removed setting PATH_RO and an error return from path.cc (it's all handled in the fhandlers). I have also removed obsolete code about fhandler_cygdrive. There is another

Re: [Patch]: mkdir -p and network drives

2005-05-13 Thread Christopher Faylor
On Fri, May 13, 2005 at 02:41:03PM +, Eric Blake wrote: >> I added read-only filesystem checking to path_conv::check so the latest >> snapshot seems to work fine with the latest coreutils (trixie is a >> system in my home network which exports shares): > >Almost. With the 20050513 snapshot and

Re: [Patch]: mkdir -p and network drives

2005-05-13 Thread Eric Blake
> I added read-only filesystem checking to path_conv::check so the latest > snapshot seems to work fine with the latest coreutils (trixie is a > system in my home network which exports shares): Almost. With the 20050513 snapshot and coreutils-5.3.0-6, I am still getting: $ cd //eblake/share $ ls

Re: [Patch]: mkdir -p and network drives

2005-05-13 Thread Christopher Faylor
On Thu, May 12, 2005 at 04:02:22PM -0400, Christopher Faylor wrote: >On Thu, May 12, 2005 at 03:49:21PM -0400, Pierre A. Humblet wrote: >>- Original Message - >>From: "Corinna Vinschen" <[EMAIL PROTECTED]> >>To: >>Sent: Wednesday, May 11, 2005 4

Re: [Patch]: mkdir -p and network drives

2005-05-12 Thread Christopher Faylor
On Thu, May 12, 2005 at 03:49:21PM -0400, Pierre A. Humblet wrote: >- Original Message - >From: "Corinna Vinschen" <[EMAIL PROTECTED]> >To: >Sent: Wednesday, May 11, 2005 4:53 AM >Subject: Re: [Patch]: mkdir -p and network drives > > >> I do

Re: [Patch]: mkdir -p and network drives

2005-05-12 Thread Pierre A. Humblet
- Original Message - From: "Corinna Vinschen" <[EMAIL PROTECTED]> To: Sent: Wednesday, May 11, 2005 4:53 AM Subject: Re: [Patch]: mkdir -p and network drives > I don't like the idea of isrofs being an inline function in dir.cc. > Wouldn't that be b

Re: [Patch]: mkdir -p and network drives

2005-05-11 Thread Corinna Vinschen
On May 10 20:53, Pierre A. Humblet wrote: > * dir.cc (isrofs): New function. > (mkdir): Check for FH_FS and use isrofs. > (rmdir): Use isrofs. > > Index: dir.cc > === > RCS file: /cvs/src/src/winsup/cygwin/dir.cc,v >

Re: [Patch]: mkdir -p and network drives

2005-05-10 Thread Pierre A. Humblet
At 01:27 AM 5/11/2005 +, Eric Blake wrote: >> At 11:11 AM 5/10/2005 -0400, Christopher Faylor wrote: >> >> So I restrained mkdir to only act on FH_FS. >> >> Ideally mkdir & rmdir should be part of the various handlers, but >> there is no current payoff in doing so as directories can only be >

Re: [Patch]: mkdir -p and network drives

2005-05-10 Thread Pierre A. Humblet
At 11:11 AM 5/10/2005 -0400, Christopher Faylor wrote: >Could we see this as a unified-diff please? Oops, but in retrospect it's a good thing. I did some more tests. If c:\dev exists, then mkdir /dev/tty created c:\dev\tty (ditto for the other /dev/xxx ), but rmdir /dev/tty would not delete c:\d

Re: [Patch]: mkdir -p and network drives

2005-05-10 Thread Christopher Faylor
On Mon, May 09, 2005 at 08:16:36PM -0400, Pierre A. Humblet wrote: >At 06:19 PM 5/9/2005 +, Eric Blake wrote: > >>Second, the sequence chdir("//"), mkdir("machine") creates machine in the >>current directory. > >Old bug. >chdir("/proc"), mkdir("machine") produces the same result. >And mkdir("

Re: [Patch]: mkdir -p and network drives

2005-05-09 Thread Pierre A. Humblet
At 06:19 PM 5/9/2005 +, Eric Blake wrote: >Second, the sequence chdir("//"), mkdir("machine") creates machine in the >current directory. Old bug. chdir("/proc"), mkdir("machine") produces the same result. And mkdir("/proc"), mkdir("/proc/machine") creates c:\proc\machine The fix sets errno

RE: [Patch]: mkdir -p and network drives

2005-05-09 Thread Dave Korn
Original Message >From: Eric Blake >Sent: 06 May 2005 23:29 > Also, what should //.. resolve to, / or //? And if it resolves to /, > should // be an entry in the readdir() of /? I would argue that //.. > should resolve to //, meaning we just have two distinct roots in the > directory tr

Re: [Patch]: mkdir -p and network drives

2005-05-09 Thread Pierre A. Humblet
- Original Message - From: "Eric Blake" To: Sent: Monday, May 09, 2005 2:19 PM Subject: Re: [Patch]: mkdir -p and network drives > Pierre A. Humblet phumblet.no-ip.org> writes: > > > > Here is a patch to allow mkdir -p to easily work with network &g

Re: [Patch]: mkdir -p and network drives

2005-05-09 Thread Eric Blake
Pierre A. Humblet phumblet.no-ip.org> writes: > > Here is a patch to allow mkdir -p to easily work with network > drives and to allow future enumeration of computers and of > network drives by ls -l. > > It works by defining a new FH_NETDRIVE virtual handler for > names such as // and //machine.

Re: [Patch]: mkdir -p and network drives

2005-05-06 Thread Christopher Faylor
On Fri, May 06, 2005 at 04:29:38PM -0600, Eric Blake wrote: >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA1 > >>I thought that Eric Blake implied that // *had* to be translated to /, >>as per POSIX. I wonder how many programs out there translate a >>standalone '//' to '/'. > >No, POSIX requires th

Re: [Patch]: mkdir -p and network drives

2005-05-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > I thought that Eric Blake implied that // *had* to be translated to /, > as per POSIX. I wonder how many programs out there translate a > standalone '//' to '/'. No, POSIX requires that / be untouched, // be implementation-defined (hint - - define

Re: [Patch]: mkdir -p and network drives

2005-05-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > Sigh. We need a bash maintainer. > We need to have // working for mkdir -p to work, from what I > understand of the code snippet that was sent to the list. `mkdir -p' only uses chdir(), mkdir(), and stat() calls. For //server/share/newdir, the stra

Re: [Patch]: mkdir -p and network drives

2005-05-06 Thread Christopher Faylor
On Fri, May 06, 2005 at 11:07:13AM -0400, Pierre A. Humblet wrote: >That's not Paul Eggert's position, >http://cygwin.com/ml/cygwin/2005-05/msg00251.html I don't expect >problems with //, we had it working in cvs for a while and only bash >had issues. Program translating // to / should already hav

Re: [Patch]: mkdir -p and network drives

2005-05-06 Thread Pierre A. Humblet
- Original Message - From: "Christopher Faylor" <[EMAIL PROTECTED]> To: Sent: Friday, May 06, 2005 10:58 AM Subject: Re: [Patch]: mkdir -p and network drives > On Fri, May 06, 2005 at 10:55:29AM -0400, Pierre A. Humblet wrote: > >- Original Message ---

Re: [Patch]: mkdir -p and network drives

2005-05-06 Thread Christopher Faylor
On Fri, May 06, 2005 at 10:55:29AM -0400, Pierre A. Humblet wrote: >- Original Message - >From: "Christopher Faylor" <[EMAIL PROTECTED]> >To: >Sent: Friday, May 06, 2005 10:22 AM >Subject: Re: [Patch]: mkdir -p and network drives > >>Well, that was

Re: [Patch]: mkdir -p and network drives

2005-05-06 Thread Pierre A. Humblet
- Original Message - From: "Christopher Faylor" <[EMAIL PROTECTED]> To: Sent: Friday, May 06, 2005 10:22 AM Subject: Re: [Patch]: mkdir -p and network drives > Well, that was kinda my point. If we can't remove the "//" handling because > it br

Re: [Patch]: mkdir -p and network drives

2005-05-06 Thread Christopher Faylor
On Fri, May 06, 2005 at 09:27:55AM -0400, Pierre A. Humblet wrote: >cgf wrote: >> On Thu, May 05, 2005 at 10:57:08PM -0400, Pierre A. Humblet wrote: > >>>The code should handle "//" correctly, but path.cc still transforms it >>>into "/", because of the bash bug. > >> Is that fixed in the current ba

Re: [Patch]: mkdir -p and network drives

2005-05-06 Thread Pierre A. Humblet
cgf wrote: > On Thu, May 05, 2005 at 10:57:08PM -0400, Pierre A. Humblet wrote: >>The code should handle "//" correctly, but path.cc still transforms it >>into "/", because of the bash bug. > Is that fixed in the current bash? AFAIK Corinna fixed it once, but the patch got lost and it's currentl

Re: [Patch]: mkdir -p and network drives

2005-05-05 Thread Christopher Faylor
On Thu, May 05, 2005 at 10:57:08PM -0400, Pierre A. Humblet wrote: > >Here is a patch to allow mkdir -p to easily work with network >drives and to allow future enumeration of computers and of >network drives by ls -l. > >It works by defining a new FH_NETDRIVE virtual handler for >names such as // a

[Patch]: mkdir -p and network drives

2005-05-05 Thread Pierre A. Humblet
Here is a patch to allow mkdir -p to easily work with network drives and to allow future enumeration of computers and of network drives by ls -l. It works by defining a new FH_NETDRIVE virtual handler for names such as // and //machine. This also makes chdir work without additional change. The c