Re: [Patch] Fix incorrect code page when setting console title on Win10

2020-08-26 Thread Takashi Yano via Cygwin-patches
On Wed, 26 Aug 2020 19:33:45 +0200 Corinna Vinschen wrote: > On Aug 26 09:30, Johannes Schindelin wrote: > > Hi Corinna, > > > > On Wed, 26 Aug 2020, Corinna Vinschen wrote: > > > > > On Aug 26 16:43, 宫大汉 via Cygwin-patches wrote: > > > > When Cygwin sets console titles on Win10

Re: [Patch] Fix incorrect code page when setting console title on Win10

2020-08-26 Thread Corinna Vinschen
On Aug 26 09:30, Johannes Schindelin wrote: > Hi Corinna, > > On Wed, 26 Aug 2020, Corinna Vinschen wrote: > > > On Aug 26 16:43, 宫大汉 via Cygwin-patches wrote: > > > When Cygwin sets console titles on Win10 (has_con_24bit_colors > > > !con_is_legacy), > > > `WriteConsoleA` is used and causes

Re: [Patch] Fix incorrect code page when setting console title on Win10

2020-08-26 Thread Johannes Schindelin
Hi Corinna, On Wed, 26 Aug 2020, Corinna Vinschen wrote: > On Aug 26 16:43, 宫大汉 via Cygwin-patches wrote: > > When Cygwin sets console titles on Win10 (has_con_24bit_colors > > !con_is_legacy), > > `WriteConsoleA` is used and causes an error if: > > 1. the environment variable of `LANG` is

Re: [Patch] Fix incorrect code page when setting console title on Win10

2020-08-26 Thread Corinna Vinschen
Hi, On Aug 26 16:43, 宫大汉 via Cygwin-patches wrote: > When Cygwin sets console titles on Win10 (has_con_24bit_colors > !con_is_legacy), > `WriteConsoleA` is used and causes an error if: > 1. the environment variable of `LANG` is `***.UTF-8` > 2. and the code page of console.exe is not UTF-8 >

[Patch] Fix incorrect code page when setting console title on Win10

2020-08-26 Thread 宫大汉 via Cygwin-patches
When Cygwin sets console titles on Win10 (has_con_24bit_colors !con_is_legacy), `WriteConsoleA` is used and causes an error if: 1. the environment variable of `LANG` is `***.UTF-8` 2. and the code page of console.exe is not UTF-8 1. e.g. on my Computer, it's GB2312, for Chinese text I've done