On May 21 19:15, Christian Franke wrote:
* fhandler_floppy.cc (fhandler_dev_floppy::lseek): Don't invalidate
devbuf if new position is within buffered range.
Thanks, applied.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project
Hi Christian,
On May 20 17:02, Christian Franke wrote:
fhandler_dev_floppy::lseek() always clears the 60KB pre-read buffer,
even on lseek(fd, 0, SEEK_CUR);
If a programm (like ddrescue) always calls lseek() before each read(),
performance is poor, because the same block is read several
Corinna Vinschen wrote:
As for the devbuf part of the patch, it's missing a ChangeLog entry.
Can you please send one, possibly in present tense? (Your first
ChangeLog was incorrectly written in past tense)
2007-05-21 Christian Franke [EMAIL PROTECTED]
* fhandler_floppy.cc
fhandler_dev_floppy::lseek() always clears the 60KB pre-read buffer,
even on lseek(fd, 0, SEEK_CUR);
If a programm (like ddrescue) always calls lseek() before each read(),
performance is poor, because the same block is read several times.
With this new version of the patch, the buffer is only
Christopher Faylor escreveu:
On Fri, May 18, 2007 at 09:02:15PM +0200, Christian Franke wrote:
Hi,
Cygwin 1.5.24-2 segfaults on unaligned lseek() on raw block devices with
sector size 512 bytes.
Testcases:
$ dd skip=1000 bs=2047 if=/dev/scd0 of=/dev/null
$ ddrescue -c 1 /dev/scd0 file.iso
Pedro Alves wrote:
Christopher Faylor escreveu:
On Fri, May 18, 2007 at 09:02:15PM +0200, Christian Franke wrote:
Hi,
Cygwin 1.5.24-2 segfaults on unaligned lseek() on raw block devices
with sector size 512 bytes.
Testcases:
$ dd skip=1000 bs=2047 if=/dev/scd0 of=/dev/null
$ ddrescue -c 1
Christian Franke escreveu:
Pedro Alves wrote:
Christopher Faylor escreveu:
On Fri, May 18, 2007 at 09:02:15PM +0200, Christian Franke wrote:
Hi,
Cygwin 1.5.24-2 segfaults on unaligned lseek() on raw block devices
with sector size 512 bytes.
Testcases:
$ dd skip=1000 bs=2047 if=/dev/scd0
Pedro Alves wrote:
...
I'm just looking at fhandler_floopy.cc for the first time,
but, isn't there the possibility that bytes_left can be a bit too big
for alloca?
AFAIK not: bytes_left is always less than bytes_per_sector.
The _dev_floppy class is only used for Floppy (512), HD (usually
On Fri, May 18, 2007 at 09:02:15PM +0200, Christian Franke wrote:
Hi,
Cygwin 1.5.24-2 segfaults on unaligned lseek() on raw block devices with
sector size 512 bytes.
Testcases:
$ dd skip=1000 bs=2047 if=/dev/scd0 of=/dev/null
$ ddrescue -c 1 /dev/scd0 file.iso
This is due to a fixed 512 byte
Christopher Faylor wrote:
On Fri, May 18, 2007 at 09:02:15PM +0200, Christian Franke wrote:
...
It seems like this could be done without the heavyweight use of malloc,
like use an automatic array of length 512 + 4 and calculate an aligned
address from that.
Sorry, no. unaligned
On Fri, May 18, 2007 at 10:23:41PM +0200, Christian Franke wrote:
Christopher Faylor wrote:
On Fri, May 18, 2007 at 09:02:15PM +0200, Christian Franke wrote:
...
It seems like this could be done without the heavyweight use of malloc,
like use an automatic array of length 512 + 4 and
11 matches
Mail list logo
