Re: Fix sem_getvalue

2013-09-25 Thread Christopher Faylor
On Wed, Sep 25, 2013 at 12:41:17PM +0200, Paul Kunysch wrote: >> That looks like a reasonable fix. Did you trace through all of the >> callers of semaphore::_getvalue to make sure that some of them aren't >> relying on the old behavior? > >I did not look for other callers. > >I just wrote a very s

Re: Fix sem_getvalue

2013-09-25 Thread Paul Kunysch
That looks like a reasonable fix. Did you trace through all of the callers of semaphore::_getvalue to make sure that some of them aren't relying on the old behavior? I did not look for other callers. I just wrote a very simple test for sem_getvalue() and copied different cygwin1.dll versions

Re: Fix sem_getvalue

2013-09-18 Thread Christopher Faylor
On Wed, Sep 18, 2013 at 11:53:20AM +0200, Paul Kunysch wrote: >Hello > >In 1.7.24 and 1.7.25 sem_getvalue() returns the current value instead of >setting the out-parameter and returning 0/-1 for success/error. > >I attached a simple fix. That looks like a reasonable fix. Did you trace through al

Fix sem_getvalue

2013-09-18 Thread Paul Kunysch
Hello In 1.7.24 and 1.7.25 sem_getvalue() returns the current value instead of setting the out-parameter and returning 0/-1 for success/error. I attached a simple fix. I don't know if this should be further improved by setting errno to EINVAL if STATUS_INVALID_HANDLE == status. Unfortunate