Re: Improvements to fork handling (3/5)

2011-05-28 Thread Christopher Faylor
On Wed, May 11, 2011 at 02:32:09PM -0400, Ryan Johnson wrote: This patch fixes a bug in the reserve_at function which caused it to sometimes reserve space needed by the dll it was supposed to help land. This happens when the dll tries to land in a free region which overlaps the desired

Re: Improvements to fork handling (2/5)

2011-05-24 Thread Ryan Johnson
On 23/05/2011 3:31 AM, Corinna Vinschen wrote: On May 22 14:42, Ryan Johnson wrote: On 21/05/2011 9:44 PM, Christopher Faylor wrote: On Wed, May 11, 2011 at 02:31:37PM -0400, Ryan Johnson wrote: Hi all, This patch has the parent sort its dll list topologically by dependencies. Previously,

Re: Improvements to fork handling (2/5)

2011-05-24 Thread Corinna Vinschen
On May 24 07:27, Ryan Johnson wrote: On 23/05/2011 3:31 AM, Corinna Vinschen wrote: On May 22 14:42, Ryan Johnson wrote: In theory, this should completely eliminate the case where us loading one DLL pulls in dependencies automatically (= uncontrolled and at Windows' whim). The problem would

Re: Improvements to fork handling (2/5)

2011-05-24 Thread Corinna Vinschen
On May 22 14:42, Ryan Johnson wrote: On 21/05/2011 9:44 PM, Christopher Faylor wrote: On Wed, May 11, 2011 at 02:31:37PM -0400, Ryan Johnson wrote: Hi all, This patch has the parent sort its dll list topologically by dependencies. Previously, attempts to load a DLL_LOAD dll risked pulling

Re: Improvements to fork handling (2/5)

2011-05-24 Thread Ryan Johnson
On 24/05/2011 12:14 PM, Corinna Vinschen wrote: On May 22 14:42, Ryan Johnson wrote: On 21/05/2011 9:44 PM, Christopher Faylor wrote: On Wed, May 11, 2011 at 02:31:37PM -0400, Ryan Johnson wrote: Hi all, This patch has the parent sort its dll list topologically by dependencies. Previously,

Re: Improvements to fork handling (2/5)

2011-05-24 Thread Ryan Johnson
On 24/05/2011 9:05 AM, Corinna Vinschen wrote: On May 24 07:27, Ryan Johnson wrote: On 23/05/2011 3:31 AM, Corinna Vinschen wrote: On May 22 14:42, Ryan Johnson wrote: In theory, this should completely eliminate the case where us loading one DLL pulls in dependencies automatically (=

Re: Improvements to fork handling (2/5)

2011-05-24 Thread Christopher Faylor
On Tue, May 24, 2011 at 12:47:36PM -0400, Ryan Johnson wrote: The best way to improve performance of this part of fork() would be to figure out how to force a dll to load in the right place on the first try. Achieving this admittedly difficult task would eliminate multiple syscalls per dll, the

Re: Improvements to fork handling (1/5)

2011-05-24 Thread Ryan Johnson
On 22/05/2011 4:29 PM, Christopher Faylor wrote: On Sun, May 22, 2011 at 09:04:40AM -0400, Ryan Johnson wrote: On 21/05/2011 9:41 PM, Christopher Faylor wrote: On Wed, May 11, 2011 at 02:31:23PM -0400, Ryan Johnson wrote: Hi all, This is the first of a series of patches, sent in separate

Re: Improvements to fork handling (2/5)

2011-05-24 Thread Ryan Johnson
On 23/05/2011 3:31 AM, Corinna Vinschen wrote: On May 22 14:42, Ryan Johnson wrote: On 21/05/2011 9:44 PM, Christopher Faylor wrote: On Wed, May 11, 2011 at 02:31:37PM -0400, Ryan Johnson wrote: Hi all, This patch has the parent sort its dll list topologically by dependencies. Previously,

Re: Improvements to fork handling (2/5)

2011-05-23 Thread Corinna Vinschen
On May 22 14:42, Ryan Johnson wrote: On 21/05/2011 9:44 PM, Christopher Faylor wrote: On Wed, May 11, 2011 at 02:31:37PM -0400, Ryan Johnson wrote: Hi all, This patch has the parent sort its dll list topologically by dependencies. Previously, attempts to load a DLL_LOAD dll risked pulling

Re: Improvements to fork handling (1/5)

2011-05-22 Thread Ryan Johnson
On 21/05/2011 9:41 PM, Christopher Faylor wrote: On Wed, May 11, 2011 at 02:31:23PM -0400, Ryan Johnson wrote: Hi all, This is the first of a series of patches, sent in separate emails as requested. The first patch allows a child which failed due to address space clobbers to report cleanly

Re: Improvements to fork handling (2/5)

2011-05-22 Thread Ryan Johnson
On 21/05/2011 9:44 PM, Christopher Faylor wrote: On Wed, May 11, 2011 at 02:31:37PM -0400, Ryan Johnson wrote: Hi all, This patch has the parent sort its dll list topologically by dependencies. Previously, attempts to load a DLL_LOAD dll risked pulling in dependencies automatically, and the

Re: Improvements to fork handling (1/5)

2011-05-22 Thread Christopher Faylor
On Sun, May 22, 2011 at 09:04:40AM -0400, Ryan Johnson wrote: On 21/05/2011 9:41 PM, Christopher Faylor wrote: On Wed, May 11, 2011 at 02:31:23PM -0400, Ryan Johnson wrote: Hi all, This is the first of a series of patches, sent in separate emails as requested. The first patch allows a child

Re: Improvements to fork handling (1/5)

2011-05-22 Thread Christopher Faylor
On Sun, May 22, 2011 at 04:29:18PM -0400, Christopher Faylor wrote: ...I'd prefer that the testing be done in frok:parent when the child_copy happens for static and dynamic dlls, maybe by adding a dll function which first checks that the data/bss can be copied to the same location as the parent.

Re: Improvements to fork handling (1/5)

2011-05-21 Thread Christopher Faylor
On Wed, May 11, 2011 at 02:31:23PM -0400, Ryan Johnson wrote: Hi all, This is the first of a series of patches, sent in separate emails as requested. The first patch allows a child which failed due to address space clobbers to report cleanly back to the parent. As a result, DLL_LINK which

Re: Improvements to fork handling (2/5)

2011-05-21 Thread Christopher Faylor
On Wed, May 11, 2011 at 02:31:37PM -0400, Ryan Johnson wrote: Hi all, This patch has the parent sort its dll list topologically by dependencies. Previously, attempts to load a DLL_LOAD dll risked pulling in dependencies automatically, and the latter would then not benefit from the code which

Re: Improvements to fork handling (1/5)

2011-05-17 Thread Ryan Johnson
Any feedback on these patches? On 11/05/2011 2:31 PM, Ryan Johnson wrote: Hi all, This is the first of a series of patches, sent in separate emails as requested. The first patch allows a child which failed due to address space clobbers to report cleanly back to the parent. As a result,

Re: Improvements to fork handling (1/5)

2011-05-17 Thread Christopher Faylor
On Tue, May 17, 2011 at 07:14:12AM -0400, Ryan Johnson wrote: Any feedback on these patches? I'll get to them eventually but I have some other Cygwin stuff which is occupying my attention currently. cgf

Re: Improvements to fork handling

2011-05-11 Thread Ryan Johnson
On 11/05/2011 10:13 AM, Christopher Faylor wrote: On Wed, May 11, 2011 at 09:59:53AM +0200, Corinna Vinschen wrote: On May 11 02:18, Ryan Johnson wrote: Please find attached five patches [...] Oops, wrong mailing list... Btw., it would be nice if you could create patches with the diff -p

Re: Improvements to fork handling

2011-05-11 Thread Ryan Johnson
On 11/05/2011 12:16 PM, Christopher Faylor wrote: On Wed, May 11, 2011 at 10:21:14AM -0400, Ryan Johnson wrote: On 11/05/2011 10:13 AM, Christopher Faylor wrote: On Wed, May 11, 2011 at 09:59:53AM +0200, Corinna Vinschen wrote: On May 11 02:18, Ryan Johnson wrote: Please find attached five