Re: thunking, the next step

2003-11-22 Thread Robert Collins
On Sat, 2003-11-22 at 11:26, Warren Young wrote: Robert Collins wrote: http://www.jargon.8hz.com/jargon_35.html - see thunk, and meaning 3 is what I've been using. jargon.org is the official site, and it has a more detailed definition:

Re: thunking, the next step

2003-11-21 Thread Corinna Vinschen
On Fri, Nov 21, 2003 at 07:52:21AM +1100, Robert Collins wrote: On Mon, 2003-11-17 at 23:02, Corinna Vinschen wrote: And, structures like the FindNext* details change in definition when UNICODE is defined. I was trying to avoid all that complexity, which is significant, by staying

Re: thunking, the next step

2003-11-21 Thread Robert Collins
On Fri, 2003-11-21 at 22:02, Corinna Vinschen wrote: Ok. Well for now, I'm going to leave the thunks in place, until / if they become nothing more than if (unicode) ...W() else A(). That said, all the calls we are thunking require kernel mode transitions, so I really don't believe that

Re: thunking, the next step

2003-11-21 Thread Warren Young
Robert Collins wrote: http://www.jargon.8hz.com/jargon_35.html - see thunk, and meaning 3 is what I've been using. jargon.org is the official site, and it has a more detailed definition: http://www.catb.org/~esr/jargon/html/T/thunk.html Beware of definition 4, which can cause confusion in the

Re: thunking, the next step

2003-11-20 Thread Robert Collins
On Mon, 2003-11-17 at 23:02, Corinna Vinschen wrote: And, structures like the FindNext* details change in definition when UNICODE is defined. I was trying to avoid all that complexity, which is significant, by staying in a thunk approach. Yep, I agree, that's an extra problem. But it

Re: thunking, the next step

2003-11-17 Thread Corinna Vinschen
On Fri, Nov 14, 2003 at 02:10:10PM -0500, Christopher Faylor wrote: On Sat, Nov 15, 2003 at 04:52:43AM +1100, Robert Collins wrote: On Sat, 2003-11-15 at 02:57, Christopher Faylor wrote: On Fri, Nov 14, 2003 at 11:02:11PM +1100, Robert Collins wrote: Ok, I've now integrated and generalised

Re: thunking, the next step

2003-11-17 Thread Corinna Vinschen
On Mon, Nov 17, 2003 at 10:31:29PM +1100, Robert Collins wrote: On Mon, 2003-11-17 at 22:21, Corinna Vinschen wrote: This would require a decision only on the first time a function is called. There's more to it than that. you MUST NOT hand the A series call longer paths than MAX_PATH,

thunking, the next step

2003-11-14 Thread Robert Collins
Ok, I've now integrated and generalised Ron's unicode support mini-patch. So, here tis a version that, well the changelog explains the overview, and io.h the detail. Overhead wise, this is reasonably low: 1 strlen() per IO call minimum. 1 unicode conversion, only if needed. inlined code, so no

Re: thunking, the next step

2003-11-14 Thread Corinna Vinschen
On Fri, Nov 14, 2003 at 11:02:11PM +1100, Robert Collins wrote: Ok, I've now integrated and generalised Ron's unicode support mini-patch. So, here tis a version that, well the changelog explains the overview, and io.h the detail. Overhead wise, this is reasonably low: 1 strlen() per IO

Re: thunking, the next step

2003-11-14 Thread Robert Collins
On Fri, 2003-11-14 at 23:58, Corinna Vinschen wrote: I'm wondering if we couldn't get rid of that strlen call. These functions already get a Windows path. This path is constructed by a call to path_conv::check(). check() already scans the path so it should be simple to add a length field to

Re: thunking, the next step

2003-11-14 Thread Christopher Faylor
On Fri, Nov 14, 2003 at 11:02:11PM +1100, Robert Collins wrote: Ok, I've now integrated and generalised Ron's unicode support mini-patch. So, here tis a version that, well the changelog explains the overview, and io.h the detail. Overhead wise, this is reasonably low: 1 strlen() per IO call

Re: thunking, the next step

2003-11-14 Thread Christopher Faylor
On Sat, Nov 15, 2003 at 04:52:43AM +1100, Robert Collins wrote: On Sat, 2003-11-15 at 02:57, Christopher Faylor wrote: On Fri, Nov 14, 2003 at 11:02:11PM +1100, Robert Collins wrote: Ok, I've now integrated and generalised Ron's unicode support mini-patch. So, here tis a version that, well