[PATCH 7/8] Remove empty MT_SAFE and MT_SAFE_OBJECTS

2020-10-12 Thread Jon Turney
--- winsup/cygwin/Makefile.in | 3 --- 1 file changed, 3 deletions(-) diff --git a/winsup/cygwin/Makefile.in b/winsup/cygwin/Makefile.in index 7f19a57fd..6d205f7a7 100644 --- a/winsup/cygwin/Makefile.in +++ b/winsup/cygwin/Makefile.in @@ -71,7 +71,6 @@ CRT0:=$(cygwin_build)/crt0.o # # --enable

[PATCH 4/8] Remove AC_ARG_PROGRAM/program_transform_name

2020-10-12 Thread Jon Turney
Not done consistently, and probably never used. --- winsup/cygwin/configure.ac | 15 --- winsup/lsaauth/configure.ac | 2 -- winsup/utils/Makefile.in| 4 +--- winsup/utils/configure.ac | 2 -- 4 files changed, 1 insertion(+), 22 deletions(-) diff --git

[PATCH 2/8] Drop STDINCFLAGS overrides

2020-10-12 Thread Jon Turney
This used to turn off -nostdinc on a per-file basis, but has no effect since 4c36016b. --- winsup/cygwin/Makefile.in | 4 1 file changed, 4 deletions(-) diff --git a/winsup/cygwin/Makefile.in b/winsup/cygwin/Makefile.in index f775f0691..3a7a73adb 100644 --- a/winsup/cygwin/Makefile.in +++

[PATCH 1/8] Drop looking for w32api in winsup/w32api

2020-10-12 Thread Jon Turney
Stop looking for w32api headers in the (no longer existent) winsup/w32api directory (removed in commit 61746d6a). --- winsup/acinclude.m4 | 2 -- 1 file changed, 2 deletions(-) diff --git a/winsup/acinclude.m4 b/winsup/acinclude.m4 index 80c920e8c..865ef8b5d 100644 --- a/winsup/acinclude.m4 +++

[PATCH 3/8] Remove AC_PROG_MAKE_SET

2020-10-12 Thread Jon Turney
This is only needed if we are using an ancient make which doesn't set ${MAKE}, but we say "This makefile requires GNU make." everywhere. It only has an effect if @SET_MAKE@ is used, which we aren't doing consistently. --- winsup/configure.ac | 2 -- winsup/cygserver/configure.ac | 2 --

[PATCH 6/8] Remove autoconf variable INSTALL_LICENSE

2020-10-12 Thread Jon Turney
Remove autoconf variable INSTALL_LICENSE, which has a constant value which is only used once. --- winsup/Makefile.in | 4 +--- winsup/configure.ac | 4 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/winsup/Makefile.in b/winsup/Makefile.in index 148d98531..dc1c0 100644 ---

[PATCH 5/8] Drop AC_SUBST(LIBSERVER)

2020-10-12 Thread Jon Turney
The autoconf variable LIBSERVER isn't defined, and it's value isn't used. (The Makefile.in contains a literal value for the name of this library instead). --- winsup/cygwin/configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/winsup/cygwin/configure.ac b/winsup/cygwin/configure.ac

[PATCH 0/8] Makefile/configure cleanups

2020-10-12 Thread Jon Turney
Some Makefile.in and configure.ac cleanups and de-cruftification. This is preparatory to an Automakeification series still being worked on. For ease of reviewing, this patch doesn't contain changes to generated files which would be made by a autoreconf. Jon Turney (8): Drop looking for w32api

[PATCH 8/8] Remove unused doc/ug-info.xml

2020-10-12 Thread Jon Turney
Remove doc/ug-info.xml, not used in any document. --- winsup/doc/ug-info.xml | 36 1 file changed, 36 deletions(-) delete mode 100644 winsup/doc/ug-info.xml diff --git a/winsup/doc/ug-info.xml b/winsup/doc/ug-info.xml deleted file mode 100644 index

[PATCH 1/1] Cygwin: AF_INET and AF_LOCAL: recv_internal: fix MSG_WAITALL support

2020-10-12 Thread Ken Brown via Cygwin-patches
If MSG_WAITALL is set, recv_internal calls WSARecv or WSARecvFrom in a loop, in an effort to fill all the scatter-gather buffers. The test for whether all the buffers are full was previously incorrect. --- winsup/cygwin/fhandler_socket_inet.cc | 2 +- winsup/cygwin/fhandler_socket_local.cc | 2

[PATCH 0/1] Fix MSG_WAITALL support

2020-10-12 Thread Ken Brown via Cygwin-patches
It looks to me like there's been a bug in the MSG_WAITALL support for AF_INET and AF_LOCAL sockets ever since that support was first introduced 13 years ago in commit 023a2fa7. If I'm right, MSG_WAITALL has never worked. This patch fixes it. I'll push it in a few days if no one sees anything

Re: [PATCH 0/1] Fix MSG_WAITALL support

2020-10-12 Thread Ken Brown via Cygwin-patches
On 10/12/2020 2:02 PM, Ken Brown via Cygwin-patches wrote: It looks to me like there's been a bug in the MSG_WAITALL support for AF_INET and AF_LOCAL sockets ever since that support was first introduced 13 years ago in commit 023a2fa7. If I'm right, MSG_WAITALL has never worked. This patch