Re: [PATCH] Cygwin: Fix access to block devices below /proc/sys.

2020-11-30 Thread Corinna Vinschen
On Nov 30 15:04, Corinna Vinschen wrote: > On Nov 30 13:49, Christian Franke wrote: > > Corinna Vinschen wrote: > > > On Nov 28 22:59, Christian Franke wrote: > > > > ... > > > > The attached experimental patch does not fix the lseek() (sorry), but > > > > handles such block devices with

Re: [PATCH] Cygwin: Fix access to block devices below /proc/sys.

2020-11-30 Thread Corinna Vinschen
On Nov 28 22:59, Christian Franke wrote: > There a very few but occasionally interesting use cases for read access to > block devices below /proc/sys: > > - Read raw images behind drive letters which are not linked to regular > /dev/sdXN partitions. For example read decrypted images of VeraCrypt

Re: [PATCH] Cygwin: Fix access to block devices below /proc/sys.

2020-11-30 Thread Corinna Vinschen
On Nov 30 13:49, Christian Franke wrote: > Corinna Vinschen wrote: > > On Nov 28 22:59, Christian Franke wrote: > > > ... > > > The attached experimental patch does not fix the lseek() (sorry), but > > > handles such block devices with fhandler_dev_floppy instead. Tested with > > > above use

Re: [PATCH v2 0/2] proc(5) man page

2020-11-30 Thread Corinna Vinschen
Hi Brian, On Nov 24 23:49, Brian Inglis wrote: > Brian Inglis (2): > specialnames.xml: add proc(5) Cygwin man page > winsup/doc/Makefile.in: create man5 dir and install generated proc.5 > > winsup/doc/Makefile.in |4 + > winsup/doc/specialnames.xml | 2094

Re: [PATCH] Cygwin: Fix access to block devices below /proc/sys.

2020-11-30 Thread Christian Franke
Corinna Vinschen wrote: On Nov 28 22:59, Christian Franke wrote: ... The attached experimental patch does not fix the lseek() (sorry), but handles such block devices with fhandler_dev_floppy instead. Tested with above use cases. I'm not sure whether this could break access to other /proc/sys

Re: [PATCH] Use automake (v3)

2020-11-30 Thread Corinna Vinschen
Hi Jon, On Nov 24 13:37, Jon Turney wrote: > For ease of reviewing, this patch doesn't contain changes to generated > files which would be made by running ./autogen.sh. > > v2: > * Include tzmap.h in BUILT_SOURCES > * Make per-file flags appear after user-supplied CXXFLAGS, so they can >

Re: [PATCH] Use automake (v3)

2020-11-30 Thread Corinna Vinschen
On Nov 30 11:25, Corinna Vinschen wrote: > Hi Jon, > > On Nov 24 13:37, Jon Turney wrote: > > For ease of reviewing, this patch doesn't contain changes to generated > > files which would be made by running ./autogen.sh. > > > > v2: > > * Include tzmap.h in BUILT_SOURCES > > * Make per-file flags

Re: [PATCH] Use automake (v3)

2020-11-30 Thread Jon Turney
On 30/11/2020 10:47, Corinna Vinschen wrote: On Nov 30 11:25, Corinna Vinschen wrote: Also, after applying the patch and autogen-ing, a full build from top-level fails with some warnings and a final undefined symbol: The warnings are expected at this stage. make[5]: Entering directory

Re: [PATCH] Use automake (v3)

2020-11-30 Thread Jon Turney
On 30/11/2020 10:25, Corinna Vinschen wrote: Hi Jon, On Nov 24 13:37, Jon Turney wrote: For ease of reviewing, this patch doesn't contain changes to generated files which would be made by running ./autogen.sh. v2: * Include tzmap.h in BUILT_SOURCES * Make per-file flags appear after

Re: [PATCH] Use automake (v2)

2020-11-30 Thread Jon Turney
On 23/11/2020 15:27, Corinna Vinschen wrote: Hi Jon, Do I have to run autogen.sh for testing? Yes. This patch also has an issue where the cygwin per-file {C,CXX}FLAGS aren't set when make is invoked in the top-level. A revised version to address that will be forthcoming.

Re: [PATCH v2 0/2] proc(5) man page

2020-11-30 Thread Brian Inglis
On 2020-11-30 03:47, Corinna Vinschen wrote: On Nov 24 23:49, Brian Inglis wrote: Brian Inglis (2): specialnames.xml: add proc(5) Cygwin man page winsup/doc/Makefile.in: create man5 dir and install generated proc.5 winsup/doc/Makefile.in |4 + winsup/doc/specialnames.xml |