Re: Reorganizing internal_getlogin()

2002-06-13 Thread Pierre A. Humblet
Christopher Faylor wrote: Stupid question time: Do we *really* need to set these environment variables? What would break if we just didn't set them? I can't imagine any well-written software relying on these being set correctly. How can you rely on something that a user could modify?

Re: passwd edited /etc/passwd patch

2002-06-13 Thread Corinna Vinschen
On Tue, Jun 11, 2002 at 08:18:15PM -0500, Joshua Daniel Franklin wrote: + /* Try getting a Win32 username in case the user edited /etc/passwd */ + if (ret == NERR_UserNotFound) + { +if ((pw = getpwnam (user))) + cygwin_internal (CW_EXTRACT_DOMAIN_AND_USER, pw, domain, (char *)

Small Patch

2002-06-13 Thread Nicholas Wourms
Hi all, This is a patch to a few files to update the copyright year and fix a minor spelling error. In winver.rc, I also formatted the DBA name in the same format as it appears throughout the rest of the source code. I assume this will not require a copyright assignment, since it is only 13

Re: Reorganizing internal_getlogin()

2002-06-13 Thread Christopher Faylor
On Thu, Jun 13, 2002 at 12:29:36PM -0400, Pierre A. Humblet wrote: Christopher Faylor wrote: Reexamining what you did in spawn_guts, it looks like there may still be a need to call the environment builder in two separate places. One before CreateProcess and one immediately before

Re: Small Patch

2002-06-13 Thread Nicholas Wourms
Christopher Faylor wrote: On Thu, Jun 13, 2002 at 01:05:42PM -0400, Nicholas Wourms wrote: This is a patch to a few files to update the copyright year and fix a minor spelling error. Thanks for the heads up. IMO, comment changes fall into the documentation category. Changes to comments

More doco updates

2002-06-13 Thread Nicholas Wourms
Hi, This is an update to cvs.html, which shows the examples with the new prompt style. It also provides clarification on the cvs update procedure, since cvs update alone will cause the entire src tree to be pulled if you have update -dP in your .cvsrc file. I've seen more then a few

Re: Reorganizing internal_getlogin() -- modified Pierre patch

2002-06-13 Thread Pierre A. Humblet
At 01:27 AM 6/13/2002 -0400, Christopher Faylor wrote: Ok, here's a patch with the rest of the environment fleshed out (I hope). I don't know enough about this stuff to know if this works or not but it doesn't core dump in very simple test cases. Does it make sense? That's the question.

Re: Reorganizing internal_getlogin() -- modified Pierre patch

2002-06-13 Thread Conrad Scott
Pierre A. Humblet [EMAIL PROTECTED] wrote: I also tried to build the current cvs but get an error In file included from ../../../../src/winsup/cygwin/assert.cc:13: /src/winsup/w32api/include/wingdi.h:2521: `HENMETAFILE' was not declared in this scope I just stumbled over that one: it's a

Re: passwd edited /etc/passwd patch

2002-06-13 Thread Joshua Daniel Franklin
--- Corinna Vinschen [EMAIL PROTECTED] wrote: On Tue, Jun 11, 2002 at 08:18:15PM -0500, Joshua Daniel Franklin wrote: + /* Try getting a Win32 username in case the user edited /etc/passwd */ + if (ret == NERR_UserNotFound) + { +if ((pw = getpwnam (user))) + cygwin_internal