Re: [patch]: Decouple cygwin building from in-tree mingw/w32api building

2012-10-22 Thread Corinna Vinschen
On Oct 22 14:23, Corinna Vinschen wrote: > - OTOH, AC_NO_EXECUTABLES disables any linkage tests, so the LIBICONV > test in utils/configure.in has to be replaced or go away. In my below > patch I opted for "go away". I just replaced it by -liconv in > Makefile.in:

Re: Fwd: Re: [patch]: Decouple cygwin building from in-tree mingw/w32api building

2012-10-24 Thread Corinna Vinschen
On Oct 23 17:48, Christopher Faylor wrote: > On Tue, Oct 23, 2012 at 09:50:10PM +0100, Keith Marshall wrote: > >And just like Earnie's, the response he requested from me also bounced. > >Forwarded copy below: > > > Original Message > >Subject: Re: [patch]: Decouple cygwin building

Re: [patch]: Decouple cygwin building from in-tree mingw/w32api building

2012-10-24 Thread Corinna Vinschen
On Oct 24 04:30, Yaakov (Cygwin/X) wrote: > On Mon, 2012-10-22 at 14:23 +0200, Corinna Vinschen wrote: > > If the original patch with the aforementioned changes is ok with > > everybody, I'd apply it asap and remove lsaauth/cyglsa64.dll, > > lsaauth/make-64bit-version-wi

Re: [patch]: Decouple cygwin building from in-tree mingw/w32api building

2012-10-24 Thread Corinna Vinschen
On Oct 24 11:50, Corinna Vinschen wrote: > On Oct 24 04:30, Yaakov (Cygwin/X) wrote: > > On Mon, 2012-10-22 at 14:23 +0200, Corinna Vinschen wrote: > > > If the original patch with the aforementioned changes is ok with > > > everybody, I'd apply it asap

[Fwd: Re: Fwd: Re: [patch]: Decouple cygwin building from in-tree mingw/w32api building]

2012-10-24 Thread Corinna Vinschen
FYI. - Forwarded message from Earnie Boyd <...> - > Date: Wed, 24 Oct 2012 07:15:52 -0400 > From: Earnie Boyd <...> > To: Keith Marshall <...>, Christopher Faylor > <...>, cygwin-patches@cygwin.com, Corinna Vinschen > <...> >

Re: Fwd: Re: [patch]: Decouple cygwin building from in-tree mingw/w32api building

2012-10-24 Thread Corinna Vinschen
On Oct 24 07:15, Earnie Boyd wrote: > On Wed, Oct 24, 2012 at 3:49 AM, Corinna Vinschen wrote: > > > > Just to be sure: Does that mean we can simply remove the mingw and > > w32api dirs in the sourceware repo any time? > > Yes. Ok, thank you! Co

Re: [patch]: Decouple cygwin building from in-tree mingw/w32api building

2012-10-24 Thread Corinna Vinschen
On Oct 24 05:26, Yaakov (Cygwin/X) wrote: > On Wed, 2012-10-24 at 12:01 +0200, Corinna Vinschen wrote: > > > Checking in toplevel patches requires global checkin rights. I can > > > apply the toplevel patch when you applied the rest. Other than that, > > > topleve

[toplevel patch] Simplify FLAGS_FOR_TARGET for Cygwin

2012-10-24 Thread Corinna Vinschen
ease apply this patch there, too? Thanks, Corinna 2012-10-24 Corinna Vinschen * configure.ac (FLAGS_FOR_TARGET,target=cygwin): Fix for building against Mingw64 w32api. * configure: Regenerate. Index: configure.ac

Re: [patch cygwin]: Replace inline-assembler in string.h by C implementation

2012-10-24 Thread Corinna Vinschen
considered? Now that you mention it. There's strchrnul in newlib, which could simply replace strechr. There's no equivalent for ascii_strcasecmp or ascii_strncasecmp in newlib since the newlib function are multibyte capable and thus slower. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat

Re: [patch cygwin]: Replace inline-assembler in string.h by C implementation

2012-10-25 Thread Corinna Vinschen
he current one was based > > on a linux implementation. A C version of these functions has likely > > been written before, possibly even in newlib. Were those considered? > > > > cgf > > Sure, I have looked up standard-implementation of > stricmp/strnicmp/strchr a

Re: [patch cygwin]: Replace inline-assembler in string.h by C implementation

2012-10-25 Thread Corinna Vinschen
On Oct 25 10:17, Christopher Faylor wrote: > On Thu, Oct 25, 2012 at 10:48:39AM +0200, Corinna Vinschen wrote: > >On Oct 24 18:02, Kai Tietz wrote: > >>2012/10/24 Christopher Faylor wrote: > >>>On Wed, Oct 24, 2012 at 11:07:47AM -0400, Ryan Johnson wrote: > >

Re: [WIP] mingw64 related changes to Cygwin configure and other assorted files with departed w32api/mingw

2012-11-12 Thread Corinna Vinschen
ith a matching change, I can give it a try on 64 bit tomorrow. I'm a bit puzzled about the necessity of some of the changes to source files. Yaakov's Fedora 17 version of the headers is supposedly cut from the mingw64 trunk on 2012-10-16, while JonY's official headers have an

Re: [WIP] mingw64 related changes to Cygwin configure and other assorted files with departed w32api/mingw

2012-11-13 Thread Corinna Vinschen
On Nov 12 22:31, Christopher Faylor wrote: > On Mon, Nov 12, 2012 at 07:02:57PM -0500, Christopher Faylor wrote: > >On Mon, Nov 12, 2012 at 10:50:23PM +0100, Corinna Vinschen wrote: > >>I'm a bit puzzled about the necessity of some of the changes to source > >>files

Re: [WIP] mingw64 related changes to Cygwin configure and other assorted files with departed w32api/mingw

2012-11-13 Thread Corinna Vinschen
On Nov 13 12:39, Christopher Faylor wrote: > On Tue, Nov 13, 2012 at 10:33:01AM +0100, Corinna Vinschen wrote: > >I would also like to keep the ifndef/define brackets in > >the headers since > > > > #ifndef _CYGWIN_IF_H_ > > #define _CYGWIN_IF_H_ > > >

Re: [WIP] mingw64 related changes to Cygwin configure and other assorted files with departed w32api/mingw

2012-11-13 Thread Corinna Vinschen
#x27;d rather like to test it first. I'd like to try to figure out what the _WIN32 problem is first, and I'd like to give it a try in the 64 bit scenario. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat

Re: Try #3 for changes to Cygwin configure

2012-11-14 Thread Corinna Vinschen
to be able to build the utils manually with different optimizing settings: 2012-11-05 Corinna Vinschen <...> * Makefile.in (MINGW_CXX): Attach $(CFLAGS) to allow providing build option tweaks to mingw compiler as well. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat

Re: Try #3 for changes to Cygwin configure

2012-11-14 Thread Corinna Vinschen
On Nov 14 14:08, Christopher Faylor wrote: > On Wed, Nov 14, 2012 at 12:57:07PM +0100, Corinna Vinschen wrote: > >For a start I applied the patch to CVS HEAD and ran a stock `configure; > >make' from toplevel on Fedora 17 with Yaakov's Cygwin packages. > >

Re: Console modes: cursor style

2013-01-11 Thread Corinna Vinschen
gt; Thomas > > 2013-01-13 Thomas Wolff <...> > > * fhandler.h (class dev_console): Flag for expanded control sequence. > * fhandler_console.cc (char_command): Supporting cursor style modes. Patch applied. Can you provide a patch for the docs, too, pl

Re: Console modes: cursor style

2013-01-11 Thread Corinna Vinschen
On Jan 11 13:52, Thomas Wolff wrote: > On 11.01.2013 12:05, Corinna Vinschen wrote: > >On Jan 11 09:33, Thomas Wolff wrote: > >>The attached patch adds two escape control sequences to the Cygwin Console: > >> > >> * Show/Hide Cursor (DECTCEM) > >

Re: Console modes: cursor style

2013-01-12 Thread Corinna Vinschen
On Jan 12 17:56, Thomas Wolff wrote: > Am 11.01.2013 14:34, schrieb Corinna Vinschen: > >On Jan 11 13:52, Thomas Wolff wrote: > >>On 11.01.2013 12:05, Corinna Vinschen wrote: > >>>On Jan 11 09:33, Thomas Wolff wrote: > >>>>The attached patch ad

Re: [PATCH 64bit] lsaauth: skip 32bit DLL on 64bit target

2013-02-15 Thread Corinna Vinschen
On Feb 14 20:09, Yaakov wrote: > 2013-02-14 Yaakov Selkowitz > > * Makefile.in: Do not build or install 32bit DLL for 64bit target. Please apply. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer

Re: [PATCH 64bit] utils: port dumper to 64bit

2013-02-15 Thread Corinna Vinschen
ame (HANDLE hProcess, LPVOID BaseAddress) > { >DWORD len; >MODULEINFO mi; > @@ -103,7 +103,7 @@ psapi_get_module_name (HANDLE hProcess, > goto failed; > } > > - if ((DWORD) (mi.lpBaseOfDll) == BaseAddress) > + if ((SIZE_T) (mi.lpBaseOfDll) == BaseAddress) + if (mi.lpBaseOfDll == BaseAddress) Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat

Re: [PATCH 64bit] utils: port dumper to 64bit

2013-02-17 Thread Corinna Vinschen
Hi Yaakov, On Feb 17 04:41, Yaakov wrote: > On Fri, 15 Feb 2013 12:04:31 +0100, Corinna Vinschen wrote: > > On Feb 15 02:02, Yaakov wrote: > > > I just uploaded cygwin64-libiconv, cygwin64-gettext, and > > > cygwin64-libbfd to Ports, so that dumper.exe could be built.

Re: [PATCH 64bit] Fix speclib for x86_64

2013-02-17 Thread Corinna Vinschen
Makefile patch is fine, but for the speclib change I wonder why we should omit the leading underscore. If you remove the underscore, you're polluting the application namespace. Is there really a good reason to do that? Did I miss something? Thanks, Corinna -- Corinna Vinschen

Re: [PATCH 64bit] Fix speclib for x86_64

2013-02-17 Thread Corinna Vinschen
On Feb 17 11:52, Christopher Faylor wrote: > On Sun, Feb 17, 2013 at 02:41:41PM +0100, Corinna Vinschen wrote: > >On Feb 17 04:46, Yaakov wrote: > > > >> 2013-02-16 Yaakov Selkowitz > >> > >>* Makefile.in (libcygwin.a): Move --target flag from

Re: [PATCH 64bit] Fix speclib for x86_64

2013-02-17 Thread Corinna Vinschen
On Feb 17 12:18, Christopher Faylor wrote: > On Sun, Feb 17, 2013 at 06:09:44PM +0100, Corinna Vinschen wrote: > >On Feb 17 11:52, Christopher Faylor wrote: > >> On Sun, Feb 17, 2013 at 02:41:41PM +0100, Corinna Vinschen wrote: > >> >On Feb 17 04:46, Yaakov wrote: >

Re: Qsort defects (in C-library)

2013-02-18 Thread Corinna Vinschen
d of good style not to send the entire code, but rather a context diff relative to current CVS. For anonymous CVS access, see the "Download" link at http://sourceware.org/newlib/ Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer

Re: [PATCH 64bit] ssize_t

2013-02-20 Thread Corinna Vinschen
On Feb 20 03:32, Yaakov (Cygwin/X) wrote: > Here is the patch for cygwin necessary for my newly-posted newlib patch. Good catch! Feel free to apply the Cygwin patch independently from the newlib patch. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cyg

Re: [PATCH 64bit] ssize_t

2013-02-20 Thread Corinna Vinschen
t's not exactly surprising. As soon as our GCC switches to the large code model (I explained on the developer's list) we will have to rebuild once more. And then again, none of these early packages are for the distro anyway, so we will probably see a few more rebuilds :) No worries, Cori

Re: [PATCH 64bit] Export symbols with underscore

2013-02-21 Thread Corinna Vinschen
e underscored _get_osfhandle and _setmode since these are non-standard entry points anyway, and we also have to keep some underscored exports for newlib. But we should not add the MSVCRT ANSI calls back (like _access). That was plainly wrong to begin with. Corinna -- Corinna Vinschen

Re: [PATCH 64bit] lsaauth: skip 32bit DLL on 64bit target, part 2

2013-02-21 Thread Corinna Vinschen
; > * Makefile.in (target_alias): Define for previous commit. > * configure.in: Skip check for i686-w64-mingw32-g++ on x86_64. Please apply. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat

Re: [PATCH 64bit] Export symbols with underscore

2013-02-22 Thread Corinna Vinschen
hould go, no doubt about it. For get_osfhandle and setmode I would prefer maintaining backward compatibility with existing applications. Both variations, with and without underscore are definitely in use. What about exporting the underscored variants only, but define the non-underscored o

Re: [PATCH 64bit] Export symbols with underscore

2013-02-22 Thread Corinna Vinschen
On Feb 22 09:00, Corinna Vinschen wrote: > On Feb 22 01:51, Christopher Faylor wrote: > > On Fri, Feb 22, 2013 at 12:18:48AM -0600, Yaakov wrote: > > >On Thu, 21 Feb 2013 14:42:36 -0500, Christopher Faylor wrote: > > >> I wasn't fulling grokking the fact

Re: [PATCH 64bit] Export symbols with underscore

2013-02-22 Thread Corinna Vinschen
On Feb 22 03:40, Yaakov wrote: > On Fri, 22 Feb 2013 09:49:51 +0100, Corinna Vinschen wrote: > > > access should go, no doubt about it. > > > > > > For get_osfhandle and setmode I would prefer maintaining backward > > > compatibility with existing a

Re: [PATCH 64bit] Export symbols with underscore

2013-02-22 Thread Corinna Vinschen
On Feb 22 10:51, Corinna Vinschen wrote: > On Feb 22 03:40, Yaakov wrote: > > On Fri, 22 Feb 2013 09:49:51 +0100, Corinna Vinschen wrote: > > > > access should go, no doubt about it. > > > > > > > > For get_osfhandle and setmode I would prefer ma

Re: [PATCH 64bit] Export symbols with underscore

2013-02-22 Thread Corinna Vinschen
On Feb 22 09:32, Christopher Faylor wrote: > On Fri, Feb 22, 2013 at 11:02:55AM +0100, Corinna Vinschen wrote: > >On Feb 22 10:51, Corinna Vinschen wrote: > >> On Feb 22 03:40, Yaakov wrote: > >> > On Fri, 22 Feb 2013 09:49:51 +0100, Corinna Vinschen wrote: > &g

Re: [PATCH 64bit] Export symbols with underscore

2013-02-22 Thread Corinna Vinschen
On Feb 22 10:27, Christopher Faylor wrote: > On Fri, Feb 22, 2013 at 03:44:48PM +0100, Corinna Vinschen wrote: > >On Feb 22 09:32, Christopher Faylor wrote: > >> On Fri, Feb 22, 2013 at 11:02:55AM +0100, Corinna Vinschen wrote: > >> >On Feb 22 10:51, Corinna Vinschen

Re: [PATCH 64bit] Fix ONDEE for 64bit

2013-03-04 Thread Corinna Vinschen
blem! Please apply the Cygwin changes. I'll rebuild new base packages including the gcc patches soon. Thanks again, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat

Re: [PATCH 64bit] Fix ONDEE for 64bit

2013-03-04 Thread Corinna Vinschen
On Mar 4 05:39, Yaakov wrote: > On Mon, 4 Mar 2013 11:51:34 +0100, Corinna Vinschen wrote: > > That looks good, thanks for catching this problem! Please apply the > > Cygwin changes. I'll rebuild new base packages including the gcc > > patches soon. > > BTW,

Re: [PATCH 64bit] Fix ONDEE for 64bit

2013-03-04 Thread Corinna Vinschen
On Mar 4 14:15, Corinna Vinschen wrote: > On Mar 4 05:39, Yaakov wrote: > > On Mon, 4 Mar 2013 11:51:34 +0100, Corinna Vinschen wrote: > > > That looks good, thanks for catching this problem! Please apply the > > > Cygwin changes. I'll rebuild new base packages

Re: [PATCH 64bit] Fix ONDEE for 64bit

2013-03-05 Thread Corinna Vinschen
On Mar 5 00:09, Yaakov wrote: > On Mon, 4 Mar 2013 15:40:22 +0100, Corinna Vinschen wrote: > > On Mar 4 14:15, Corinna Vinschen wrote: > > > Thanks, but here's a question: If the libgcj ABI version really changes > > > with every GCC major.minor release

Re: [PATCH 64bit] Fix ONDEE for 64bit

2013-03-05 Thread Corinna Vinschen
On Mar 5 03:14, Yaakov wrote: > On Tue, 5 Mar 2013 09:49:50 +0100, Corinna Vinschen wrote: > > On Mar 5 00:09, Yaakov wrote: > > > I don't know if the version changes are a matter of policy or just how > > > it has happened, but in any case that's not the cu

Re: [PATCH 64bit] Fix ONDEE for 64bit

2013-03-05 Thread Corinna Vinschen
On Mar 5 10:30, Corinna Vinschen wrote: > On Mar 5 03:14, Yaakov wrote: > > On Tue, 5 Mar 2013 09:49:50 +0100, Corinna Vinschen wrote: > > > On Mar 5 00:09, Yaakov wrote: > > > > I don't know if the version changes are a matter of policy or just how >

Re: [PATCH 64bit] Fix ONDEE for 64bit

2013-03-15 Thread Corinna Vinschen
On Mar 15 05:18, Yaakov wrote: > On Tue, 5 Mar 2013 10:38:50 +0100, Corinna Vinschen wrote: > > What about > > > > #if BUILDING_GCC_MAJOR == 4 > > #define LIBGCJ_SONAME "cyggcj-" __cyg_mkstr (BUILDING_GCC_MINOR+6) ".dll" > > #else >

Re: [PATCH 64bit] Fix ONDEE for 64bit

2013-03-16 Thread Corinna Vinschen
On Mar 15 16:56, Yaakov wrote: > On Fri, 15 Mar 2013 11:26:55 +0100, Corinna Vinschen wrote: > > ftp://ftp.cygwin.com/pub/cygwin/64bit/x86_64-pc-cygwin-gcc-20130305.patch > > > > I didn't change anything in the toolchain since then. > > This hunk doesn'

Re: [PATCH 64bit] Fix ONDEE for 64bit

2013-03-18 Thread Corinna Vinschen
ntil I can get a > native gnat 4.8, but the current tip of this branch builds successfully > for C/C++/Fortran/ObjC/ObjC++. Do you have a full diff relative to GCC HEAD? Thanks. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat

Re: [PATCH 64bit] Fix ONDEE for 64bit, part 2

2013-03-20 Thread Corinna Vinschen
t's ok as I did it. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat

Re: [PATCH 64bit] Fix ONDEE for 64bit

2013-03-22 Thread Corinna Vinschen
On Mar 22 02:23, Yaakov wrote: > On Mon, 18 Mar 2013 11:09:24 +0100, Corinna Vinschen wrote: > > On Mar 17 18:49, Yaakov wrote: > > > On Sun, 17 Mar 2013 04:18:25 -0500, Yaakov (Cygwin/X) wrote: > > > > I also discovered two more gcc macros which were missing updates

Re: Forgotted appersand

2013-04-02 Thread Corinna Vinschen
tribute (FILE_ATTRIBUTE_SPARSE_FILE) > && length >= fsi.EndOfFile.QuadPart + (128 * 1024)) > { > status = NtFsControlFile (get_handle (), NULL, NULL, NULL, &io, Thanks for catching! I just applied the patch. Thanks, Corinna -- Corinna Vi

Re: [PATCH] DocBook XML toolchain modernization

2013-05-13 Thread Corinna Vinschen
s, albeit calld *.xml now, still have this cosy sgml feeling to them :) Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat

Re: [PATCH] DocBook XML toolchain modernization

2013-05-13 Thread Corinna Vinschen
interfaces aren't going to change and we haven't made a habit of > adding new DOCTOOL tags. I don't know who first thought that adding > these was a good idea (it may predate my time on the project even > though CVS insists that I added it with version 1.1) but, if Corinna >

Re: [PATCH] DocBook XML toolchain modernization

2013-05-23 Thread Corinna Vinschen
will do nothing: $ make make: Nothing to be done for `all'. Can you fix that, please? Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat

Re: [PATCH] DocBook XML toolchain modernization

2013-05-23 Thread Corinna Vinschen
On May 23 16:02, Corinna Vinschen wrote: > Hi Warren, > > On May 1 18:11, Warren Young wrote: > > On 4/30/2013 13:07, Christopher Faylor wrote: > > >On Tue, Apr 30, 2013 at 12:58:49PM -0600, Warren Young wrote: > > > > > >>Do you mean for me to ch

Re: [PATCH] DocBook XML toolchain modernization

2013-05-23 Thread Corinna Vinschen
On May 23 13:03, Warren Young wrote: > On 5/23/2013 08:11, Corinna Vinschen wrote: > >On May 23 16:02, Corinna Vinschen wrote: > >>For some reason doc/Makefile.in has lost all dependencies > > I noted that in the original proposal: one of the things you got > from doct

Re: [PATCH] DocBook XML toolchain modernization

2013-06-04 Thread Corinna Vinschen
Hi Warren, On May 23 21:50, Corinna Vinschen wrote: > On May 23 13:03, Warren Young wrote: > > On 5/23/2013 08:11, Corinna Vinschen wrote: > > >On May 23 16:02, Corinna Vinschen wrote: > > >>For some reason doc/Makefile.in has lost all dependencies > > >

Re: [PATCH] Export rawmemchr

2013-06-24 Thread Corinna Vinschen
Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat

Re: [PATCH] Prototype initstate() etc. if _XOPEN_SOURCE is defined appropriately

2013-11-13 Thread Corinna Vinschen
* include/cygwin/stdlib.h(initstate, random, setstate, srandom) : > Prototype if not __STRICT_ANSI__ or _XOPEN_SOURCE is defined > appropriately. Looks good to me. Please apply. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin M

Re: fix off-by-one in dup2

2013-12-04 Thread Corinna Vinschen
he top of my head I don't understand why Eric's as well as cgf's solution (which are not equivalent) both introduce this problem, but always using NOFILE_INCR works, so I publish it here for discussion. I'm off for a doc appointment now, maybe I have some clue while sitting in

Re: fix off-by-one in dup2

2013-12-04 Thread Corinna Vinschen
On Dec 4 10:32, Corinna Vinschen wrote: > Hi guys, > > > I'm not quite sure yet *why* this happens, but this change in > dtable::find_unused_handle... > > On Sep 25 17:26, Eric Blake wrote: > > [...] > > diff --git i/winsup/cygwin/dtable.cc w/winsup/cygwi

Re: fix off-by-one in dup2

2013-12-04 Thread Corinna Vinschen
On Dec 4 12:36, Corinna Vinschen wrote: > On Dec 4 10:32, Corinna Vinschen wrote: > > Hi guys, > > [...etc...] > > The problem is still present in the current sources. > > [...] Ouch, ouch, ouch! I tested the wrong DLL. Actually current CVS fixes this problem. Du

Re: fix off-by-one in dup2

2013-12-04 Thread Corinna Vinschen
On Dec 4 12:00, Christopher Faylor wrote: > On Wed, Dec 04, 2013 at 01:04:08PM +0100, Corinna Vinschen wrote: > >On Dec 4 12:36, Corinna Vinschen wrote: > >> On Dec 4 10:32, Corinna Vinschen wrote: > >> > Hi guys, > >> > [...etc...] > >> &g

Re: fix off-by-one in dup2

2013-12-04 Thread Corinna Vinschen
On Dec 4 12:51, Christopher Faylor wrote: > On Wed, Dec 04, 2013 at 06:23:24PM +0100, Corinna Vinschen wrote: > >On Dec 4 12:00, Christopher Faylor wrote: > >> On Wed, Dec 04, 2013 at 01:04:08PM +0100, Corinna Vinschen wrote: > >> >On Dec 4 12:36, Corinna Vinschen

Re: [PATCH] FAQ update: packages needed to build Cygwin

2014-01-07 Thread Corinna Vinschen
> Cheers, > > ..mark > > > > 2013-12-31 Mark Geisert <...> > > * faq-programming.xml: Update packages needed to build Cygwin. Patch applied (including followup patch). Thanks, Corinna -- Corinna Vinschen Please, send mails regar

Re: [PATCH] Fix some debug string format specifiers.

2014-01-07 Thread Corinna Vinschen
quot; , + "[mcleanup2] frompc 0x%zd selfpc 0x%zd count %zd\n" , 0x prefix and 'd' format specifier? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgps5LrT2Mmft.pgp Description: PGP signature

Re: [PATCH] Fix potentially uninitialized variable p

2014-01-07 Thread Corinna Vinschen
On Dec 22 00:40, Ray Donnelly wrote: > [PATCH 2/3] * winsup/cygwin/strace.cc (strace::vsprntf): Fix potentially > uninitialized variable p p is never uninitialized in this code. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Main

Re: [PATCH] Reattach trailing dirsep on existing directories too.

2014-01-07 Thread Corinna Vinschen
doing the wrong thing. What is this patch trying to accomplish? Do you have example user space code which is failing for this very reason? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgp9nuNd

Re: [PATCH] Reattach trailing dirsep on existing directories too.

2014-01-08 Thread Corinna Vinschen
On Jan 7 18:15, Ray Donnelly wrote: > On Tue, Jan 7, 2014 at 3:12 PM, Corinna Vinschen wrote: > > On Dec 22 01:03, Ray Donnelly wrote: > >> I hope this is OK and I've done it in the best place. Please advise if > >> it needs any changes. > > > > I have

Re: [PATCH] Reattach trailing dirsep on existing directories too.

2014-01-08 Thread Corinna Vinschen
On Jan 8 10:49, Ray Donnelly wrote: > On Wed, Jan 8, 2014 at 9:20 AM, Corinna Vinschen wrote: > > On Jan 7 18:15, Ray Donnelly wrote: > >> On Tue, Jan 7, 2014 at 3:12 PM, Corinna Vinschen wrote: > >> > On Dec 22 01:03, Ray Donnelly wrote: > >> >> I

Re: [PATCH] Add minidump write utility

2014-02-07 Thread Corinna Vinschen
his. I agree, but, like some other parts of our utils, you don't have to put the Red Hat copyright in there if you go with a BSD-style license, Jon. Look at the header of ldd.cc. This is fine for new Cygin utils. Just one, really important point: Would you mind to add documentation for the

Re: [PATCH] Add minidump write utility

2014-02-08 Thread Corinna Vinschen
On Feb 8 15:00, Jon TURNEY wrote: > On 07/02/2014 19:18, Corinna Vinschen wrote: > > On Feb 7 12:44, Christopher Faylor wrote: > >> On Fri, Feb 07, 2014 at 04:36:01PM +, Jon TURNEY wrote: > >>> > >>> This patch adds a 'minidumper' utility,

Re: [PATCH] Buffer over-run fix for getusershell(3)

2014-05-19 Thread Corinna Vinschen
x27; that would occur if > /etc/shells contained a line longer than 4095 characters. Thanks, patch applied. Just your ChangeLog needs a bit of work. The Cygwin dir has its own ChangeLog file so the path should be relative to that: * syscalls.cc (getusershell): ... Thanks, C

Re: Rename detached debug info as cygwin1.dll.dbg

2014-05-23 Thread Corinna Vinschen
the next cygport file slightly. Chris might have to tweak the snapshot generation script as well, so he probably wants to chime in, too. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgpNFNDBIBzkq.pgp Description: PGP signature

Re: typo correction in grp.cc

2014-06-16 Thread Corinna Vinschen
, %u, %p, %d)", > ret, user, gid, groups, *ngroups); > > > Please apply. Done. Thanks a lot. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgpLoyDoJlIqe.pgp Description: PGP signature

Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory

2014-06-17 Thread Corinna Vinschen
ce I pulled the code in from FreeBSD in 2006 so I had ... some ... reason. Which eludes me. I applied David's patch. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgpiab1WlhWXm.pgp Description: PGP signature

Re: [PATCH] default to normal pthread mutexes

2014-07-14 Thread Corinna Vinschen
d_mutex_unlock returned EINVAL if the mutex is of the PTHREAD_MUTEX_ERRORCHECK type and the mutex wasn't owned by any thread (as in your STC), Linux returns EPERM in this case. I fixed that. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin M

Re: namespace safety with attributes

2014-08-01 Thread Corinna Vinschen
ames with __, for > namespace safety. > * include/cygwin/core_dump.h: Likewise. > * include/cygwin/cygwin_dll.h: Likewise. > * include/sys/cygwin.h: Likewise. > * include/sys/strace.h: Likewise. Thanks, please apply. Corinna -- Corinna Vinschen

Re: docs: improve package maintainer instructions

2014-08-04 Thread Corinna Vinschen
dates"? I for one think it's time to switch to a single packaging method. After all, you don't have rpm packages in Debian or apt packages in Fedora. This will also greatly simplify to set up an automated build system for Cygwin packages at one point. (yada, yada, git package DB,

Re: docs: improve package maintainer instructions

2014-08-04 Thread Corinna Vinschen
On Aug 4 13:28, Eric Blake wrote: > On 08/04/2014 03:14 AM, Corinna Vinschen wrote: > > > I'm fine with the changes, barring Yaakov's nits. > > I fixed those. > > > > > However, while we're at it shouldn't we change from "cygport is th

Re: [PATCH] cygcheck -m, --check-mtimes option

2014-08-08 Thread Corinna Vinschen
OK(1 newer) /usr/bin/which.exe (changed 146 days after install) or (uh oh!): which 2.20-2 OK(1 newer) /usr/bin/which.exe (changed 71 days ago) > Documentation update and changelog entry are still missing. Sure, no worries for now.

Re: [PATCH] cygcheck -m, --check-mtimes option

2014-08-08 Thread Corinna Vinschen
On Aug 8 12:31, Corinna Vinschen wrote: > Hi Christian, > > On Aug 7 22:15, Christian Franke wrote: > > Attached is an experimental patch which adds -m, --check-mtimes[=SECONDS] > > option to cygcheck. It provides an IMO useful heuristics to find files > > possibly

Re: [PATCH] cygcheck -m, --check-mtimes option

2014-08-14 Thread Corinna Vinschen
On Aug 13 22:20, Christian Franke wrote: > Hi Corinna, > > Corinna Vinschen wrote: > >On Aug 8 12:31, Corinna Vinschen wrote: > >>Hi Christian, > >> > >>On Aug 7 22:15, Christian Franke wrote: > >>>Attached is an experimental patch which add

Re: [PATCH] Fix crash of ffs (0x80000000) on 64 bit

2014-10-08 Thread Corinna Vinschen
014-09-23 Christian Franke <...> > > * syscall.cc (ffs): Fix crash of ffs (0x8000) on 64 bit. Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgph0o0QJcDey.pgp Description: PGP signature

Re: [PATCH] Disable AF_UNIX handshake with setsockopt(..., SO_PEERCRED, ...)

2014-10-09 Thread Corinna Vinschen
{ > + set_errno (EINVAL); > + return -1; > +} > + if (connect_state () != unconnected) ^^^' Wouldn't it make sense to allow this call in the "listener" state as well? Thanks, Corinna -- Corinna Vinschen

Re: [PATCH] Disable AF_UNIX handshake with setsockopt(..., SO_PEERCRED, ...)

2014-10-10 Thread Corinna Vinschen
On Oct 9 20:21, Christian Franke wrote: > Corinna Vinschen wrote: > >>+int > >>+fhandler_socket::af_local_set_no_getpeereid () > >>+{ > >>+ if (get_addr_family () != AF_LOCAL || get_socket_type () != SOCK_STREAM) > >>+{ >

Re: [PATCH] Disable AF_UNIX handshake with setsockopt(..., SO_PEERCRED, ...)

2014-10-10 Thread Corinna Vinschen
On Oct 10 18:36, Christian Franke wrote: > Corinna Vinschen wrote: > >I was just looking into applying your patch when I got thinking over the > >change in select.cc once more. You're setting the connect_state from > >connect_pending to connected there when there&

Re: [PATCH] Disable AF_UNIX handshake with setsockopt(..., SO_PEERCRED, ...)

2014-10-11 Thread Corinna Vinschen
On Oct 10 20:04, Corinna Vinschen wrote: > On Oct 10 18:36, Christian Franke wrote: > > After a nonblocking connect(), postfix calls poll() with pollfd.events = > > POLLIN only. If poll() succeeds, it calls recv(). This fails with ENOTCONN > > because the state is still con

Re: [PATCH] Disable AF_UNIX handshake with setsockopt(..., SO_PEERCRED, ...)

2014-10-13 Thread Corinna Vinschen
On Oct 13 07:37, Christian Franke wrote: > Corinna Vinschen wrote: > >On Oct 10 20:04, Corinna Vinschen wrote: > >>In short, the whole code is written under the assumption that any sane > >>application calling nonblocking connect would always call select/poll to > &

Re: [PATCH] Disable AF_UNIX handshake with setsockopt(..., SO_PEERCRED, ...)

2014-10-13 Thread Corinna Vinschen
On Oct 13 10:20, Corinna Vinschen wrote: > On Oct 13 07:37, Christian Franke wrote: > > Corinna Vinschen wrote: > > >On Oct 10 20:04, Corinna Vinschen wrote: > > >>In short, the whole code is written under the assumption that any sane > > >>application cal

Re: Fix performance on 10Gb networks

2014-11-18 Thread Corinna Vinschen
GE_SIZE of 4K. And this makes me wonder. Did you intend to use 60K and ended up with 62K for a reason? And then, why not 63K as a multiple of 1K? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgpmWC4vx5U6F.pgp Description: PGP signature

Re: Fix performance on 10Gb networks

2014-11-20 Thread Corinna Vinschen
ified patch. > > On Tue, Nov 18, 2014 at 8:43 PM, Corinna Vinschen > wrote: > > Hi Iuliu, > > > > On Nov 18 19:30, Iuliu Rus wrote: > >> Hello, > >> Google is running Cygwin apps on its 10Gb networks and we are seeing > >> extremely bad p

Re: Fix performance on 10Gb networks

2014-11-20 Thread Corinna Vinschen
much appreciate if you would take another look into this. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgpSYoK6w5Zg1.pgp Description: PGP signature

Re: [PATCH] build PDFs with xmlto (was: Instability with signals and threads)

2014-11-28 Thread Corinna Vinschen
moval. Looks good. Please apply. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgpE4kZcWy12x.pgp Description: PGP signature

Re: [PATCH] qsort_r (pending newlib patch)

2014-12-05 Thread Corinna Vinschen
itto. > (std-notes): Add section for qsort_r. > > cygwin/ > * common.din (__bsd_qsort_r): Add. > (qsort_r): Add. > * include/cygwin/version.h (CYGWIN_VERSION_API_MINOR): Bump. Ok to apply when the newlib change is in. Thanks, Corinna -- Corinna Vinsch

Re: [PATCH] Export new stdio and stdio_ext functions

2014-12-18 Thread Corinna Vinschen
ked, fputs_unlocked, fputwc_unlocked, > +fputws_unlocked, fread_unlocked, fwrite_unlocked, getwc_unlocked, > +getwchar_unlocked, putwc_unlocked, putwchar_unlocked. > + to release/1.7.34 as well. Thanks, Corinna -- Corinna Vinschen Please, send mails regar

Re: [PATCH] spelling fix for struct passwd

2014-12-18 Thread Corinna Vinschen
ntsec.xml (ntsec-logonuser): Fix spelling of pw_passwd field. Thanks, please apply. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgp2SzMcwsGyk.pgp Description: PGP signature

Re: tracing malloc/free call

2015-01-16 Thread Corinna Vinschen
Hi Marco, On Jan 16 15:23, Marco Atzeri wrote: > On 1/15/2015 10:34 AM, Corinna Vinschen wrote: > >Bottom line, you should be able to fetch the original return address by > >printing the value at > > > > *(void*)_my_tls->stackptr > > > >which points to

Re: tracing malloc/free call

2015-01-16 Thread Corinna Vinschen
On Jan 16 16:44, Corinna Vinschen wrote: > Hi Marco, > > On Jan 16 15:23, Marco Atzeri wrote: > > On 1/15/2015 10:34 AM, Corinna Vinschen wrote: > > >Bottom line, you should be able to fetch the original return address by > > >printing the value at > &

Re: tracing malloc/free call

2015-01-16 Thread Corinna Vinschen
On Jan 16 16:44, Corinna Vinschen wrote: > On Jan 16 15:23, Marco Atzeri wrote: > > Attached patch that allows tracking of original caller, > > for the 4 memory allocation calls. > > Thanks for the patch, but it won't work nicely either this way. The > problem is tha

Re: tracing malloc/free call

2015-01-16 Thread Corinna Vinschen
On Jan 16 18:33, Marco Atzeri wrote: > On 1/16/2015 5:22 PM, Corinna Vinschen wrote: > >On Jan 16 16:44, Corinna Vinschen wrote: > >>On Jan 16 15:23, Marco Atzeri wrote: > >>>Attached patch that allows tracking of original caller, > >>>for the 4 memory

Re: [PATCH] Add-on to gethostbyname2

2015-01-23 Thread Corinna Vinschen
some wording for the release info in the docs, please? Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat pgpKHY96IvRVQ.pgp Description: PGP signature

<    1   2   3   4   5   6   7   8   9   10   >