Re: [PATCH v4 1/1] Cygwin: pty: Fix state management for pseudo console support.

2019-09-03 Thread Takashi Yano
Hi Corinna, I have posted several patches for PTY with pseudo console support. Please apply them in the following order. [PATCH 1/4] Cygwin: pty: Code cleanup - Cleanup the code which is commented out by #if 0 regarding pseudo console. - Remove #if 1 for experimental code which seems to be

Re: [PATCH v4 1/1] Cygwin: pty: Fix state management for pseudo console support.

2019-09-03 Thread Corinna Vinschen
Hi Takashi, On Sep 3 12:05, Takashi Yano wrote: > > > - Sleep (60); /* Wait for pty_master_fwd_thread() */ > > > + Sleep (20); /* Wait for pty_master_fwd_thread() */ > > > > Isn't that a separate issue as well? A separate patch may be in order > > here, kind of like "Cygwin: pseudo

Re: [PATCH v4 1/1] Cygwin: pty: Fix state management for pseudo console support.

2019-09-02 Thread Takashi Yano
Hi Corinna, On Mon, 2 Sep 2019 16:37:16 +0200 Corinna Vinschen wrote: > > class fhandler_pty_slave: public fhandler_pty_common > > { > >HANDLE inuse;// used to indicate that a tty is in use > >HANDLE output_handle_cyg, io_handle_cyg; > > + DWORD pidRestore; > >

Re: [PATCH v4 1/1] Cygwin: pty: Fix state management for pseudo console support.

2019-09-02 Thread Corinna Vinschen
On Sep 2 07:11, Takashi Yano wrote: > - Pseudo console support introduced by commit > 169d65a5774acc76ce3f3feeedcbae7405aa9b57 has some bugs which > cause mismatch between state variables and real pseudo console > state regarding console attaching and r/w pipe switching. This > patch