Re: [PATCH] Compatibility improvement to reparse point handling, v2

2017-06-13 Thread Joe Lowe
On 2017-06-13 00:57, Corinna Vinschen wrote:> On Jun 12 13:08, Joe Lowe wrote: >> On 2017-06-12 03:27, Corinna Vinschen wrote: >>> On Jun 9 15:44, Joe Lowe wrote: -else +else if (res == -1) { -/* Volume moint point or unrecognized reparse point

Re: [PATCH] Compatibility improvement to reparse point handling, v2

2017-06-12 Thread Joe Lowe
Corinna, I will work through the code and apply your feedback. A few additional comments below. On 2017-06-12 03:27, Corinna Vinschen wrote: On Jun 9 15:44, Joe Lowe wrote: 2nd pass at reparse point handling patch. [...] static inline int readdir_check_reparse_point (POBJECT_ATTRIBUTES

Re: [PATCH] Compatibility improvement to reparse point handling, v2

2017-06-12 Thread Corinna Vinschen
Hi Joe, thanks for the patch. Review inline. On Jun 9 15:44, Joe Lowe wrote: > 2nd pass at reparse point handling patch. > [...] > static inline int > readdir_check_reparse_point (POBJECT_ATTRIBUTES attr) > { > - DWORD ret = DT_UNKNOWN; > + int ret = DT_UNKNOWN; Given that d_type is an

[PATCH] Compatibility improvement to reparse point handling, v2

2017-06-09 Thread Joe Lowe
2nd pass at reparse point handling patch. Patch is intended to improve cygwin application compatibility with native mount points and native symlinks where target does not begin with "\??\X:" or "\??\UNC" or "\??\Volume{". Such symlinks function with native windows apps, but fail today with