Re: [PATCH] for SIGSEGV, compilation error in gcc 4.6

2011-02-10 Thread Corinna Vinschen
On Feb 10 15:15, Corinna Vinschen wrote: On Feb 10 21:47, jojelino wrote: On 2011-02-10 19:02, Corinna Vinschen wrote: Also, it would be nice if you would add more words to explain what your patch is doing. Just a patch with no explanation is not very inviting to take a look at it at

Re: [PATCH] for SIGSEGV, compilation error in gcc 4.6

2011-02-10 Thread jojelino
i am sorry for extra line feed. corrected. requesting review. Index: winsup/cygwin/dcrt0.cc === RCS file: /cvs/src/src/winsup/cygwin/dcrt0.cc,v retrieving revision 1.390 diff -u -r1.390 dcrt0.cc --- winsup/cygwin/dcrt0.cc 26 Dec

Re: [PATCH] for SIGSEGV, compilation error in gcc 4.6

2011-02-10 Thread Corinna Vinschen
On Feb 10 23:56, jojelino wrote: i am sorry for extra line feed. corrected. requesting review. Thanks, will do. Would you mind to give us your real name for the ChangeLog entry? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader

Re: [PATCH] for SIGSEGV, compilation error in gcc 4.6

2011-02-10 Thread jojelino
On 2011-02-11 AM 12:02, Corinna Vinschen wrote: On Feb 10 23:56, jojelino wrote: i am sorry for extra line feed. corrected. requesting review. Thanks, will do. Would you mind to give us your real name for the ChangeLog entry? Corinna Jin-woo Ye.thank you

Re: [PATCH] for SIGSEGV, compilation error in gcc 4.6

2011-02-10 Thread Corinna Vinschen
On Feb 10 10:29, Christopher Faylor wrote: On Thu, Feb 10, 2011 at 03:15:15PM +0100, Corinna Vinschen wrote: Ok, I have just a problem. Your patch doesn't apply because your mail client appears to insert line breaks if the lines get too long. Please send the patch again without the line

Re: [PATCH] for SIGSEGV, compilation error in gcc 4.6

2011-02-10 Thread jojelino
On 2011-02-11 AM 12:32, Christopher Faylor wrote: -void __stdcall +void __stdcall __attribute__ ((regparm (1), noreturn)) do_exit (int status) { no. it doesn't fix sigsegv, but for compilation error in 4.6. to summerize, all changes of function definition fixes compilation error in gcc