On Mon, 2011-04-04 at 01:19 -0400, Christopher Faylor wrote:
There is a __INSIDE_CYGWIN_NET__ which I apparently added ten years ago
but my ideas about naming have changed. I also added
USE_SYS_TYPES_FD_SET which is closer to what I now prefer but it should
have had some leading underscores.
On Apr 4 01:19, Christopher Faylor wrote:
On Sun, Apr 03, 2011 at 07:11:51PM -0500, Yaakov (Cygwin/X) wrote:
On Sun, 2011-04-03 at 19:55 -0400, Christopher Faylor wrote:
+#define __INSIDE_CYGWIN_GNU_DEV__
I'd prefer a more descriptive name like __DONT_DEFINE_INLINE_GNU_DEV
The
On Mon, 2011-04-04 at 12:54 +0200, Corinna Vinschen wrote:
On Apr 4 01:19, Christopher Faylor wrote:
I'll leave it to Corinna but I'd prefer not adding YA export if we can
avoid it.
This is very simple code, so I, too, would prefer to keep it inline.
Alright, do I still bump
On Apr 4 06:27, Yaakov (Cygwin/X) wrote:
On Mon, 2011-04-04 at 12:54 +0200, Corinna Vinschen wrote:
On Apr 4 01:19, Christopher Faylor wrote:
I'll leave it to Corinna but I'd prefer not adding YA export if we can
avoid it.
This is very simple code, so I, too, would prefer to keep
On Apr 4 07:41, Yaakov (Cygwin/X) wrote:
* include/cygwin/types.h: Move #include sys/sysmacros.h to
end of header so the latter get the dev_t typedef.
* include/sys/sysmacros.h (gnu_dev_major, gnu_dev_minor,
gnu_dev_makedev): Prototype and define as inline functions.
When building Qt Creator, I encountered a compile error because its code
uses 'major' and 'minor' as variable names. Looking at the current
sys/sysmacros.h, which is pulled in automatically by sys/types.h,
makes it obvious why that doesn't work.
Since this code obviously compiles on Linux, I
On Sun, Apr 03, 2011 at 06:37:25PM -0500, Yaakov (Cygwin/X) wrote:
When building Qt Creator, I encountered a compile error because its code
uses 'major' and 'minor' as variable names. Looking at the current
sys/sysmacros.h, which is pulled in automatically by sys/types.h,
makes it obvious why
On Sun, 2011-04-03 at 19:55 -0400, Christopher Faylor wrote:
+#define __INSIDE_CYGWIN_GNU_DEV__
I'd prefer a more descriptive name like __DONT_DEFINE_INLINE_GNU_DEV
The __INSIDE_CYGWIN_foo__ naming scheme seems to be what is used
elsewhere for similar purposes, hence my choice here.
but,
On Sun, Apr 03, 2011 at 07:11:51PM -0500, Yaakov (Cygwin/X) wrote:
On Sun, 2011-04-03 at 19:55 -0400, Christopher Faylor wrote:
+#define __INSIDE_CYGWIN_GNU_DEV__
I'd prefer a more descriptive name like __DONT_DEFINE_INLINE_GNU_DEV
The __INSIDE_CYGWIN_foo__ naming scheme seems to be what is
