Re: [PATCH] regtool: Ignore /proc/registry{,32,64}/ prefix, with forward or backslashes, allowing path completion

2019-11-13 Thread Corinna Vinschen
On Nov 11 13:47, Brian Inglis wrote: > On 2019-11-11 09:28, Corinna Vinschen wrote: > > Ok, we can add something to the help text, but the text still sounds > > confusing, even the altenative one. I think the reason is the negative > > expression "ignore" here. Why not express this in a positive

Re: [PATCH] regtool: Ignore /proc/registry{,32,64}/ prefix, with forward or backslashes, allowing path completion

2019-11-11 Thread Brian Inglis
On 2019-11-11 09:28, Corinna Vinschen wrote: > On Nov 11 08:30, Brian Inglis wrote: >> On 2019-11-11 02:19, Corinna Vinschen wrote: >>> On Nov 11 10:13, Corinna Vinschen wrote: On Nov 10 09:14, Brian Inglis wrote: The patch idea is nice. Two nits, though. Please shorten the commit

Re: [PATCH] regtool: Ignore /proc/registry{,32,64}/ prefix, with forward or backslashes, allowing path completion

2019-11-11 Thread Corinna Vinschen
On Nov 11 08:30, Brian Inglis wrote: > On 2019-11-11 02:19, Corinna Vinschen wrote: > > On Nov 11 10:13, Corinna Vinschen wrote: > >> On Nov 10 09:14, Brian Inglis wrote: > >> The patch idea is nice. Two nits, though. > >> Please shorten the commit msg summary line and add a bit of descriptive >

Re: [PATCH] regtool: Ignore /proc/registry{,32,64}/ prefix, with forward or backslashes, allowing path completion

2019-11-11 Thread Brian Inglis
On 2019-11-11 02:19, Corinna Vinschen wrote: > On Nov 11 10:13, Corinna Vinschen wrote: >> On Nov 10 09:14, Brian Inglis wrote: >> The patch idea is nice. Two nits, though. >> Please shorten the commit msg summary line and add a bit of descriptive >> text instead. Sorry, I forget and don't

Re: [PATCH] regtool: Ignore /proc/registry{,32,64}/ prefix, with forward or backslashes, allowing path completion

2019-11-11 Thread Corinna Vinschen
On Nov 11 10:13, Corinna Vinschen wrote: > Hi Brian, > > > The patch idea is nice. Two nits, though. > > Please shorten the commit msg summary line and add a bit of descriptive > text instead. > > > On Nov 10 09:14, Brian Inglis wrote: > > --- > > winsup/utils/regtool.cc | 13 -

Re: [PATCH] regtool: Ignore /proc/registry{,32,64}/ prefix, with forward or backslashes, allowing path completion

2019-11-11 Thread Corinna Vinschen
Hi Brian, The patch idea is nice. Two nits, though. Please shorten the commit msg summary line and add a bit of descriptive text instead. On Nov 10 09:14, Brian Inglis wrote: > --- > winsup/utils/regtool.cc | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff

[PATCH] regtool: Ignore /proc/registry{,32,64}/ prefix, with forward or backslashes, allowing path completion

2019-11-10 Thread Brian Inglis
--- winsup/utils/regtool.cc | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/winsup/utils/regtool.cc b/winsup/utils/regtool.cc index a44d90768..ddb1304cd 100644 --- a/winsup/utils/regtool.cc +++ b/winsup/utils/regtool.cc @@ -167,7 +167,9 @@ usage (FILE *where =