Re: [PATCH draft 0/6] Remove the fhandler_base_overlapped class

2019-06-11 Thread Ken Brown
On 6/11/2019 12:42 PM, Michael Haubenwallner wrote: > > > On 6/11/19 10:48 AM, Corinna Vinschen wrote: >> Hi Ken, >> >> On Jun 8 12:20, Ken Brown wrote: >>> On 6/7/2019 5:43 PM, Ken Brown wrote: On 6/7/2019 3:13 PM, Ken Brown wrote: > On 6/7/2019 2:31 PM, Achim Gratz wrote: >> Ken B

Re: [PATCH draft 0/6] Remove the fhandler_base_overlapped class

2019-06-11 Thread Michael Haubenwallner
On 6/11/19 10:48 AM, Corinna Vinschen wrote: > Hi Ken, > > On Jun 8 12:20, Ken Brown wrote: >> On 6/7/2019 5:43 PM, Ken Brown wrote: >>> On 6/7/2019 3:13 PM, Ken Brown wrote: On 6/7/2019 2:31 PM, Achim Gratz wrote: > Ken Brown writes: >> I think I've found the problem. I was mish

Re: [PATCH draft 0/6] Remove the fhandler_base_overlapped class

2019-06-11 Thread Corinna Vinschen
Hi Ken, On Jun 8 12:20, Ken Brown wrote: > On 6/7/2019 5:43 PM, Ken Brown wrote: > > On 6/7/2019 3:13 PM, Ken Brown wrote: > >> On 6/7/2019 2:31 PM, Achim Gratz wrote: > >>> Ken Brown writes: > I think I've found the problem. I was mishandling signals that arrived > during a > re

Re: [PATCH draft 0/6] Remove the fhandler_base_overlapped class

2019-06-08 Thread Ken Brown
On 6/7/2019 5:43 PM, Ken Brown wrote: > On 6/7/2019 3:13 PM, Ken Brown wrote: >> On 6/7/2019 2:31 PM, Achim Gratz wrote: >>> Ken Brown writes: I think I've found the problem. I was mishandling signals that arrived during a read. But after I fix that, there's still one nagging issu

Re: [PATCH draft 0/6] Remove the fhandler_base_overlapped class

2019-06-07 Thread Ken Brown
On 6/7/2019 3:13 PM, Ken Brown wrote: > On 6/7/2019 2:31 PM, Achim Gratz wrote: >> Ken Brown writes: >>> I think I've found the problem. I was mishandling signals that arrived >>> during a >>> read. But after I fix that, there's still one nagging issue involving >>> timerfd >>> code. I'll writ

Re: [PATCH draft 0/6] Remove the fhandler_base_overlapped class

2019-06-07 Thread Achim Gratz
Achim Gratz writes: > Anything triggering a race or deadlock will depend on so many other > things that it really is no surprise to see seemingly unrelated changes > making the bug appear or disappear. There are certainly races left in > Cygwin, I see them from time to time in various Perl modules

Re: [PATCH draft 0/6] Remove the fhandler_base_overlapped class

2019-06-07 Thread Ken Brown
On 6/7/2019 2:31 PM, Achim Gratz wrote: > Ken Brown writes: >> I think I've found the problem. I was mishandling signals that arrived >> during a >> read. But after I fix that, there's still one nagging issue involving >> timerfd >> code. I'll write to the main list with details. I *think* it

Re: [PATCH draft 0/6] Remove the fhandler_base_overlapped class

2019-06-07 Thread Achim Gratz
Ken Brown writes: > I think I've found the problem. I was mishandling signals that arrived > during a > read. But after I fix that, there's still one nagging issue involving > timerfd > code. I'll write to the main list with details. I *think* it's a timerfd > bug, > but it's puzzling tha

Re: [PATCH draft 0/6] Remove the fhandler_base_overlapped class

2019-06-07 Thread Ken Brown
On 6/3/2019 12:35 PM, Corinna Vinschen wrote: > On May 30 12:56, Ken Brown wrote: >> On 5/26/2019 11:10 AM, Ken Brown wrote: >>> fhandler_pipe is currently the only class derived from >>> fhandler_base_overlapped. This patch series rewrites parts of >>> fhandler_pipe so that it can be derived from

Re: [PATCH draft 0/6] Remove the fhandler_base_overlapped class

2019-06-03 Thread Corinna Vinschen
On May 30 12:56, Ken Brown wrote: > On 5/26/2019 11:10 AM, Ken Brown wrote: > > fhandler_pipe is currently the only class derived from > > fhandler_base_overlapped. This patch series rewrites parts of > > fhandler_pipe so that it can be derived from fhandler_base instead. > > We can then simplify

Re: [PATCH draft 0/6] Remove the fhandler_base_overlapped class

2019-05-30 Thread Ken Brown
On 5/26/2019 11:10 AM, Ken Brown wrote: > fhandler_pipe is currently the only class derived from > fhandler_base_overlapped. This patch series rewrites parts of > fhandler_pipe so that it can be derived from fhandler_base instead. > We can then simplify the code by removing fhandler_base_overlappe

[PATCH draft 0/6] Remove the fhandler_base_overlapped class

2019-05-26 Thread Ken Brown
fhandler_pipe is currently the only class derived from fhandler_base_overlapped. This patch series rewrites parts of fhandler_pipe so that it can be derived from fhandler_base instead. We can then simplify the code by removing fhandler_base_overlapped. In particular, this gets rid of the peculiar