Re: memmem issues

2008-01-10 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Corinna Vinschen on 12/20/2007 3:11 AM: | + /* FIXME - this algorithm is worst-case O(l_len*s_len)... | | or what about Boyer-Moore instead: | | http://de.wikipedia.org/wiki/Boyer-Moore-Algorithmus (in German) | | Using one of them is

Re: memmem issues

2007-12-20 Thread Corinna Vinschen
On Dec 19 21:01, Eric Blake wrote: Index: libc/memmem.cc === RCS file: /cvs/src/src/winsup/cygwin/libc/memmem.cc,v retrieving revision 1.1 diff -u -p -r1.1 memmem.cc --- libc/memmem.cc8 Nov 2005 22:08:39 - 1.1 +++

Re: memmem issues

2007-12-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 12/19/2007 2:22 PM: memmem isn't standardized, but even so, it has some bugs based on comparison with strstr. memmem(haystack,len,,0) should return haystack, not NULL. This should be an easy one-line fix.