Re: ntsec patch #4: passwd and group

2002-11-20 Thread Corinna Vinschen
On Wed, Nov 20, 2002 at 11:29:08AM -0500, Pierre A. Humblet wrote: > > How would you like to remove LookupAccountSidA? Just remove it and > > debug_printf ("Failed to get primary group name.") ? > > OK, the debug printf can be removed too, the result will be visible in the > other debug_printf be

Re: ntsec patch #4: passwd and group

2002-11-20 Thread Pierre A. Humblet
Corinna Vinschen wrote: > The problem I'm talking about is beyond this patch. Just reiterating > (so we know that we're talking about the same): > > We talked about the need to use a static buffer in the external > getpwXXX and getgrXXX functions to allow apps to use the last return > value (a p

Re: ntsec patch #4: passwd and group

2002-11-20 Thread Corinna Vinschen
On Wed, Nov 20, 2002 at 10:04:53AM -0500, Pierre A. Humblet wrote: > Corinna Vinschen wrote: > > Ahem, I thought we agreed that we don't call external functions from > > inside Cygwin? Never mind, there are still some of them which we have > > to eliminate, anyway. > > I didn't know about that po

Re: ntsec patch #4: passwd and group

2002-11-20 Thread Pierre A. Humblet
Corinna Vinschen wrote: > > Some questions and comments: > > > > > * security.h: [...]. Undeclare internal_getpwent. > ^^^ > You didn't. Sorry, looks like I messed up my versions. It was done at some point. >

Re: ntsec patch #4: passwd and group

2002-11-20 Thread Corinna Vinschen
On Sun, Nov 17, 2002 at 10:44:18PM -0500, Pierre A. Humblet wrote: > Corinna, > > Almost same as last week, but with the diff and ChangeLog against current CVS. > I also made a small change. > [...] Some questions and comments: > > * security.h: [...]. Undeclare internal_getpwent.

Re: ntsec patch #4: passwd and group

2002-11-17 Thread Pierre A. Humblet
Corinna, Almost same as last week, but with the diff and ChangeLog against current CVS. I also made a small change. Pierre At 09:52 AM 11/15/2002 -0500, Pierre A. Humblet wrote: >Corinna, > >Here is the ntsec patch #4 diff. As discussed before, the main motivation >was to handle more robustly in

Re: ntsec patch #4: passwd and group

2002-11-15 Thread Corinna Vinschen
On Fri, Nov 15, 2002 at 09:52:52AM -0500, Pierre A. Humblet wrote: > Corinna, > > Here is the ntsec patch #4 diff. As discussed before, the main motivation Oh boy, I didn't even manage to look into #2. Next week, ok? Corinna -- Corinna Vinschen Please, send mails regarding Cy

Re: ntsec patch #4: passwd and group

2002-11-15 Thread Pierre A. Humblet
Corinna, Here is the ntsec patch #4 diff. As discussed before, the main motivation was to handle more robustly incomplete passwd and group files. In the process I fixed some bugs in related code and added getpwsid and getgrsid. This does not try to completely address the issue of invalid pointers