security.cc and sec_acl.cc (ntsec, inheritance and sec_acl)

2002-12-16 Thread Pierre A. Humblet
Corinna, Here are the changes to security.cc and sec_acl.cc to use well_known_creator_xxx_sid. They seem to work fine on NT4. There is peculiar effect: if a directory was created e.g. 427 by a ntsec user with uid != gid and a file is created in the directory by a Windows user with gid == uid,

Re: security.cc and sec_acl.cc (ntsec, inheritance and sec_acl)

2002-12-16 Thread Corinna Vinschen
Hi Pierre, On Mon, Dec 16, 2002 at 10:31:16AM -0500, Pierre A. Humblet wrote: I have a question: there is code in setacl (new line 139) to merge non-default ACE's with previous default ACEs. As the acl was sorted, I don't see how that code can ever be exercised. Should we try to merge

Re: security.cc and sec_acl.cc (ntsec, inheritance and sec_acl)

2002-12-16 Thread Pierre A. Humblet
Corinna Vinschen wrote: Hi Pierre, On Mon, Dec 16, 2002 at 10:31:16AM -0500, Pierre A. Humblet wrote: I have a question: there is code in setacl (new line 139) to merge non-default ACE's with previous default ACEs. As the acl was sorted, I don't see how that code can ever be exercised.

Re: security.cc and sec_acl.cc (ntsec, inheritance and sec_acl)

2002-12-16 Thread Pierre A. Humblet
Pierre A. Humblet wrote: But frankly I don't understand why it happens! OK, I do now. The code is looking forward to entries that are not yet processed. Pierre

Re: security.cc and sec_acl.cc (ntsec, inheritance and sec_acl)

2002-12-16 Thread Pierre A. Humblet
Pierre A. Humblet wrote: But frankly I don't understand why it happens! OK, I do now. The code is looking forward to entries that are not yet processed. ... and thus it may merge entries for the current owner and for the default owner (creator_owner). Ditto for groups. That's not good, I

Re: security.cc and sec_acl.cc (ntsec, inheritance and sec_acl)

2002-12-16 Thread Corinna Vinschen
On Mon, Dec 16, 2002 at 01:26:31PM -0500, Pierre A. Humblet wrote: ... and thus it may merge entries for the current owner and for the default owner (creator_owner). Ditto for groups. What? How should it? It only merges entries with the same uid/gid and with the same type (USER/GROUP). It