work around gcc bug in signal.h

2010-04-27 Thread Eric Blake
might still want to consider simplifying things in siginfo_t - an anonymous union containing a single anonymous struct containing a single anonymous union seems wasteful, and we can prune two of those scopes whether or not we also name the outer union. 2010-04-27 Eric Blake * include/c

add mkostemp

2010-07-19 Thread Eric Blake
). [1] http://lists.gnu.org/archive/html/bug-coreutils/2010-07/msg00114.html Okay to commit, along with a corresponding patch to doc/new-features.sgml and a cygwin-specific patch to newlib's stdlib.h? 2010-07-19 Eric Blake * mktemp.cc (_gettemp): Add flags argument. All ca

Re: add mkostemp

2010-07-19 Thread Eric Blake
>= 4)? The mkostemp[s] additions are guarded by the same levels as mkstemps, since all three interfaces are equally non-portable. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org From 6659d25bad3c852afab62536814ab253437e9ff6 Mon Sep 17 00:00:

provide __xpg_strerror_r

2011-02-05 Thread Eric Blake
you get with a leading double-underscore interface), when _POSIX_C_VERSION is high enough and _GNU_SOURCE is not in effect. Since __xpg_strerror_r is undeclared, we don't have to care about tweaking newlib's string.h for this patch (gnulib does a link-test probe for its existence)

Re: provide __xpg_strerror_r

2011-02-05 Thread Eric Blake
On 02/05/2011 01:28 PM, Christopher Faylor wrote: > On Sat, Feb 05, 2011 at 01:04:16PM -0700, Eric Blake wrote: >> Our strerror_r is lousy (it doesn't even match glibc's behavior); see my >> request to the newlib list. > > We really should just implement strerror_

Re: provide __xpg_strerror_r

2011-02-09 Thread Eric Blake
de/cygwin/version.h | 3 +- 4 files changed, 68 insertions(+), 29 deletions(-) 2011-02-09 Eric Blake * errno.cc (__xpg_strerror_r): New function. (strerror_r): Update comments to match newlib's fixes. (strerror): Set errno on failure. (_sys_errlist):

Re: provide __xpg_strerror_r

2011-02-10 Thread Eric Blake
On 02/10/2011 02:55 AM, Corinna Vinschen wrote: > On Feb 10 10:50, Corinna Vinschen wrote: >> On Feb 9 21:15, Christopher Faylor wrote: >>> On Wed, Feb 09, 2011 at 05:20:59PM -0700, Eric Blake wrote: >>>> +/* Newlib's provides declarations for two strerro

Re: provide __xpg_strerror_r

2011-02-10 Thread Eric Blake
On 02/10/2011 12:58 PM, Christopher Faylor wrote: > On Thu, Feb 10, 2011 at 10:37:45AM -0700, Eric Blake wrote: >> Pushed, and squashed into minor version 236. I've also updated >> new-features.sgml. > > Thanks Eric. Shoot - I pushed too early; I'm pushing

Re: src/winsup/doc ChangeLog new-features.sgml

2011-02-15 Thread Eric Blake
.cgi/src/winsup/doc/new-features.sgml.diff?cvsroot=src&r1=1.64&r2=1.65 > File system access via block devices works. For instance > +(note the trailing backslash!) > + > +bash$ cd /proc/sys/Device/HarddiskVolumeShadowCopy1/ That's a trailing slash, not backslash. -- Eric Blak

Re: [PATCH] False positive from access("/proc/registry/...", F_OK)

2011-05-04 Thread Eric Blake
On 05/04/2011 02:09 PM, Christian Franke wrote: > Done, tested and attached. > > Christian > > { > + /* Key does not exist or open failed with EACCESS, > + enumerate subkey and value names of parent key. */ EACCES, not EACCESS. -- Eric Blake eb

__xpg_strerror_r should not clobber strerror buffer

2011-05-21 Thread Eric Blake
likewise. 2011-05-21 Eric Blake * errno.cc (strerror): Print unknown errno as int. (__xpg_strerror_r): Likewise, and don't clobber strerror buffer. Index: errno.cc === RCS file: /cvs/src/src/winsup/cygwin/errno

Re: __xpg_strerror_r should not clobber strerror buffer

2011-05-23 Thread Eric Blake
On 05/21/2011 07:35 PM, Christopher Faylor wrote: > On Sat, May 21, 2011 at 07:26:37PM -0600, Eric Blake wrote: >> POSIX says that no other function in the standard should clobber the >> strerror buffer. Our strerror_r is a GNU extension, so it can get away >> with clobberi

Re: __xpg_strerror_r should not clobber strerror buffer

2011-05-23 Thread Eric Blake
On 05/23/2011 02:45 PM, Eric Blake wrote: > On 05/21/2011 07:35 PM, Christopher Faylor wrote: >> On Sat, May 21, 2011 at 07:26:37PM -0600, Eric Blake wrote: >>> POSIX says that no other function in the standard should clobber the >>> strerror buffer. Our strerror_r is

fix perror POSIX compliance

2011-05-23 Thread Eric Blake
+++ winsup/cygwin/cygtls.h |1 + winsup/cygwin/errno.cc | 43 --- winsup/cygwin/tlsoffsets.h | 82 ++-- 4 files changed, 78 insertions(+), 54 deletions(-) 2011-05-23 Eric Blake * cygtls.h (strerror_r_buf): New

Re: fix perror POSIX compliance

2011-05-25 Thread Eric Blake
On 05/24/2011 04:09 AM, Corinna Vinschen wrote: > On May 23 17:28, Eric Blake wrote: >> This depends on the newlib patch: >> http://sourceware.org/ml/newlib/2011/msg00215.html >> >> In fact, if that patch goes in, then this one is required to avoid a >> link fai

Re: pthread_sigmask bug

2011-07-09 Thread Eric Blake
On 07/09/2011 12:58 AM, Corinna Vinschen wrote: > On Jul 8 17:16, Eric Blake wrote: >> The current implementation of pthread_sigmask violates POSIX: > > PTC? winsup/cygwin/ChangeLog |6 ++ winsup/cygwin/signal.cc | 10 ++ 2 files changed, 12 insertions(

Re: Extend faq.using to discuss fork failures

2011-08-26 Thread Eric Blake
est adding an tag around BLODA, to point users to the list of known bad software. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-05 Thread Eric Blake
ode> As long as you're touching this code, fix this incorrect comment. A status is 16 bits, and looks like: <1 byte info> <1 byte code> -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: ptsname_r

2011-11-07 Thread Eric Blake
On 11/07/2011 01:46 PM, Eric Blake wrote: Thanks. Also, even with your patches of today, ptsname() is still not thread-safe; should we be sticking that in a thread-local buffer rather than in static storage, similar to how other functions like strerror() are thread-safe? I didn't tackle

Re: [PATCH] Add get_current_dir_name(3)

2012-01-02 Thread Eric Blake
> +{ > + cwd = (char *) malloc (strlen (pwd) + 1); Memory leak. You need to free(cwd) before reassigning it. And why are you using malloc(strlen())/strcpy(), when you could just use strdup()? -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] Add scandirat(3)

2012-02-21 Thread Eric Blake
e a welcome addition to have pathconfat(), although this hasn't yet happened on the Linux side of things, let alone any POSIX proposal. At any rate, +1 for having this in cygwin. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature

fix tcgetsid return type

2012-02-27 Thread Eric Blake
Detected by gnulib's unit tests. POSIX requires tcgetsid to return pid_t, not int. 2012-02-27 Eric Blake * include/sys/termios.h (tcgetsid): Fix return type. * termios.cc (tcgetsid): Likewise. * fhandler_termios.cc (fhandler_termios::tcgetsid): Lik

Re: fix tcgetsid return type

2012-02-28 Thread Eric Blake
On 02/27/2012 04:57 PM, Christopher Faylor wrote: > On Mon, Feb 27, 2012 at 04:25:36PM -0700, Eric Blake wrote: >> Detected by gnulib's unit tests. POSIX requires tcgetsid to return >> pid_t, not int. >> >> 2012-02-27 Eric Blake >> >> * inclu

Re: avoid calling strlen() twice in readlink()

2012-03-08 Thread Eric Blake
MIN (buflen, pathbuf_len); >memcpy (buf, pathbuf.get_win32 (), len); For that matter, is calling pathbuf.get_win32() twice worth factoring out? -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: /dev/clipboard pasting with small read() buffer

2012-08-16 Thread Eric Blake
oblems as MB_CUR_MAX. POSIX requires MB_LEN_MAX to be a constant, only MB_CUR_MAX can be dynamic. We cannot change MB_LEN_MAX to be dynamic in the future. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

fix off-by-one in dup2

2013-09-25 Thread Eric Blake
of 256) setdtablesize() => guarantees that dtable.size is at least that large (must be <= soft limit), but does not lower dtable.size or change limits = 2013-09-25 Eric Blake dup2: fix off-by-one crash * dtable.cc (dup3): Fix off-by-one. (find_unused_handle): Reduce

Re: fix off-by-one in dup2

2013-11-23 Thread Eric Blake
On 10/15/2013 08:06 AM, Christopher Faylor wrote: > On Wed, Sep 25, 2013 at 05:26:25PM -0600, Eric Blake wrote: >> Solves the segfault here: http://cygwin.com/ml/cygwin/2013-09/msg00397.html >> but does not address the fact that we are still screwy with regards to >> rlimit.

Re: fix off-by-one in dup2

2013-12-05 Thread Eric Blake
this order, it would >> have to call extend 5 times. > > dtable.h:#define NOFILE_INCR32 > > It shouldn't extend in that scenario. The table starts with 32 > elements. Rather, the table starts with 256 elements; which is why dup2 wouldn't crash until dup'i

namespace safety with attributes

2014-07-31 Thread Eric Blake
, precisely so that public headers can use attributes without risk of collision with macros belonging to user namespace). 2014-07-31 Eric Blake * include/pthread.h: Decorate attribute names with __, for namespace safety. * include/cygwin/core_dump.h: Likewise

docs: improve package maintainer instructions

2014-08-02 Thread Eric Blake
08-02 Eric Blake * setup.html: Modernize, point to package-upload.html -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org ? setup.patch Index: setup.html === RCS file: /cvs/c

Re: docs: improve package maintainer instructions

2014-08-04 Thread Eric Blake
using the cygport tool, which +automatically handles most of the above issues for you. It is also +strongly recommended to convert existing packages to cygport when +updating them; ask on the cygwin-apps list if you need help +converting an existing package to use cygport. Making a pac

Re: [PATCH] Hide sethostname() in unistd.h

2015-06-17 Thread Eric Blake
the mix adds another perspective. But yeah, I don't see busybox becoming the default source of these apps, so much as an alternative implementation. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] cygwin: update child info magic

2016-02-12 Thread Eric Blake
whitespace, we could postprocess (turn all newlines and space sequences into a single space); but this is a case of introducing whitespace, making the problem trickier, if -P doesn't work. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] cygwin: update child info magic

2016-02-12 Thread Eric Blake
"_" >> + "child_proc_info"); >> } > > Is that deliberate or a bug? Deliberate. gcc 5 now adds additional #line directives around every macro expansion that came from a different file, so that you c

Re: [PATCH] ccwrap: fix build with non-english locale set

2016-02-29 Thread Eric Blake
does not exist\n" unless exists > $ENV{$ccorcxx}; > +$ENV{'LANG'} = 'C'; This won't work if I have LC_ALL set in my environment. If you want to force the locale, you want to set LC_ALL (highest priority), not LANG (lowest priority). -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] Re: Cygwin select() issues and improvements

2016-03-19 Thread Eric Blake
sn't mean you can avoid cleaning things up and posting an improved version. The goal of patch submissions is to make the reviewer's job easier, even if it makes it longer for you to post the perfect patch series. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Declaration of crypt

2016-06-09 Thread Eric Blake
Using [64] rather than * gives a bit more indication about the size of the array that must be passed, but doesn't change the compiler behavior. > Or would you rather follow Posix here? > >> Thanks a lot and sorry again, > > No problem. Revised patch attached. > > Ken &

[PATCH] Fix 32-bit SSIZE_MAX

2016-07-13 Thread Eric Blake
hile ssize_t is int). Unfortunately gcc gives us neither __SSIZE_TYPE__ nor __SSIZE_MAX__. On the other hand, our limits.h is specific to cygwin, we can just shortcut to the correct results rather than being generic to all possible ABI. Signed-off-by: Eric Blake --- winsup/cygwin/includ

Re: [PATCH] Fix 32-bit SSIZE_MAX

2016-07-14 Thread Eric Blake
On 07/14/2016 09:09 AM, Corinna Vinschen wrote: > On Jul 13 15:02, Eric Blake wrote: >> POSIX requires that SSIZE_MAX have the same type as ssize_t, but >> on 32-bit, we were defining it as a long even though ssize_t >> resolves to an int. It also requires that SSIZE

Re: Return the correct value for sysconf(_SC_PAGESIZE)

2016-11-16 Thread Eric Blake
size) to compute the values in bytes. If /proc//statm is reporting memory in multiples that are not the POSIX _SC_PAGESIZE, that is a bug in the statm file emulation that should be fixed there. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

[PATCH] headers: avoid bareword attributes

2017-08-16 Thread Eric Blake
Always use the __-decorated form of an attribute name in public headers, as the bareword form is in the user's namespace, and we don't want compilation to break just because the user defines the bareword to mean something else. Signed-off-by: Eric Blake --- winsup/cygwin/include/cygwi

Re: renameat2

2017-08-18 Thread Eric Blake
rsion.h > +++ b/winsup/cygwin/include/cygwin/version.h > @@ -481,12 +481,14 @@ details. */ >314: Export explicit_bzero. >315: Export pthread_mutex_timedlock. >316: Export pthread_rwlock_timedrdlock, pthread_rwlock_timedwrlock. > + 317: Export renameat2. Add RENAME_N

Re: [PATCH] winsup/doc/etc.postinstall.cygwin-doc.sh fix shell variable typo

2017-12-20 Thread Eric Blake
[ -r $target ] && $mks $CYGWINFORALL -P -n "Cygwin/$name" -d "$desc" -- $target Wrong. Needs to be [ -r "$target" ] to be properly quoted. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: [PATCH] Cygwin: add secure_getenv

2019-02-19 Thread Eric Blake
then we need secure_getenv() to reflect that emulation. > > So if there is something wrong with the patch, then AFAIK gnulib is > wrong too. Eric? The patch may be overly strict (returning NULL where it doesn't have to), but that does not make it wrong in my eyes. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH] Cygwin: add secure_getenv

2019-02-19 Thread Eric Blake
in right now, just as on BSDs. If that's the right thing > to do for BSD, it's not... *really* wrong for Cygwin either, regardless > what Linux is doing. > > That in turn means Yaakov's patch is perfeclty fine since it's equivalent > to the above gnulib code.

Re: [PATCH] default ps -W process start time to system boot time when inaccessible, 0, -1

2019-03-23 Thread Eric Blake
at is going on. On the other hand, the lie is pretty realistic - the program can't have been running longer than your computer has been powered on, and all such affected programs will have the same timestamp. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Vir

Re: [PATCH v2] Cygwin: rmdir: fail if last component is a symlink, as on Linux

2019-09-24 Thread Eric Blake
ce both give ENOTEMPTY, > + we're okay. */ > + char *buf; > + char *p = stpcpy (buf = tp.c_get (), dir) - 1; > + dir = buf; > + while (p > dir && isdirsep (*p)) > + *p-- = '\0'; > + } >if (!(fh = build

Re: [PATCH v2] Cygwin: rmdir: fail if last component is a symlink, as on Linux

2019-09-24 Thread Eric Blake
stent with Linux is reasonable. (I still hope that POSIX will relax its stance to allow both Solaris AND Linux behaviors, but that's not going to happen any time soon...) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH v2 0/3] Support opening a symlink with O_PATH | O_NOFOLLOW

2020-01-13 Thread Eric Blake
ossible to correctly implement fchmodat(AT_SYMLINK_NOFOLLOW); it is only with the recent introduction of the fchmodat2() syscall that this has become possible (https://patchwork.kernel.org/patch/9596301/) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-

Re: [PATCH v2 0/3] Support opening a symlink with O_PATH | O_NOFOLLOW

2020-01-13 Thread Eric Blake
ame as lchownat(). But if it fails in Linux, then we don't have to do any better. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Patch: Re: Bug in stat()?

2002-05-02 Thread Eric Blake
Is this the right list for this patch? I feel like I was writing to /dev/null with the main cygwin list, as no one has responded to this thread. Original Message From: Eric Blake <[EMAIL PROTECTED]> Subject: Patch: Re: Bug in stat()? To: [EMAIL PROTECTED] CC: Eric

Re: patch to allow touch to work on HPFS (and others, maybe??)

2005-02-10 Thread Eric Blake
Corinna Vinschen redhat.com> writes: > > Hey, why do you give up so quickly? If it's not the one way, it might > be another one. For us unknowing folks which have no OS/2 box with > HPFS to mount, would you mind to run the below application on your NT > box and paste the output into the reply?

Re: patch to allow touch to work on HPFS (and others, maybe??)

2005-02-10 Thread Eric Blake
42/ eblake) Access: 2005-02-10 16:12:49.289725000 -0700 Modify: 2005-02-10 16:12:49.289725000 -0700 Change: 2005-02-10 16:12:49.289725000 -0700 -- Eric Blake

Re: patch to allow touch to work on HPFS (and others, maybe??)

2005-02-14 Thread Eric Blake
Corinna Vinschen redhat.com> writes: > > That could be a result of the Cygwin internals. I assume that the > CreateFile call requesting any write access fails on both filesystems. > If you have a look into utimes, you see that Cygwin ignores this case: > > h = CreateFile() > if ((h == INVAL

Re: patch to allow touch to work on HPFS (and others, maybe??)

2005-02-14 Thread Eric Blake
Corinna Vinschen redhat.com> writes: > > I guess trying my approach isn't the worst one, though. We should > use that as a start point for further experimenting, IMHO. I'll check > that in. > Checking win32.has_acls() and using GENERIC_WRITE caused a regression in utimes (). The new upstream

patch for devices.in

2005-02-23 Thread Eric Blake
Found this when reviewing the change to add /dev/full 2005-02-23 Eric Blake <[EMAIL PROTECTED]> (tiny change) * devices.in (parsedisk): Fix typo. Index: cygwin/devices.in === RCS file: /cvs/src/src/winsup/

exceeding PATH_MAX

2005-03-26 Thread Eric Blake
0. But POSIX states that PATH_MAX includes the trailing NUL, so there is no reason for cygwin to short-change the length by a byte. This patch fixes the smaller issues: 2005-03-26 Eric Blake <[EMAIL PROTECTED]> * errno.cc (FILENAME_EXCED_RANGE): Map to ENAMETOOLONG. *

Re: exceeding PATH_MAX

2005-03-28 Thread Eric Blake
Christopher Faylor cygwin.com> writes: > >2005-03-26 Eric Blake byu.net> > > > > * errno.cc (FILENAME_EXCED_RANGE): Map to ENAMETOOLONG. > > This is apparently fixing the symptom rather than the problem. Cygwin > is supposed to be detecting if the name is

Re: [Patch]: mkdir -p and network drives

2005-05-06 Thread Eric Blake
sibility to 555. Also, what should //.. resolve to, / or //? And if it resolves to /, should // be an entry in the readdir() of /? I would argue that //.. should resolve to //, meaning we just have two distinct roots in the directory tree. - -- Life is short - so eat dessert first! Eric Blake

Re: [Patch]: mkdir -p and network drives

2005-05-06 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > I thought that Eric Blake implied that // *had* to be translated to /, > as per POSIX. I wonder how many programs out there translate a > standalone '//' to '/'. No, POSIX requires that / be untouched, // be implementa

Re: [Patch]: mkdir -p and network drives

2005-05-09 Thread Eric Blake
Pierre A. Humblet phumblet.no-ip.org> writes: > > Here is a patch to allow mkdir -p to easily work with network > drives and to allow future enumeration of computers and of > network drives by ls -l. > > It works by defining a new FH_NETDRIVE virtual handler for > names such as // and //machine.

Re: [Patch]: mkdir -p and network drives

2005-05-13 Thread Eric Blake
empty" but that's a fix > for another day. Why change it? POSIX specifies EROFS if the directory to be removed is on a read-only filesystem, which sounds like the right error for rmdir("//") to me. -- Eric Blake

Re: [Patch]: mkdir -p and network drives

2005-05-19 Thread Eric Blake
n your example, but it is not a bug. - -- Life is short - so eat dessert first! Eric Blake [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.0 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Thunderbi

bug in stdint.h

2005-05-23 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Found a typo in /usr/include/stdint.h: 2005-05-23 Eric Blake <[EMAIL PROTECTED]> * include/stdint.h (INTMAX_C, UINTMAX_C): Fix definition. Index: include/stdint.h =

question on limits.h

2005-05-27 Thread Eric Blake
couldn't find it in limits.h. 2005-05-27 Eric Blake <[EMAIL PROTECTED]> (LLONG_MIN, LLONG_MAX, ULLONG_MAX): Always define. Index: cygwin/include/limits.h === RCS file: /cvs/src/src/winsup/cygwin/include/limits.h,v

cygcheck exit status

2005-07-05 Thread Eric Blake
As mentioned on cygwin (hopefully I'm not falling afoul of trivial patch size, since I don't have assignment; and hopefully gmane didn't kill this): 2005-07-05 Eric Blake <[EMAIL PROTECTED]> * cygcheck.cc (track_down, cygcheck): Return true on success. (ma

Re: cygcheck exit status

2005-07-05 Thread Eric Blake
Christopher Faylor cygwin.com> writes: > > On Tue, Jul 05, 2005 at 08:49:06PM +0000, Eric Blake wrote: > > -1677,7 +1681,7 main (int argc, char **argv) > > { > >if (i) > > puts (""); > >- cygcheck (argv[i]);

Re: cygcheck exit status

2005-07-06 Thread Eric Blake
eturns_true_on_failure(); return failed ? EXIT_FAILURE : EXIT_SUCCESS; But I hate thinking in negative logic, hence my definition of cygcheck to return true on success.] -- Eric Blake

cygcheck .exe magic

2005-07-19 Thread Eric Blake
I was annoyed that "cygcheck bash" worked but "cygcheck /bin/bash" did not. 2005-07-19 Eric Blake <[EMAIL PROTECTED]> * cygcheck.cc (find_on_path): Perform .exe magic on non-PATH search. -- Eric Blake Index

Re: cygcheck .exe magic

2005-07-19 Thread Eric Blake
sting, but only because I was short-circuiting when the first stat failed, and appending the .exe happened to be the right thing to do. Since this is not a cygwin app, there is no .exe magic in stat() to counteract, and all we really need to do is see if appending the suffix makes stat succeed.

Re: Problem with sh/bash and snapshot cygwin1-20050825.dll

2005-08-26 Thread Eric Blake
;, but realpath("../..", buf) is >> mistakenly "/". > >http://cygwin.com/acronyms/#PTC Unfortunately, I don't have copyright assignment (I've tried convincing my employer; I'll try again), and this would push me over my current contribution limits.

fix ARG_MAX

2005-09-06 Thread Eric Blake
patch, see the thread at http://lists.gnu.org/archive/html/bug-findutils/2005-09/msg00039.html 2005-09-06 Eric Blake <[EMAIL PROTECTED]> * include/limits.h (ARG_MAX): New limit. * sysconf.cc (sysconf): _SC_ARG_MAX: Use it. Index: sysc

PING: fix ARG_MAX

2005-09-10 Thread Eric Blake
Eric Blake byu.net> writes: Just making sure this patch didn't fall through the cracks... > > 2005-09-06 Eric Blake byu.net> > > * include/limits.h (ARG_MAX): New limit. > * sysconf.cc (sysconf): _SC_ARG_MAX: Use it. Even with your recent patch

Re: PING: fix ARG_MAX

2005-09-12 Thread Eric Blake
2k limit unless it can find a way to query cygwin whether a particular executable can be given a larger limit. - -- Life is short - so eat dessert first! Eric Blake [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (Cygwin) Comment: Public key at home.comcast.

Re: PING: fix ARG_MAX

2005-09-20 Thread Eric Blake
G_MAX), where a PATH search were done when filename does not contain '/', then pathconf could return 32k on Windows processes, and unlimited (or an actual known limit) for cygwin processes, so that xargs can then allow unlimited -s sizes for cygwin processes but cap windows processe

Re: PING: fix ARG_MAX

2005-09-21 Thread Eric Blake
even larger, since cygwin processes really can pass more than 1 meg. > > But, then, I suspect that this wasn't overrideable when I was providing > xargs either so you can feel free to ignore my request. Correct, your earlier releases of xargs could not exceed your hardcoded ARG

Re: d_ino deprecated in latest snapshot

2005-12-10 Thread Eric Blake
g changes to the header and then rectified the behavior > by submitting a patch. 2005-12-10 Eric Blake <[EMAIL PROTECTED]> * include/sys/dirent.h (struct dirent): Deprecate d_ino member. Index: cygwin/include/sys/dirent.h ==

Fix readdir version 2

2006-01-03 Thread Eric Blake
2006-01-03 Eric Blake <[EMAIL PROTECTED]> * dir.cc (readdir_worker): Update saw_dot* flags in version 2. Index: cygwin/dir.cc === RCS file: /cvs/src/src/winsup/cygwin/dir.cc,v retrieving revision 1.99 diff -u -r1.99

managed mounts and "

2006-01-04 Thread Eric Blake
I found it annoying that managed mounts can handle non-printing characters, but not several of the remaining Windows' forbidden characters, such as double quotes. $ cd managed $ touch `printf '\a'` $ touch `printf '"'` touch: cannot touch `"': No such f

export getsubopt

2006-01-06 Thread Eric Blake
Since POSIX requires getsubopt, and newlib provides it, here goes (and let's hope this patch applies cleaner than my previous two): 2006-01-06 Eric Blake <[EMAIL PROTECTED]> * cygwin.din: Export getsubopt. * include/cygwin/version.h: Bump API minor version. Index:

Re: [Patch] regtool: Add load/unload commands and --binary option

2006-03-04 Thread Eric Blake
/ not at the beginning a no-no? // is only special at the beginning. Anywhere else in a filename, POSIX requires /proc/registry/foo and /proc/registry//foo to name the same file. - -- Life is short - so eat dessert first! Eric Blake [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Ve

fcntl debug

2006-03-22 Thread Eric Blake
In an attempt to figure out why my third newlib freopen(NULL) patch still failed (and hence leading to today's fourth patch - man, I have really fat-fingered my efforts to get freopen(NULL) usable), I noticed that an strace of fcntl(F_GETFL) was not as helpful as I would like. 2006-03-22

limits.h missing constants

2006-04-15 Thread Eric Blake
hile I was at it, I noticed that several of the limits.h constants that are required to be the same across all platforms were missing or incorrect. And we might as well publicize our limit for declaring ELOOP on symlink chains, rather than keeping it hidden in path.h. 2006-04-15 Eric Blak

Re: limits.h missing constants

2006-04-15 Thread Eric Blake
> 2006-04-15 Eric Blake <[EMAIL PROTECTED]> > > * include/limits.h (_POSIX_*, _POSIX2_*, _XOPEN_*): Define missing > standard constants, and correct invalid ones. > (CHARCLASS_NAME_MAX): Define. > (SYMLOOP_MAX): Define. > * path.h (MAX_L

mkstemp vs. text mode

2006-04-17 Thread Eric Blake
Eric Blake <[EMAIL PROTECTED]> * mktemp.cc (_gettemp): Open temp files in binary mode. - -- Life is short - so eat dessert first! Eric Blake [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.2.1 (Cygwin) Comment: Public key at home.comcast.net/~eri

Fix UINT{8,16}_C

2006-07-02 Thread Eric Blake
romotes to signed int, when int is wider than char. Gnulib now tests for bugs in stdint.h, and these are the remaining two issues that makes cygwin's version non-compliant: 2006-07-02 Eric Blake <[EMAIL PROTECTED]> * include/stdint.h (UINT8_C, UINT16_C): Unsigned types sma

Re: Fix UINT{8,16}_C

2006-07-03 Thread Eric Blake
k_UINT8_C: (-1 < UINT8_C (0)) == (-1 < (uint_least8_t) 0) ? 1 : -1; int check_UINT16_C: (-1 < UINT16_C (0)) == (-1 < (uint_least16_t) 0) ? 1 : -1; - -- Life is short - so eat dessert first! Eric Blake [EMAIL PROTECTED] -BEGIN PGP SIGNATURE-

Re: [ANNOUNCEMENT] Updated [experimental]: bash-3.1-7

2006-09-12 Thread Eric Blake
ng so and preserve the invocation value and print that?), so I didn't > think to actually 'echo $POSIXLY_CORRECT'. :-) > 2006-09-11 Eric Blake <[EMAIL PROTECTED]> * cygcheck.cc (main): Restore POSIXLY_CORRECT before displaying user's environment. cygwin.patch3 Description: Binary data

Re: [ANNOUNCEMENT] Updated [experimental]: bash-3.1-7

2006-09-13 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Christopher Faylor on 9/12/2006 9:15 AM: >> 2006-09-11 Eric Blake <[EMAIL PROTECTED]> >> >> * cygcheck.cc (main): Restore POSIXLY_CORRECT before displaying >> user's environment. >

get TIOCGWINSZ from

2006-12-06 Thread Eric Blake
Should be safe to apply since neither TIOCGWINSZ nor are specified by POSIX, so we don't have to worry about namespace pollution. 2006-12-06 Eric Blake <[EMAIL PROTECTED]> * include/sys/ioctl.h: Pick up termios.h, for TIOCGWINSZ. - -- Life is short - so eat dessert fi

Re: Increase st_blksize to 64k

2007-01-03 Thread Eric Blake
ooses ST_BLKSIZE at 64k (optimal I/O size) but ST_NBLOCKS/ST_NBLOCKSIZE at the disk granularity (512). - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Cygwin) Comment: Public key

compile warning in cygwin/stat.h

2007-03-13 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This patch: http://cygwin.com/ml/cygwin-cvs/2007-q1/msg00123.html breaks compilation of coreutils against the latest snapshot when using - -Wall -Werror, due to an unused expression on the left of a comma. 2007-03-13 Eric Blake <[EMAIL PROTEC

Re: compile warning in cygwin/stat.h

2007-03-13 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Corinna Vinschen on 3/13/2007 7:22 AM: > On Mar 13 06:30, Eric Blake wrote: >> * include/cygwin/stat.h (S_TYPEISSHM, S_TYPEISSEM, S_TYPEISSHM): >> Avoid compiler warnings. > > Thanks, applied. For all that

Re: stdint.h bug

2007-04-03 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Christopher Faylor on 4/3/2007 1:13 PM: > On Tue, Apr 03, 2007 at 06:15:14PM +0000, Eric Blake wrote: >> Cygwin defines wint_t as unsigned int (valid, per POSIX), but then defines >> >> #ifndef WINT_MIN >> #d

Re: stdint.h bug

2007-04-05 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Corinna Vinschen on 4/4/2007 1:38 AM: > On Apr 3 19:29, Eric Blake wrote: >> * include/stdint.h (WINT_MIN, WINT_MAX): Fix definition. > > Thanks, applied. A two-line patch, and I _still_ managed to botch it. POSI

export a few newlib functions

2007-05-14 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 As discussed this morning: 2007-05-14 Eric Blake <[EMAIL PROTECTED]> * cygwin.din (asnprintf, dprint, _Exit, vasnprintf, vdprintf): Export. * include/cygwin/version.h: Bump API minor number. - -- Don't work too

declare hsearch_r

2007-05-21 Thread Eric Blake
Cygwin already exports newlib's hsearch_r, but failed to declare it in cygwin's replacement . This leads to unnecessary warnings when compiling cygwin, at the point where newlib is trying to compile uses of hsearch_r. 2007-05-21 Eric Blake <[EMAIL PROTECTED]> *

Re: API compatibility documentation change

2007-06-20 Thread Eric Blake
s an emulation > > Shouldn't be too difficult. Also, psignal and psiginfo seem pretty easy to implement. Here's a first patch to the list of functions, by the way, along with recent newlib additions: 2007-06-20 Eric Blake <[EMAIL PROTECTED]> * cygwin.din: Ex

Re: C99 assert

2007-06-26 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 6/26/2007 2:07 PM: > Jeff Johnston redhat.com> writes: [see thread at http://sourceware.org/ml/newlib/2007/msg00763.html - cygwin's assert currently doesn't comply with POSIX] > >> Hi Eric,

Re: C99 assert

2007-06-27 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Corinna Vinschen on 6/27/2007 1:35 AM: >> 2007-06-26 Eric Blake >> >> * assert.cc (__assert_func): New function, to match newlib header >> change. >> * cygwin.din: Export __assert_func. >

  1   2   >