Re: [PATCH v3 0/1] Cygwin: pty: Fix the behaviour of Ctrl-C in the pseudo console mode.
On Sat, 14 Sep 2019 15:29:50 + Ken Brown wrote: > All pushed. Thanks. Thanks. > Do you think there have been enough changes that I should issue another test > release, or do you have more patches in the works? I have submitted three more patches just now. Hopefully, the functional fixes have been settled with these patches, so I think it is ready to issue a new test release. -- Takashi Yano
Re: [PATCH v3 0/1] Cygwin: pty: Fix the behaviour of Ctrl-C in the pseudo console mode.
Hi Takashi, On 9/13/2019 5:52 PM, Takashi Yano wrote: > I submitted five patches during your absence. > > Four of them are for pseudo console support, the other one is for console. > > [PATCH v5 0/1] Cygwin: pty: Fix the behaviour of Ctrl-C in the pseudo console > mode. > [PATCH 0/1] Cygwin: pty: Fix screen alternation while pseudo console > switching. > [PATCH 0/1] Cygwin: pty: Prevent the helper process from exiting by Ctrl-C > [PATCH v2 0/1] Cygwin: pty: Switch input and output pipes individually. > [PATCH 0/1] Cygwin: console: Fix read() in non-canonical mode. All pushed. Thanks. Do you think there have been enough changes that I should issue another test release, or do you have more patches in the works? Ken
Re: [PATCH v3 0/1] Cygwin: pty: Fix the behaviour of Ctrl-C in the pseudo console mode.
Hi Ken, On Fri, 6 Sep 2019 17:59:02 + Ken Brown wrote: > P.S. I'm leaving tomorrow for a short vacation, so I might not have time to > review any more patches until I return in about a week. I submitted five patches during your absence. Four of them are for pseudo console support, the other one is for console. [PATCH v5 0/1] Cygwin: pty: Fix the behaviour of Ctrl-C in the pseudo console mode. [PATCH 0/1] Cygwin: pty: Fix screen alternation while pseudo console switching. [PATCH 0/1] Cygwin: pty: Prevent the helper process from exiting by Ctrl-C [PATCH v2 0/1] Cygwin: pty: Switch input and output pipes individually. [PATCH 0/1] Cygwin: console: Fix read() in non-canonical mode. Could you please review them? -- Takashi Yano
Re: [PATCH v3 0/1] Cygwin: pty: Fix the behaviour of Ctrl-C in the pseudo console mode.
On Sat, 7 Sep 2019 12:20:15 +0900 Takashi Yano wrote: > On Fri, 6 Sep 2019 17:59:02 + > Ken Brown wrote: > > 3. I used ssh from my normal account to log into an administrator account. > > I > > ran a script that produced a lot of output and piped it to less. I pressed > > 'q' > > after the first screen was displayed, and the displayed text didn't get > > cleared. > > Are you using non-cygwin program in the script? If so, this may happen > in test release 3.1.0-0.4 as well. 3.1.0-0.3 as well. -- Takashi Yano
Re: [PATCH v3 0/1] Cygwin: pty: Fix the behaviour of Ctrl-C in the pseudo console mode.
Hi Ken, I appreciate checking the patch. On Fri, 6 Sep 2019 17:59:02 + Ken Brown wrote: > I had several problems after applying this patch. > > 1. I noticed some display glitches when building cygwin (with -j13 if that's > relevant). For example, there were some unexpected blank lines and indented > lines. > > 2. At one point the build wouldn't complete at all. It hung and had to be > killed with Ctrl-C. I could not reproduce these with 32-bit cygwin (which I usually use), however, I noticed that they happen with 64-bit cygwin. I apologize for the lack of enough test. I will post fixed version as v4 patch. > 3. I used ssh from my normal account to log into an administrator account. I > ran a script that produced a lot of output and piped it to less. I pressed > 'q' > after the first screen was displayed, and the displayed text didn't get > cleared. Are you using non-cygwin program in the script? If so, this may happen in test release 3.1.0-0.4 as well. > P.S. I'm leaving tomorrow for a short vacation, so I might not have time to > review any more patches until I return in about a week. I see. So I have at least a week for consideration. :) -- Takashi Yano
Re: [PATCH v3 0/1] Cygwin: pty: Fix the behaviour of Ctrl-C in the pseudo console mode.
Hi Takashi, On 9/6/2019 10:51 AM, Takashi Yano wrote: > - When the I/O pipe is switched to the pseudo console side, the >behaviour of Ctrl-C is unstable. This rarely happens, however, >for example, shell sometimes crashes by Ctrl-C in that situation. >This patch fixes that issue. > > v3: > Fix mistake in v2. > > v2: > Remove the code which accidentally clears ENABLE_ECHO_INPUT flag. > > Takashi Yano (1): >Cygwin: pty: Fix the behaviour of Ctrl-C in the pseudo console mode. > > winsup/cygwin/fhandler.h | 4 +- > winsup/cygwin/fhandler_tty.cc | 33 + > winsup/cygwin/select.cc | 2 +- > winsup/cygwin/spawn.cc| 128 +- > 4 files changed, 89 insertions(+), 78 deletions(-) I had several problems after applying this patch. 1. I noticed some display glitches when building cygwin (with -j13 if that's relevant). For example, there were some unexpected blank lines and indented lines. 2. At one point the build wouldn't complete at all. It hung and had to be killed with Ctrl-C. 3. I used ssh from my normal account to log into an administrator account. I ran a script that produced a lot of output and piped it to less. I pressed 'q' after the first screen was displayed, and the displayed text didn't get cleared. Ken P.S. I'm leaving tomorrow for a short vacation, so I might not have time to review any more patches until I return in about a week.
