Re: [PATCH v3 00/10] fhandler_proc.cc(format_proc_cpuinfo): fix issues, add fields, feature flags

2019-10-07 Thread Ken Brown
On 10/7/2019 12:22 PM, Brian Inglis wrote:
> *   fix cache size return code handling and make AMD/Intel code common
> *   fix cpuid level count as number of non-zero leafs excluding sub-leafs
> *   fix AMD physical cores count documented as core_info low byte + 1
> *   round cpu MHz to correct Windows and match Linux cpuinfo
> *   add bogomips which has been cpu MHz*2 since Pentium MMX
> *   add microcode from Windows registry Update Revision REG_BINARY
> *   feature test print macro makes cpuid feature, bit, and flag text
>  comparison and checking easier;
>  handle as common former Intel only feature flags also supported on AMD;
>  change order and some flag names to agree with current Linux
> *   add 99 feature flags inc. AVX512 extensions, AES, SHA with 20 cpuid calls
> *   comment out flags not reported by Linux in cpuinfo although some flags
>  may not be used by Linux
> *   or model extension bits into high model bits instead of adding
>  arithmetically like family extension bits
> 
>   winsup/cygwin/fhandler_proc.cc | 737 +++--
>   1 file changed, 434 insertions(+), 303 deletions(-)

Series pushed, with minor tweaks to the commit messages.  (Except for the first 
line, the commit message should consist of complete sentences, starting with 
capitals and ending with periods.)

Thanks very much.

Ken


[PATCH v3 00/10] fhandler_proc.cc(format_proc_cpuinfo): fix issues, add fields, feature flags

2019-10-07 Thread Brian Inglis
*   fix cache size return code handling and make AMD/Intel code common
*   fix cpuid level count as number of non-zero leafs excluding sub-leafs
*   fix AMD physical cores count documented as core_info low byte + 1
*   round cpu MHz to correct Windows and match Linux cpuinfo
*   add bogomips which has been cpu MHz*2 since Pentium MMX
*   add microcode from Windows registry Update Revision REG_BINARY
*   feature test print macro makes cpuid feature, bit, and flag text
comparison and checking easier;
handle as common former Intel only feature flags also supported on AMD;
change order and some flag names to agree with current Linux
*   add 99 feature flags inc. AVX512 extensions, AES, SHA with 20 cpuid calls
*   comment out flags not reported by Linux in cpuinfo although some flags
may not be used by Linux
*   or model extension bits into high model bits instead of adding
arithmetically like family extension bits

 winsup/cygwin/fhandler_proc.cc | 737 +++--
 1 file changed, 434 insertions(+), 303 deletions(-)

-- 
2.21.0