RE: sem_getvalue patch
Ok, well I'll hold off for the assignment. Rob -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] On Behalf Of Robert Collins Sent: Saturday, 8 June 2002 2:44 AM To: 'Robb, Sam'; [EMAIL PROTECTED] Subject: RE: sem_getvalue patch Thanks, this looks good, I'll do a closer review in the weekend. Rob -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] On Behalf Of Robb, Sam Sent: Saturday, 8 June 2002 2:35 AM To: [EMAIL PROTECTED] Subject: RE: sem_getvalue patch [original message was to [EMAIL PROTECTED]] With a little effort, I've managed to build a cygwin1.dll that exports sem_getvalue(). The version of cygwin1.dll that I built seems subtly hosed, though - while I can compile and run my test program from within a Windows cmd.exe shell, trying to run bash or ls (and probably a great many other things) hangs. Here's the patch... fairly straightforward, if I've understood the SUS spec for the function correctly :-/ As for the apparent hangs in bash/ls/etc. - well, perhaps it was my patch, perhaps not, as I was building from latest cvs source. Since I can't find any documentation that indicates if a particular method for adding an export to cygiwn.din needs to be followed, this patch simply tacks sem_getvalue to the end of the list. Thanks, -Samrobb winsup/cygwin/ChangeLog entry: 2002-06-06 Sam Robb [EMAIL PROTECTED] * pthread.cc (sem_getvalue): New function. * thread.cc (__sem_getvalue): Diito. * thread.h (__sem_getvalue): Ditto. * include/semaphore.h (sem_getvalue): Ditto. * posix.sgml: Add sem_getvalue to Synchronization section. * cygwin.din: Add symbol for sem_getvalue(). winsup/doc/ChangeLog entry: 2002-06-06 Sam Robb [EMAIL PROTECTED] * calls.texinfo: Remove 'unimplemented' tag from sem_getvalue.
RE: sem_getvalue patch
[original message was to [EMAIL PROTECTED]] With a little effort, I've managed to build a cygwin1.dll that exports sem_getvalue(). The version of cygwin1.dll that I built seems subtly hosed, though - while I can compile and run my test program from within a Windows cmd.exe shell, trying to run bash or ls (and probably a great many other things) hangs. Here's the patch... fairly straightforward, if I've understood the SUS spec for the function correctly :-/ As for the apparent hangs in bash/ls/etc. - well, perhaps it was my patch, perhaps not, as I was building from latest cvs source. Since I can't find any documentation that indicates if a particular method for adding an export to cygiwn.din needs to be followed, this patch simply tacks sem_getvalue to the end of the list. Thanks, -Samrobb winsup/cygwin/ChangeLog entry: 2002-06-06 Sam Robb [EMAIL PROTECTED] * pthread.cc (sem_getvalue): New function. * thread.cc (__sem_getvalue): Diito. * thread.h (__sem_getvalue): Ditto. * include/semaphore.h (sem_getvalue): Ditto. * posix.sgml: Add sem_getvalue to Synchronization section. * cygwin.din: Add symbol for sem_getvalue(). winsup/doc/ChangeLog entry: 2002-06-06 Sam Robb [EMAIL PROTECTED] * calls.texinfo: Remove 'unimplemented' tag from sem_getvalue. sem_getvalue.changelog Description: sem_getvalue.changelog sem_getvalue.diff Description: sem_getvalue.diff
RE: sem_getvalue patch
Thanks, this looks good, I'll do a closer review in the weekend. Rob -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] On Behalf Of Robb, Sam Sent: Saturday, 8 June 2002 2:35 AM To: [EMAIL PROTECTED] Subject: RE: sem_getvalue patch [original message was to [EMAIL PROTECTED]] With a little effort, I've managed to build a cygwin1.dll that exports sem_getvalue(). The version of cygwin1.dll that I built seems subtly hosed, though - while I can compile and run my test program from within a Windows cmd.exe shell, trying to run bash or ls (and probably a great many other things) hangs. Here's the patch... fairly straightforward, if I've understood the SUS spec for the function correctly :-/ As for the apparent hangs in bash/ls/etc. - well, perhaps it was my patch, perhaps not, as I was building from latest cvs source. Since I can't find any documentation that indicates if a particular method for adding an export to cygiwn.din needs to be followed, this patch simply tacks sem_getvalue to the end of the list. Thanks, -Samrobb winsup/cygwin/ChangeLog entry: 2002-06-06 Sam Robb [EMAIL PROTECTED] * pthread.cc (sem_getvalue): New function. * thread.cc (__sem_getvalue): Diito. * thread.h (__sem_getvalue): Ditto. * include/semaphore.h (sem_getvalue): Ditto. * posix.sgml: Add sem_getvalue to Synchronization section. * cygwin.din: Add symbol for sem_getvalue(). winsup/doc/ChangeLog entry: 2002-06-06 Sam Robb [EMAIL PROTECTED] * calls.texinfo: Remove 'unimplemented' tag from sem_getvalue.
Re: sem_getvalue patch
On Fri, Jun 07, 2002 at 12:35:10PM -0400, Robb, Sam wrote: [original message was to [EMAIL PROTECTED]] With a little effort, I've managed to build a cygwin1.dll that exports sem_getvalue(). The version of cygwin1.dll that I built seems subtly hosed, though - while I can compile and run my test program from within a Windows cmd.exe shell, trying to run bash or ls (and probably a great many other things) hangs. Here's the patch... fairly straightforward, if I've understood the SUS spec for the function correctly :-/ As for the apparent hangs in bash/ls/etc. - well, perhaps it was my patch, perhaps not, as I was building from latest cvs source. Since I can't find any documentation that indicates if a particular method for adding an export to cygiwn.din needs to be followed, this patch simply tacks sem_getvalue to the end of the list. Btw, if you don't already have a form on file, we'll need an assignment form for this patch. See http://cygwin.com/contrib.html . cgf
RE: sem_getvalue patch
Btw, if you don't already have a form on file, we'll need an assignment form for this patch. See http://cygwin.com/contrib.html . No, I don't have one on file... I'll see about getting one to you soon. On a related note: under what circumstances does RedHat generally want/need an employer disclaimer for Cygwin contributions? -Samrobb
Re: sem_getvalue patch
On Fri, Jun 07, 2002 at 01:39:57PM -0400, Chris Faylor wrote: On Fri, Jun 07, 2002 at 01:22:17PM -0400, Robb, Sam wrote: Btw, if you don't already have a form on file, we'll need an assignment form for this patch. See http://cygwin.com/contrib.html . No, I don't have one on file... I'll see about getting one to you soon. On a related note: under what circumstances does RedHat generally want/need an employer disclaimer for Cygwin contributions? If you are employed as a programmer, most companies have you sign some kind of form saying that your work belongs to them. If the form can, in any way, be construed as covering cygwin patches then your employer needs to be involved. Or, to put it another way, if you sign a form, indicating that you own the rights to your changes, and your employer disagrees and comes after Red Hat for the changes, guess who's going to be in hot water? As a side note, if the law in your country strictly differs between your activity in your spare time and the activity in your work time, then you don't need an employers assignment if you're only working on Cygwin in your spare time. This is e. g. valid if you're living in Germany (guess why I know that ;-)) Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.
RE: sem_getvalue patch
Thanks all for the advice... I just got out of a meeting where I requested a disclaimer for Cygwin contributions, figuring that in this case, it was better to ask permission than to beg forgiveness. It may take a while, though. -Samrobb -Original Message- From: Christopher Faylor [mailto:[EMAIL PROTECTED]] Sent: Friday, June 07, 2002 1:40 PM To: [EMAIL PROTECTED] Subject: Re: sem_getvalue patch On Fri, Jun 07, 2002 at 01:22:17PM -0400, Robb, Sam wrote: Btw, if you don't already have a form on file, we'll need an assignment form for this patch. See http://cygwin.com/contrib.html . No, I don't have one on file... I'll see about getting one to you soon. On a related note: under what circumstances does RedHat generally want/need an employer disclaimer for Cygwin contributions? If you are employed as a programmer, most companies have you sign some kind of form saying that your work belongs to them. If the form can, in any way, be construed as covering cygwin patches then your employer needs to be involved. Or, to put it another way, if you sign a form, indicating that you own the rights to your changes, and your employer disagrees and comes after Red Hat for the changes, guess who's going to be in hot water? cgf
