Re: [PATCH v2] Cygwin: rmdir: fail if last component is a symlink, as on Linux

2019-09-24 Thread Eric Blake
On 9/24/19 2:28 PM, Ken Brown wrote: >> >> Looks okay to me. > > Thanks. Does the "intentionally ignoring POSIX" part apply to rmdir also? I > didn't find it easy to decipher POSIX. > > Even for mkdir, POSIX says, "If path names a symbolic link, mkdir() shall > fail > and set errno to

Re: [PATCH v2] Cygwin: rmdir: fail if last component is a symlink, as on Linux

2019-09-24 Thread Ken Brown
On 9/24/2019 2:27 PM, Eric Blake wrote: > On 9/24/19 12:55 PM, Ken Brown wrote: >> If the last component of the directory name is a symlink followed by a >> slash, rmdir should fail, even if the symlink resolves to an existing >> empty directory. >> >> mkdir was similarly fixed in 2009 in commit

Re: [PATCH v2] Cygwin: rmdir: fail if last component is a symlink, as on Linux

2019-09-24 Thread Eric Blake
On 9/24/19 12:55 PM, Ken Brown wrote: > If the last component of the directory name is a symlink followed by a > slash, rmdir should fail, even if the symlink resolves to an existing > empty directory. > > mkdir was similarly fixed in 2009 in commit > 52dba6a5c45e8d8ba1e237a15213311dc11d91fb.