Re: XWin 4.3.0-50 crashes with -multiwindow (ping Earle)

2004-03-26 Thread Harold L Hunt II
Earle, Earle F. Philhower III wrote: Howdy Harold, At 12:00 AM 3/26/2004 -0500, Harold wrote: Nope, not going to beat you to it. This issue is what I was referring to when I said that Earle should probably look at the PixmapBytePad patch to make sure it was complete. :) There's a saying

Re: XWin 4.3.0-50 crashes with -multiwindow (ping Earle)

2004-03-25 Thread fabrizio . ge
Thanks for the good debug Fabrizio! You're welcome! The 24bpp icon handling was something I never could test: I couldn't find any apps that had 24bpp icons, all I found were 1- 15-, 16-, or 32-bit ones. I was assuming the X server always used a packed format, but PixmapBytePad() looks to be the

RE: XWin 4.3.0-50 crashes with -multiwindow (ping Earle)

2004-03-25 Thread Phil Betts
Hi All, It seems that this may have been resolved already, but FWIW... Earle F. Philhower III wrote: To fix it we can reinstate the if()... if (pixmap-drawable.bitsPerPixel == 15) effXBPP = 16; else effXBPP = pixmap-drawable.bitsPerPixel; if (pixmap-drawable.depth

Re: XWin 4.3.0-50 crashes with -multiwindow (ping Earle)

2004-03-25 Thread Earle F. Philhower III
Howdy Fabrizio, At 09:34 AM 3/25/2004 +0100, you wrote: I tried version 4.3.0-60 and it worked without crashing in 24bpp mode. There is a minor glitch left: in 24bpp mode, the icon at the upper left corner has wrong colours, while the colours are right in 16bpp mode. I'm sending you PNG files to

Re: XWin 4.3.0-50 crashes with -multiwindow (ping Earle)

2004-03-25 Thread Harold L Hunt II
Earle, Earle F. Philhower III wrote: Howdy Fabrizio, At 09:34 AM 3/25/2004 +0100, you wrote: I tried version 4.3.0-60 and it worked without crashing in 24bpp mode. There is a minor glitch left: in 24bpp mode, the icon at the upper left corner has wrong colours, while the colours are right in

Re: XWin 4.3.0-50 crashes with -multiwindow (ping Earle)

2004-03-25 Thread Earle F. Philhower III
Howdy Harold, At 12:00 AM 3/26/2004 -0500, Harold wrote: Nope, not going to beat you to it. This issue is what I was referring to when I said that Earle should probably look at the PixmapBytePad patch to make sure it was complete. :) There's a saying I've learned from my verification

Re: XWin 4.3.0-50 crashes with -multiwindow (ping Earle)

2004-03-24 Thread Rob Foehl
On Tue, 23 Mar 2004, Harold L Hunt II wrote: Fabrizio, It looks like your conclusions are correct. I have included your suggested change in XFree86-xserv-4.3.0-60. Please test this on a 24 bit depth system. It seems to work okay on 32 bit depth systems. I tested this with the Oracle

Re: XWin 4.3.0-50 crashes with -multiwindow (ping Earle)

2004-03-24 Thread Harold L Hunt II
Rob, Thanks for the test. I was hoping that this fix would resolve most of the weird crashing problems we have been having. Harold Rob Foehl wrote: On Tue, 23 Mar 2004, Harold L Hunt II wrote: Fabrizio, It looks like your conclusions are correct. I have included your suggested change in

Re: XWin 4.3.0-50 crashes with -multiwindow (ping Earle)

2004-03-23 Thread Earle F. Philhower III
Howdy Fabrizio, Harold. Thanks for the good debug Fabrizio! The 24bpp icon handling was something I never could test: I couldn't find any apps that had 24bpp icons, all I found were 1- 15-, 16-, or 32-bit ones. I was assuming the X server always used a packed format, but PixmapBytePad() looks to

Re: XWin 4.3.0-50 crashes with -multiwindow (ping Earle)

2004-03-23 Thread Harold L Hunt II
Earle, Earle F. Philhower III wrote: Howdy Fabrizio, Harold. Thanks for the good debug Fabrizio! The 24bpp icon handling was something I never could test: I couldn't find any apps that had 24bpp icons, all I found were 1- 15-, 16-, or 32-bit ones. I was assuming the X server always used a

Re: XWin 4.3.0-50 crashes with -multiwindow (ping Earle)

2004-03-23 Thread Earle F. Philhower III
Howdy Harold... At 10:17 PM 3/23/2004 -0500, you wrote: Upon closer inspection I think you'll see that the logic of the statements is unchanged. I was working on adding an additional case for 24-bpp and reworked the if/else pairs to more a set default/override default it needed structure.