RE: [ANNOUNCEMENT] Server Test 91

2003-06-05 Thread Ralf Habacker
Harold, after submitting this patch I recognized a rare case memory leak in winMultiWindowGetClassHint() if the memory allocation for res_class fails. This is fixed by the appended small patch, which is based on the previous one. (Hope the indention is right) Ralf

RE: [ANNOUNCEMENT] Server Test 91

2003-06-05 Thread Earle F. Philhower III
Hi Ralf, let me just say thanks for doing all the boring work of parameter checking and NULL malloc fixes. Hacking code's fun, making it bulletproof is just work... At 08:02 PM 6/4/2003 +0200, you wrote: after submitting this patch I recognized a rare case memory leak in

RE: [ANNOUNCEMENT] Server Test 91

2003-06-04 Thread Ralf Habacker
Harold Hunt wrote: 5) winclass.c, winclass.h - Rename these files to winmultiwindowclass.c and winmultiwindowclass.h, respectively, since they are only used in MultiWindow mode. Prefix the functions in these files with MultiWindow. (Harold L Hunt II) The appended patch contains some

Re: [ANNOUNCEMENT] Server Test 91

2003-06-03 Thread Earle F. Philhower, III
Hi Harold, One more thing about your new server test release where you broke things up into smaller files and reworked the message loops: It looks like the mouse button fix (where you release the mouse outside of a window and X doesn't get notification so Xterm keeps scrolling or emacs keeps

Re: [ANNOUNCEMENT] Server Test 91

2003-06-03 Thread Harold L Hunt II
I didn't commit that because I was not convinced that it was entirely proper. I also forgot about it :) I would really like to implement hooks instead of adding more and more timers (it was a timer, correct?). Harold Earle F. Philhower, III wrote: Hi Harold, One more thing about your new

Re: [ANNOUNCEMENT] Server Test 91

2003-06-03 Thread Earle F. Philhower III
Howdy, At 09:32 PM 6/2/2003 -0400, you wrote: I didn't commit that because I was not convinced that it was entirely proper. I also forgot about it :) I would really like to implement hooks instead of adding more and more timers (it was a timer, correct?). It wasn't a new timer, it was just

Re: [ANNOUNCEMENT] Server Test 91

2003-06-03 Thread Harold L Hunt II
I think the thing I didn't like about it was the fact that a few keys were also being released and that wasn't explained very well. What is up with that? Harold Earle F. Philhower III wrote: Howdy, At 09:32 PM 6/2/2003 -0400, you wrote: I didn't commit that because I was not convinced that

Re: [ANNOUNCEMENT] Server Test 91

2003-06-03 Thread Earle F. Philhower III
Hola, At 09:43 PM 6/2/2003 -0400, you wrote: I think the thing I didn't like about it was the fact that a few keys were also being released and that wasn't explained very well. What is up with that? ?? That's actually the WM_KILLFOCUS call that releases the keys. I think you've still got that