Re: setup 2.887 release candidate - please test
On 07/02/2018 11:51, Jon Turney wrote: On 07/02/2018 11:38, David Balažic wrote: On 7 February 2018 at 01:49, Steven Penny wrote: On Tue, 6 Feb 2018 15:04:49, Jon Turney wrote: - 'Current' is replaced by 'Best' (which is slightly different in ways it's difficult to summarize briefly) and 'Sync' (which exposes the --force-current (distupgrade) option through the UI). i get the desire for one word labels - but im not sure how good "sync" is. its not clear in the GUI what it does, and frankly, even reading your description doesnt clear up for me what it does. i guess i would need to run "--help" and see what "--force-current" does to figure it out. that just seems like more work than it should be. This could be improved by having a tooltip on the GUI item, explaining in a sentence or two, what it does. There already is a tooltip: "Sets all packages to the version available from the package respository, downgrading if necessary." For the record, the changes in 2.888 are to fix a typo in this tooltip, and to avoid a crash when installing a source package. -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: setup 2.887 release candidate - please test
On 14/02/2018 23:02, Ken Brown wrote: On 2/6/2018 10:04 AM, Jon Turney wrote: A new setup release candidate is available at: https://cygwin.com/setup/setup-2.887.x86_64.exe (64 bit version) https://cygwin.com/setup/setup-2.887.x86.exe (32 bit version) Please test and report any problems here. This crashes in ConfirmPage::OnActivate() if a source package is being installed. The problem is that 'pkg' is null, but it is dereferenced in confirm.cc:99. The attached patch fixes this in the laziest possible way, but I'm not sure it's the best fix. Maybe we should check whether 'pkg' is NULL (both times it's defined) and throw an exception if so unless we're installing a source package. Alternatively, maybe we should just make sure it's non-NULL (both times) before dereferencing it. After all, we're only using 'pkg' to decide whether to say "automatically added", so if it's NULL, it might not be worth worrying about why. Thanks. I also came across this, but you beat me to sending a patch :)
Re: setup 2.887 release candidate - please test
On 2/6/2018 10:04 AM, Jon Turney wrote: A new setup release candidate is available at: https://cygwin.com/setup/setup-2.887.x86_64.exe (64 bit version) https://cygwin.com/setup/setup-2.887.x86.exe (32 bit version) Please test and report any problems here. This crashes in ConfirmPage::OnActivate() if a source package is being installed. The problem is that 'pkg' is null, but it is dereferenced in confirm.cc:99. The attached patch fixes this in the laziest possible way, but I'm not sure it's the best fix. Maybe we should check whether 'pkg' is NULL (both times it's defined) and throw an exception if so unless we're installing a source package. Alternatively, maybe we should just make sure it's non-NULL (both times) before dereferencing it. After all, we're only using 'pkg' to decide whether to say "automatically added", so if it's NULL, it might not be worth worrying about why. Ken From c860c1ce6045d6c42f0207f5977a269cbf48c53e Mon Sep 17 00:00:00 2001 From: Ken BrownDate: Wed, 14 Feb 2018 17:48:44 -0500 Subject: [PATCH] Avoid crash if a source package is installed If a source package is installed, setup crashed in ConfirmPage::OnActivate() when a null pointer 'pkg' was dereferenced. Check that it is non-NULL before dereferencing. --- confirm.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/confirm.cc b/confirm.cc index 7e949d8..df9b4f9 100644 --- a/confirm.cc +++ b/confirm.cc @@ -96,7 +96,7 @@ ConfirmPage::OnActivate() s += i->version.Name(); s += " "; s += i->version.Canonical_version(); -if (!pkg->desired) +if (pkg && !pkg->desired) s += " (automatically added)"; s += "\r\n"; } -- 2.16.1
Re: setup 2.887 release candidate - please test
On 08/02/2018 15:01, Eric Blake wrote: On 02/08/2018 12:44 AM, Marco Atzeri wrote: The current "-h" output is missing a header with a description of program name an version. $ ./setup-2.887.x86.exe --help |head Generally, if you want to learn the version, you should use --version, rather than --help. (Some programs also output the version in --help, but GNU Coding Standards don't require that, so it is not universal the way --version should be) as `--version` is not provided at all, than your proposal is a request of new feature ;-) Nice to have anyway, and the same output should be the reused as early line of `--help` that is currently very anonymous... Regards Marco -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: setup 2.887 release candidate - please test
On 02/08/2018 12:44 AM, Marco Atzeri wrote: The current "-h" output is missing a header with a description of program name an version. $ ./setup-2.887.x86.exe --help |head Generally, if you want to learn the version, you should use --version, rather than --help. (Some programs also output the version in --help, but GNU Coding Standards don't require that, so it is not universal the way --version should be) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: setup 2.887 release candidate - please test
On 06/02/2018 16:04, Jon Turney wrote: A new setup release candidate is available at: https://cygwin.com/setup/setup-2.887.x86_64.exe (64 bit version) https://cygwin.com/setup/setup-2.887.x86.exe (32 bit version) Please test and report any problems here. This is not the place for setup feature requests. Not a feature ;-) The current "-h" output is missing a header with a description of program name an version. $ ./setup-2.887.x86.exe --help |head Command Line Options: --allow-unsupported-windowsAllow old, unsupported Windows versions -a --arch Architecture to install (x86_64 or x86) -C --categories Specify entire categories to install -o --delete-orphans Remove orphaned packages -A --disable-buggy-antivirus Disable known or suspected buggy anti virus software packages during execution. -D --download Download packages from internet only something like $ bash --help GNU bash, version 4.4.12(3)-release-(x86_64-unknown-cygwin) ... -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: setup 2.887 release candidate - please test
On Tue, 6 Feb 2018 15:04:49, Jon Turney wrote: Uses the libsolv dependency solver, rather than a home-made one. a result of this is that packages on the "Review and confirm changes" page are no longer alphabetized please resolve this - thanks -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: setup 2.887 release candidate - please test
On 07/02/2018 11:38, David Balažic wrote: On 7 February 2018 at 01:49, Steven Penny wrote: On Tue, 6 Feb 2018 15:04:49, Jon Turney wrote: - 'Current' is replaced by 'Best' (which is slightly different in ways it's difficult to summarize briefly) and 'Sync' (which exposes the --force-current (distupgrade) option through the UI). i get the desire for one word labels - but im not sure how good "sync" is. its not clear in the GUI what it does, and frankly, even reading your description doesnt clear up for me what it does. i guess i would need to run "--help" and see what "--force-current" does to figure it out. that just seems like more work than it should be. This could be improved by having a tooltip on the GUI item, explaining in a sentence or two, what it does. There already is a tooltip: "Sets all packages to the version available from the package respository, downgrading if necessary." -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: setup 2.887 release candidate - please test
On 7 February 2018 at 01:49, Steven Pennywrote: > On Tue, 6 Feb 2018 15:04:49, Jon Turney wrote: > >> - Query the user for action to take if a corrupt local file is found >> > > works great - thanks > > - 'Current' is replaced by 'Best' (which is slightly different in ways >> it's difficult to summarize briefly) and 'Sync' (which exposes the >> --force-current (distupgrade) option through the UI). >> > > i get the desire for one word labels - but im not sure how good "sync" is. > its > not clear in the GUI what it does, and frankly, even reading your > description > doesnt clear up for me what it does. i guess i would need to run "--help" > and > see what "--force-current" does to figure it out. that just seems like > more work > than it should be. > > This could be improved by having a tooltip on the GUI item, explaining in a sentence or two, what it does. Regards, David -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Re: setup 2.887 release candidate - please test
On Tue, 6 Feb 2018 15:04:49, Jon Turney wrote: - Query the user for action to take if a corrupt local file is found works great - thanks - 'Current' is replaced by 'Best' (which is slightly different in ways it's difficult to summarize briefly) and 'Sync' (which exposes the --force-current (distupgrade) option through the UI). i get the desire for one word labels - but im not sure how good "sync" is. its not clear in the GUI what it does, and frankly, even reading your description doesnt clear up for me what it does. i guess i would need to run "--help" and see what "--force-current" does to figure it out. that just seems like more work than it should be. another long time nitpick i have had - to choose between the different package versions you simply click the version - however i have never liked this because it loops through the different versions. so if you forgot the first version you looked at then you end up looping repeatedly. i think a drop down with the different version numbers would be better - as you could see all versions at once and choose what you like i understand my suggest will prob be ignored as i do not have a patch - but i wanted to put it out there - thanks again -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple