Re: deleted DELETE

2007-08-30 Thread David Carter
On Wed, 29 Aug 2007, Ken Murchison wrote: Small bug fix (the p++ line) attached. Good catch. I didn't look at the cyr_expire patch real close, since I assumed Fastmail was using it in production. I know, I know, I shouldn't assume anything and test it myself. Mea culpa. Well, if Bron

Re: deleted DELETE

2007-08-30 Thread David Carter
On Wed, 29 Aug 2007, David Carter wrote: mboxname_isusermailbox() works on internal mailbox names. I don't think that it needs to worry about IMAPOPT_UNIXHIERARCHYSEP. Here's a trivial patch to remove the IMAPOPT_UNIXHIERARCHYSEP stuff. Otherwise mboxname_isusermailbox() is broken when

Re: Need advice: mailbox-based \Seen flag

2007-08-30 Thread Ken Murchison
Ken Murchison wrote: Boris Lytochkin wrote: Hello! I need an advice in implementing per-mailbox \Seen flag (or 'shared' \Seen flag in per-user basis). For now I want to implement it this way: 1) add a new mailbox attribute, say 'sharedseen' 2) switch path for .seen file in

Re: Need advice: mailbox-based \Seen flag

2007-08-30 Thread Rob Mueller
I actually went digging into seen state and cyrus.index a little today for another reason, and I realized that we wouldn't have to expand/upgrade the index file to accomodate a shared seen state. The existing field for system flags is just a bitmask, so we could easily add a bit for shared

Re: Need advice: mailbox-based \Seen flag

2007-08-30 Thread Ken Murchison
Rob Mueller wrote: I actually went digging into seen state and cyrus.index a little today for another reason, and I realized that we wouldn't have to expand/upgrade the index file to accomodate a shared seen state. The existing field for system flags is just a bitmask, so we could easily

Re: Need advice: mailbox-based \Seen flag

2007-08-30 Thread Ken Murchison
Boris Lytochkin wrote: My quick thoughts would be the following: - Add a 'sharedseen' mailbox attribute as you suggest (as a mailbox annotation) - When a mailbox is opened that has this annotation enabled, we open the seen state database for the special 'anyone' user instead of the