Four patches against 2.3.14

2009-03-27 Thread David Carter
http://www-uxsup.csx.cam.ac.uk/~dpc22/cyrus/patches/2.3.14 autoconf.patch == Stop aclocal moaning about invalid header names. Was surprised that Linux wasn't moaning about the same thing. SunFreeware provides autoconf 2.63, which is more recent than the 2.59 shipped with SLES10.

Re: ipurge evolution

2009-03-27 Thread Cyril Servant
Hello, Le vendredi 27 mars 2009 à 03:09 +0100, Wesley Craig a écrit : Could you enter this in Bugzilla as a feature request, please? Also, a unified diff would be preferable. Yes, it's done. :wes On 26 Mar 2009, at 06:38, Cyril Servant wrote: Here is the patch for ipurge.c 2.3.14 :

Re: Four patches against 2.3.14

2009-03-27 Thread Bron Gondwana
On Fri, Mar 27, 2009 at 10:07:29AM +, David Carter wrote: ctype.patch === Mostly automatic using find and sed, but I did go back and remove casts to (unsigned char) [correct but redundant], and (int) [typically incorrect if the source is signed char, probably put there to stop

Re: Four patches against 2.3.14

2009-03-27 Thread David Carter
On Fri, 27 Mar 2009, Bron Gondwana wrote: Why did this touch sieve.h? It's generated by bison. Did you not work on a clean tree? 2.3.14 ships with a sieve/sieve.h I did remove a number of the .c files which are generated from Bison or Flex, but missed this one. -- David Carter

Re: Four patches against 2.3.14

2009-03-27 Thread Bron Gondwana
On Fri, Mar 27, 2009 at 10:07:29AM +, David Carter wrote: robust_squatter.patch = Don't give up if index_me() throws an error. Not wildly happy about mboxlist_findall which can run for several days in any case. l-tail = l-tail-next = n; Is that _guaranteed_ to

Re: Four patches against 2.3.14

2009-03-27 Thread Bron Gondwana
On Fri, Mar 27, 2009 at 10:07:29AM +, David Carter wrote: http://www-uxsup.csx.cam.ac.uk/~dpc22/cyrus/patches/2.3.14 Ok - I've loaded all 4 of these patches on top of my 'master' tree on github and called the branch 'davidcarter', then rebased the fastmaildev branch on top of it. That means

Re: Four patches against 2.3.14

2009-03-27 Thread Bron Gondwana
On Fri, Mar 27, 2009 at 11:38:15AM +, David Carter wrote: On Fri, 27 Mar 2009, Bron Gondwana wrote: Why did this touch sieve.h? It's generated by bison. Did you not work on a clean tree? 2.3.14 ships with a sieve/sieve.h I did remove a number of the .c files which are generated from

Re: Four patches against 2.3.14

2009-03-27 Thread David Carter
On Fri, 27 Mar 2009, Bron Gondwana wrote: l-tail = l-tail-next = n; Is that _guaranteed_ to evaluate correctly? It looks like someone being a smartarse to avoid writing: l-tail-next = n; l-tail = l-tail-next; It's a fairly common idiom for managing linked lists in C. Or at least I thought

Re: Four patches against 2.3.14

2009-03-27 Thread Bron Gondwana
On Fri, Mar 27, 2009 at 12:25:38PM +, David Carter wrote: '=' has right to left associativity (KR second edition, page 53), so: a = b = c evaluates as: a = (b = c) But if you are happier with two or three lines of code, then go for it. Yeah, I think it's clearer that it's two

Re: Last call for Cyrus 2.3.14

2009-03-27 Thread Thomas Jarosch
On Tuesday, 24. March 2009 18:21:39 Wesley Craig wrote: On 24 Mar 2009, at 06:47, Thomas Jarosch wrote: Thanks for calling. I don't like to spoil the party, what about the issue which allows to create empty ACLs? I seem to have forgotten to open a bug report, what do you think is the

Re: Four patches against 2.3.14

2009-03-27 Thread Bron Gondwana
On Fri, Mar 27, 2009 at 04:12:41PM +, David Carter wrote: On Sat, 28 Mar 2009, Bron Gondwana wrote: Speaking of smartarse - you forgot to include util.h in sieve/test.c. It's not part of the standard build, so easy not to notice - but our install script builds it, so I noticed when I