Re: Automake Support for cyrus-imapd 2.5

2012-04-16 Thread Greg Banks
G'day, On Sun, Apr 15, 2012, at 01:31 AM, Дилян Палаузов wrote: Hello, at git://demo.aegee.org:143/cyrus-imapd.git , branch dpa/automake I have patched cyrus-imapd/master to support Automake . Some reviews follow. commit rename configure.in to configure.ac Looks good, but there's

Re: Automake Support for cyrus-imapd 2.5

2012-04-16 Thread Дилян Палаузов
Hello, commit imap/Makefile.in: add .c.snmp: recipe The old makefile will rebuild pushstats.c if the snmpgen script changes. The new one won't. Please feel entitled to fix it. commit lib/mkchartable.pl move output from stderr to stdout In mkchartable.pl, you need to handle the open()

Build failed in Jenkins: cyrus-imapd-master #518

2012-04-16 Thread Jenkins
See http://ci.cyrusimap.org/job/cyrus-imapd-master/518/changes Changes: [vanmeeuwen] Add --with-ldap=/usr switch to autobuild.sh -- [...truncated 1910 lines...] sync_reset.c gcc -L4.8/lib -Wl,-rpath,4.8/lib --coverage -o \ sync_reset

Re: Automake Support for cyrus-imapd 2.5

2012-04-16 Thread Greg Banks
On Mon, Apr 16, 2012, at 04:44 PM, Greg Banks wrote: Have to go now, more later. commit */Makefile.in: add top_builddir Looks good. commit */Makefile.in: insert $(top_builddir) in all DEPLIBS Looks good commit */Makefile.in: add top_(builddir,srcdir) to CPPFLAGS +CPPFLAGS =

Quota and Sievescripts

2012-04-16 Thread Michael Menge
Hi all, some time ago I added an enhencement request to only return IMAP_QUOTA_EXCEEDED if needed https://bugzilla.cyrusimap.org/show_bug.cgi?id=3057 The request was postponed past 2.4. As the releas of 2.5 is in near future I wanted to ask if this patch is considerd for 2.5? Is there anything

Re: Automake Support for cyrus-imapd 2.5

2012-04-16 Thread Дилян Палаузов
Hello, My comments on Greg's 2nd comments on my comments on my commits: commit */Makefile.in: add top_(builddir,srcdir) to CPPFLAGS +CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib -I$(top_builddir) -I$(top_builddir)/lib @COM_ERR_CPPFLAGS@ @CPPFLAGS@ @SASLFLAGS@ Surely the correct order is