Hello,
some time ago I implemented RFC 6131 http://tools.ietf.org/html/rfc6131,
which adds a variante of the VACATION extension supporting seconds instead of
days. The original patch was for version 2.2.x and implemented a draft version.
There are some issues I would like to get a feedback for:
In preparation for draft-ietf-sieve-vacation-sconds.txt change the
vacation time from days to seconds.
Signed-off-by: Philipp Hahn h...@univention.de
---
imap/lmtp_sieve.c |6 +++---
sieve/bc_dump.c |2 +-
sieve/bc_emit.c |4 ++--
sieve/bc_generate.c |4
If ../inst/ or ../cassandane/ don't exists, running autobuild.sh fails
because it tries to rename the current working directory containing the
source tree.
Only print the directory name if the previous change-directory
succeeded.
Only install when ../inst/ exists.
Only run caddandane if the
Add support for specifying the vacation time in seconds in addition to
days.
Signed-off-by: Philipp Hahn h...@univention.de
---
sieve/README |3 +++
sieve/script.c | 11 +++
sieve/script.h
On Tue, May 8, 2012, at 11:54 AM, Philipp Hahn wrote:
For converting days to seconds and the inverse I always explicitly wrote 24 *
60 * 60. Is there a good location for defining this as a macro?
lib/util.h ?
Philipp Hahn (4):
autobuild: Fix directory handling
Change vacation day to
Sent from my iPhone
On 08/05/2012, at 18:44, Philipp Hahn h...@univention.de wrote:
If ../inst/ or ../cassandane/ don't exists, running autobuild.sh fails
because it tries to rename the current working directory containing
the
source tree.
Autobuild.sh isn't for you to use, it's for the
Hello,
To patch 1: autobuild: Fix directory handling
Why do you use autobuild.sh instead of autoreconf -vi?
To patch 2,3,4: Change vacation day to seconds
I would suggest adding a new opcode to the sieve bytecode for
vacation :seconds, that is used for all uploads in the future, in a
way
Post scriptum:
Also sieve/interp.c:sieve_listextensions(sieve_interp_t *i) has to be
fixed, so that it includes vacation-seconds in its return value. The
result of sieve_listextensions, including vacation-seconds, is printed
by timsieved's CAPABILITY command.
Extending
Hello,
Am Dienstag 08 Mai 2012 13:07:04 schrieb Bron Gondwana:
On Tue, May 8, 2012, at 11:54 AM, Philipp Hahn wrote:
For converting days to seconds and the inverse I always explicitly wrote
24 * 60 * 60. Is there a good location for defining this as a macro?
lib/util.h ?
Will take a look.
Hello,
Am Dienstag 08 Mai 2012 13:32:56 schrieb Дилян Палаузов:
Hello,
To patch 1: autobuild: Fix directory handling
Why do you use autobuild.sh instead of autoreconf -vi?
autobuild had just the right name and did what I was looking for - until it
renamed $PWD to $PWD.orig :-(
To patch
On Tue, May 8, 2012, at 01:50 PM, Philipp Hahn wrote:
Hello,
Am Dienstag 08 Mai 2012 13:07:04 schrieb Bron Gondwana:
On Tue, May 8, 2012, at 11:54 AM, Philipp Hahn wrote:
For converting days to seconds and the inverse I always explicitly wrote
24 * 60 * 60. Is there a good location
On Tue, May 8, 2012, at 01:52 PM, Philipp Hahn wrote:
Hello,
Am Dienstag 08 Mai 2012 13:32:56 schrieb Дилян Палаузов:
Hello,
To patch 1: autobuild: Fix directory handling
Why do you use autobuild.sh instead of autoreconf -vi?
autobuild had just the right name and did what I was
Hello,
The idea at the end is to create the tarballs with make dist,
which includes Makefile.in, config.h.in and configure, so that
autoreconf does not have to be run by the ones downloading the
tarball (and it does not matter, if git manages those files).
Apart from including the hand-written
Sorry, I should have reviewed all this a while ago too!
On Tue, Apr 17, 2012 at 10:50:08PM +0200, Дилян Палаузов wrote:
commit Makefile.am: merge sieve/Makefile.in
+ sieve/test/testExtension
Not only is this line far too long, but the directory is sieve/tests/
not sieve/test/
On Tue, May 08, 2012 at 11:44:49PM +0200, Dilyan Palauzov wrote:
That's so unmaintainable it's not funny.
What's the plan here?
One possibility is to split this on many, many, many lines. The
other possibility is to replace thе long line with
EXTRA_DIST = \
sieve/addr.h
On Tue, May 8, 2012, at 01:55 PM, Bron Gondwana wrote:
On Tue, May 8, 2012, at 01:52 PM, Philipp Hahn wrote:
autobuild had just the right name and did what I was looking for - until it
renamed $PWD to $PWD.orig :-(
gnb - looks like an attractive nuisance.
Yeah - naming is hard :(
On Tue, May 8, 2012, at 01:52 PM, Bron Gondwana wrote:
On Tue, May 8, 2012, at 01:50 PM, Philipp Hahn wrote:
Hello,
Am Dienstag 08 Mai 2012 13:07:04 schrieb Bron Gondwana:
On Tue, May 8, 2012, at 11:54 AM, Philipp Hahn wrote:
For converting days to seconds and the inverse I
17 matches
Mail list logo
