Re: Patch for adding tls_honor_cipher_order

2014-10-17 Thread Jeroen van Meeuwen (Kolab Systems)
On 2014-10-16 19:32, Kristian Kræmmer Nielsen wrote: Hi, Patch attached. Something similar is already in cyrus-imapd-2.4: http://git.cyrusimap.org/cyrus-imapd/commit/?h=cyrus-imapd-2.4id=4b26d2d7244eeaa481871c337e57cd393fd76dfe For master / 2.5, I have a push pending of a similar

Re: Patch for adding tls_honor_cipher_order

2014-10-17 Thread Kristian Kræmmer Nielsen
Hi, already - I see you just added it ;-) But really great Jeroen for implementing these - thanks. Just a few comments - I see you also added tls_compression - maybe you should consider also actually implementing it? ;-) Also I would recommend logging a failure if a wrong tls_eccurve is

Patch for adding tls_honor_cipher_order

2014-10-16 Thread Kristian Kræmmer Nielsen
Hi, Patch attached. While at it we might as well also let the user set tls_honor_cipher_order if they want to so that the order of cipher specified using tls_cipher_list is honored. By default false, so changes nothing. For expert uses might give clients a bit of extra performance by

Re: Patch for adding tls_honor_cipher_order

2014-10-16 Thread Bron Gondwana
So my plan is to merge this with Ken while we're at CMU next week, and also patch 2.4 and 2.3 and do releases of them. I agree that we should do it. Bron. On Thu, Oct 16, 2014, at 01:32 PM, Kristian Kræmmer Nielsen wrote: Hi, Patch attached. While at it we might as well also let the