Re: A couple of goodies

2007-07-24 Thread Bron Gondwana
On Tue, Jul 24, 2007 at 09:45:18AM +0100, David Carter wrote: On Tue, 24 Jul 2007, Bron Gondwana wrote: Oh, one more bug too (I haven't fixed this yet - probably tomorrow) is that the admin user can no longer delete user mailboxes. Not sure why yet, I've just read the cron messages

Re: A couple of goodies

2007-07-24 Thread Bron Gondwana
On Tue, 24 Jul 2007 23:40:18 +1000, Bron Gondwana [EMAIL PROTECTED] said: On Tue, Jul 24, 2007 at 09:45:18AM +0100, David Carter wrote: On Tue, 24 Jul 2007, Bron Gondwana wrote: Oh, one more bug too (I haven't fixed this yet - probably tomorrow) is that the admin user can no longer

Re: deleted DELETE

2007-08-29 Thread Bron Gondwana
On Tue, Aug 28, 2007 at 02:47:59PM -0400, Ken Murchison wrote: I just committed Bron's modified version of David's delayed delete patch, with a few small mods of my own. The only externally visible change is I renamed deleteprefix to deletedprefix. I also removed/modified some of the

Re: deleted DELETE

2007-08-29 Thread Bron Gondwana
right in basic testing. Bron. -- Bron Gondwana [EMAIL PROTECTED]

Re: *IMPORTANT* - bugfix sync_append_commit index breakage

2007-09-01 Thread Bron Gondwana
for expunged messages until they're expired, because you could then just do a double-iterator over the two index format files. I don't think that any of the code does the .NEW for appends because that makes append O(N) where N is the mailbox size, and that would suck for huge mailboxes. Bron. -- Bron

Re: Patch for 2.3.9 mod time bug

2007-09-02 Thread Bron Gondwana
On Sun, Sep 02, 2007 at 09:51:09PM +0200, Michael Glad wrote: I also observe the 2.3.8/9 problem with sync_server not properly setting the mtime of sync'ed messages. The problem seems to be that the sync_message_fsync routine writes (flushes) to the message file after the utime call.

cyr_expire -p prefix, don't segfault on damaged cache

2007-09-02 Thread Bron Gondwana
As I mentioned earlier on the train... the patch I wrote last night to avoid segfaults when cyr_expire hit broken cyrus.cache files. We had maybe 30 of them spread amongst our machines, and each one would cause a segfault in cyr_expire. Unfortunately, there wasn't enough information being logged

Re: *IMPORTANT* - bugfix sync_append_commit index breakage

2007-09-02 Thread Bron Gondwana
On Sun, Sep 02, 2007 at 01:33:11PM +1000, Rob Mueller wrote: I believe so. If we also used it for appends, we wouldn't run into the problem that Fastmail is seeing. But, it may be too much of a performance hit. I don't think that any of the code does the .NEW for appends because that

Re: *IMPORTANT* - bugfix sync_append_commit index breakage

2007-09-02 Thread Bron Gondwana
On Sat, Sep 01, 2007 at 11:48:51PM -0400, Ken Murchison wrote: Bron Gondwana wrote: Sorted by UUID would help enormously for things like not blatting the \Seen state for expunged messages until they're expired, because you could then just do a double-iterator over the two index format files

replication is unable to fix uidvalidity difference

2007-09-03 Thread Bron Gondwana
Our checkreplication script has managed to find uidvalidity differences between a couple of folders. I'm not sure how they crept in, probably other bugs causing reconstructs with missing index files or something. Anyway... Reading the sync_client protocol, I notice that do_mailbox_single

Re: replication is unable to fix uidvalidity difference

2007-09-03 Thread Bron Gondwana
On Mon, 3 Sep 2007 10:07:36 +0100 (BST), David Carter [EMAIL PROTECTED] said: On Mon, 3 Sep 2007, Bron Gondwana wrote: Our checkreplication script has managed to find uidvalidity differences between a couple of folders. I'm not sure how they crept in, probably other bugs causing

Re: replication is unable to fix uidvalidity difference

2007-09-03 Thread Bron Gondwana
On Mon, 3 Sep 2007 10:24:43 +0100 (BST), David Carter [EMAIL PROTECTED] said: On Mon, 3 Sep 2007, Bron Gondwana wrote: My reading was a reconstruct without cyrus.index. If you reconstruct without a header it will get a new UniqueID, but if you reconstruct without an index it doesn't

Re: Cyrus patches, cyrus patches. Get yer Cyrus patches here

2007-09-11 Thread Bron Gondwana
On Tue, 11 Sep 2007 10:36:35 +0200, Fabio Pietrosanti (naif) [EMAIL PROTECTED] said: Bron Gondwana wrote: On Mon, Sep 10, 2007 at 02:38:07PM -0400, Ken Murchison wrote: A lot of the patches (past and present) have been implemented. Some of the others will be implemented in time

Re: mailboxes.db vs ctl_mboxlist -d

2007-09-11 Thread Bron Gondwana
probably want this patch: http://cyrus.brong.fastmail.fm/patches/cyrus-dbtool-transaction-2.3.9.diff It makes it use a single transaction for all the operations on stdin rather than one transaction per record. Massively faster for big operations! Bron. -- Bron Gondwana [EMAIL PROTECTED]

Re: pcreposix, detect, use by default

2007-09-15 Thread Bron Gondwana
On Tue, 11 Sep 2007 12:26:56 -0400, Ken Murchison [EMAIL PROTECTED] said: Bron Gondwana wrote: On Tue, Sep 11, 2007 at 10:02:50AM +1000, Bron Gondwana wrote: On Mon, Sep 10, 2007 at 02:38:07PM -0400, Ken Murchison wrote: A lot of the patches (past and present) have been implemented. Some

Large Mailbox Append Fix

2007-09-19 Thread Bron Gondwana
with big mailboxes being moved! http://cyrus.brong.fastmail.fm/patches/cyrus-largemailboxappend-2.3.9.diff -- Bron Gondwana [EMAIL PROTECTED] cyrus-largemailboxappend-2.3.9.diff Description: Binary data

Re: Large Mailbox Append Fix

2007-09-20 Thread Bron Gondwana
On Thu, 20 Sep 2007 10:56:59 +0100 (BST), David Carter [EMAIL PROTECTED] said: On Thu, 20 Sep 2007, Bron Gondwana wrote: Actually, I'm not 100% sure that it's the only way to do things, but it was not particularly invasive and a small extra amount of CPU time and memory copying

Re: Large Mailbox Append Fix

2007-09-20 Thread Bron Gondwana
On Thu, 20 Sep 2007 10:56:59 +0100 (BST), David Carter [EMAIL PROTECTED] said: On Thu, 20 Sep 2007, Bron Gondwana wrote: Actually, I'm not 100% sure that it's the only way to do things, but it was not particularly invasive and a small extra amount of CPU time and memory copying

Re: Large Mailbox Append Fix

2007-09-21 Thread Bron Gondwana
On Fri, 21 Sep 2007 10:29:45 +0100 (BST), David Carter [EMAIL PROTECTED] said: On Fri, 21 Sep 2007, Bron Gondwana wrote: Attached is a patch that does both of these :) It's possible that I haven't done code-path coverage in my limited testing (it's on our test machine) so a bit

Re: Large Mailbox Append Fix

2007-09-22 Thread Bron Gondwana
On Sat, Sep 22, 2007 at 12:55:22PM +1000, Bron Gondwana wrote: On Fri, Sep 21, 2007 at 06:35:11PM +0100, David Carter wrote: On Fri, 21 Sep 2007, Ken Murchison wrote: What happens if the total number of messages to upload is a multiple of max_count? Our last batch will be handled inside

Re: Large Mailbox Append Fix

2007-09-22 Thread Bron Gondwana
On Sat, 22 Sep 2007 10:44:55 +0100 (BST), David Carter [EMAIL PROTECTED] said: On Sat, 22 Sep 2007, Bron Gondwana wrote: We still need to sync the final last_uid, which may be greater than the UID of the maximum message. Oops, yes. Replacing last_uid for the last batch should be good

Re: RHEL5 x64, skiplist statuscache SIGV

2007-09-23 Thread Bron Gondwana
approach, and hopefully push the fix into the next Cyrus release! Bron. -- Bron Gondwana [EMAIL PROTECTED]

cyrus.expunge/cyrus.cache mistmatch on replica

2007-09-24 Thread Bron Gondwana
against the data files on disk. - Everything in order all the time rather than unsorted cyrus.expunge. Bron. -- Bron Gondwana [EMAIL PROTECTED]

Re: cyrus.expunge/cyrus.cache mistmatch on replica

2007-09-24 Thread Bron Gondwana
On Mon, 24 Sep 2007 08:20:50 +0100 (BST), David Carter [EMAIL PROTECTED] said: On Mon, 24 Sep 2007, Bron Gondwana wrote: Do you guys suggest anything? Ideas I've come up with include: Ho hum. My original two phase expunge code had separate expunge.index and expunge.cache files, which

Re: Large Mailbox Append Fix

2007-09-24 Thread Bron Gondwana
On Mon, Sep 24, 2007 at 09:43:52PM -0400, Ken Murchison wrote: Bron Gondwana wrote: On Mon, 24 Sep 2007 18:45:28 -0400, Ken Murchison [EMAIL PROTECTED] said: Bron Gondwana wrote: On Mon, 24 Sep 2007 13:53:28 -0400, Ken Murchison [EMAIL PROTECTED] said: Bron Gondwana wrote: On Sat, 22 Sep

Re: Large Mailbox Append Fix

2007-09-24 Thread Bron Gondwana
the function in its final form and run some thought experiments against it. At the moment I feel I might be attacking a strawman, but given how bad the performance hit of un-necessary cache rewrites on big folders was, I want to make sure we get this logic right! Thanks, Bron. -- Bron Gondwana [EMAIL

Re: cyrus.expunge/cyrus.cache mistmatch on replica

2007-09-25 Thread Bron Gondwana
time auditing the causes of it, but it seems to think there are a lot of duplicates across those two files sometimes (I remove the one in cyrus.expunge if there are) Bron. -- Bron Gondwana [EMAIL PROTECTED]

Re: Large Mailbox Append Fix

2007-09-25 Thread Bron Gondwana
On Tue, 25 Sep 2007 07:11:36 -0400, Ken Murchison [EMAIL PROTECTED] said: Bron Gondwana wrote: I'm afraid I still don't see how your code addresses the case where there turn out to be no more messages with higher UIDs which need uploading even though we've hit exactly max_count messages

Re: Patch for 2.3.9 mod time bug

2007-10-03 Thread Bron Gondwana
On Sun, Sep 02, 2007 at 09:51:09PM +0200, Michael Glad wrote: I also observe the 2.3.8/9 problem with sync_server not properly setting the mtime of sync'ed messages. The problem seems to be that the sync_message_fsync routine writes (flushes) to the message file after the utime call.

Making Replication Robust

2007-10-03 Thread Bron Gondwana
Hi, As I've mentioned on the mailing list, we have had to put quite a lot of infrastructure around Cyrus to make replication robust in all cases. While the core replication protocol seems pretty stable now, and with GUID stuff it will be easier to do integrity checks, it's still very much not a

Re: Making Replication Robust

2007-10-08 Thread Bron Gondwana
On Mon, Oct 08, 2007 at 10:03:31AM +0200, Rudy Gevaert wrote: For me points a, e and f are most important, but the others are also important. Bron Gondwana wrote: So I'd like to start a dialogue on the topic of making Cyrus replication robust across failures with the following goals

Re: Cyrus 2.3.10 RC2

2007-10-11 Thread Bron Gondwana
On Wed, Oct 10, 2007 at 06:26:43PM -0400, Ken Murchison wrote: I just put together a second release candidate for Cyrus 2.3.10 which hopefully fixes a couple of build issues with RC1. I'd appreciate any independent testing before I release this to the masses. If there are any outstanding

Re: Making Replication Robust

2007-10-12 Thread Bron Gondwana
On Fri, Oct 12, 2007 at 10:29:53AM -0400, Carson Gaspar wrote: David Carter wrote: I'm still a little bothered about signal handling and EINTR. I did some experiments after our last chat about signals. In practice disk IO system calls seem to be reasonably safe against EINTR on both Linux

Re: Script to convert spool directory to basic hashing

2007-10-15 Thread Bron Gondwana
On Mon, 15 Oct 2007 11:49:33 +0200, Sascha Wilde [EMAIL PROTECTED] said: Bron Gondwana [EMAIL PROTECTED] writes: There's a much more complete re-implementation of the rehash script available as part of: http://cyrus.brong.fastmail.fm/patches/cyrus-hashuser-2.3.9.diff which also has

Re: Script to convert spool directory to basic hashing

2007-10-15 Thread Bron Gondwana
On Mon, 15 Oct 2007 12:36:26 +0200, Sascha Wilde [EMAIL PROTECTED] said: Bron Gondwana [EMAIL PROTECTED] writes: It's capable of converting from any of the current hashing methods plus our new one to any of the others. That means yes :) Sounds great. What a pity I didn't knew about

Re: delayed delete bug?

2007-10-15 Thread Bron Gondwana
On Mon, Oct 15, 2007 at 03:25:28PM +0200, Rudy Gevaert wrote: Hi, I'm busy looking at delayed delete. I'm using unix hierarchy seperator. I deleted a mailbox and see it like this: kavula.ugent.be lm DELETED/user/rudy.gevaert/Foo/[EMAIL PROTECTED] (\HasNoChildren)

Re: delayed delete bug?

2007-10-16 Thread Bron Gondwana
the downside that it's a completely new filesystem layout that requires a rehash run for every folder rather than just affecting a few deleted folders. Bron. -- Bron Gondwana [EMAIL PROTECTED]

Re: Cyrus 2.3.10 RC3

2007-10-19 Thread Bron Gondwana
On Thu, Oct 18, 2007 at 03:04:06PM -0400, Ken Murchison wrote: I just put together a third release candidate for Cyrus 2.3.10 which fixes a couple of bugs, and hopefully resolves outstanding build issues with com_err and xversion. I'd appreciate any independent testing before I release this

Re: Cyrus 2.3.10 RC3

2007-10-18 Thread Bron Gondwana
On Thu, Oct 18, 2007 at 03:04:06PM -0400, Ken Murchison wrote: I just put together a third release candidate for Cyrus 2.3.10 which fixes a couple of bugs, and hopefully resolves outstanding build issues with com_err and xversion. I'd appreciate any independent testing before I release this

Re: Cyrus 2.3.10 RC3

2007-10-22 Thread Bron Gondwana
On Thu, Oct 18, 2007 at 03:04:06PM -0400, Ken Murchison wrote: I just put together a third release candidate for Cyrus 2.3.10 which fixes a couple of bugs, and hopefully resolves outstanding build issues with com_err and xversion. I'd appreciate any independent testing before I release this

Re: sequence number to uid conversion

2007-11-08 Thread Bron Gondwana
On Thu, Nov 08, 2007 at 11:17:23AM +0100, Toschi Pietro wrote: Hi For an experiment I'm working at, I need to modify imapd.c so that COPY and STORE commands are registered via syslog along with UIDs of messages they apply to. It seems an easy job when clients issue commands prepended with

Multiple skiplist bugs found, patches attached

2007-11-12 Thread Bron Gondwana
On Mon, Nov 12, 2007 at 12:34:34AM +1100, Bron Gondwana wrote: Anyway - here it is. A recovery() that copes if the logstart parameter in the database header is wrong. No, I don't have a clue how that happened unless lseek() lied. Maybe it sometimes lies, I don't know. I'll be writing

Re: Multiple skiplist bugs found, patches attached

2007-11-13 Thread Bron Gondwana
On Tue, 13 Nov 2007 09:12:18 +0100 (CET), Simon Matter [EMAIL PROTECTED] said: On Mon, Nov 12, 2007 at 12:34:34AM +1100, Bron Gondwana wrote: Anyway - here it is. A recovery() that copes if the logstart parameter in the database header is wrong. No, I don't have a clue how

FastMail.FM Patchset Updated

2007-11-20 Thread Bron Gondwana
As usual you can get the patches here: http://cyrus.brong.fastmail.fm/ I've been busy with Cyrus _again_ - so much for my theory that I was taking a break. OK - here's what's new. * http://cyrus.brong.fastmail.fm/patches/cyrus-skiplist-bugfixes-2.3.10.diff

Re: [Cyrus-CVS] src/cyrus/lib by murch

2007-11-26 Thread Bron Gondwana
On Mon, Nov 26, 2007 at 06:26:38PM -0500, [EMAIL PROTECTED] wrote: Update of /afs/andrew/system/cvs/src/cyrus/lib In directory unix35.andrew.cmu.edu:/var/tmp/cvs-serv8181 Modified Files: cyrusdb_skiplist.c Log Message: Yet more skiplist fixes from Fastmail.fm Don't worry, I've got

Re: More Skiplist Stuff!

2008-01-02 Thread Bron Gondwana
On Mon, Dec 31, 2007 at 02:10:49PM +1100, Bron Gondwana wrote: On Sun, Dec 30, 2007 at 11:38:36PM +1100, Bron Gondwana wrote: I have much bigger fish to fry here, mailboxes.db corruptions again indeed. I've seen a couple of them over the past few days, with behaviour that looks remarkably

Re: More Skiplist Stuff!

2008-01-10 Thread Bron Gondwana
On Thu, Jan 10, 2008 at 05:00:55PM +, David Carter wrote: On Wed, 2 Jan 2008, Bron Gondwana wrote: The renewed one is: http://cyrus.brong.fastmail.fm/patches/cyrus-skiplist-transactions-2.3.10.diff This didn't apply when I was building 2.3.11, and stupid me went ahh, Ken must have

Re: Patch to avoid mailboxesdb corruption on concurrent renames

2008-04-04 Thread Bron Gondwana
On Fri, Apr 04, 2008 at 07:10:27AM -0400, Ken Murchison wrote: Bron Gondwana wrote: Bron ( P.S. isn't it about time for a 2.3.12? I'm getting sick of posting skiplist patches to people running the lastest and having issues! ) Yes, it probably is. Perhaps I'll make a pre

Re: Cyrus 2.3.12 RC1

2008-04-09 Thread Bron Gondwana
On Tue, Apr 08, 2008 at 10:20:57AM -0400, Ken Murchison wrote: I just put together a release candidate for Cyrus 2.3.12. I'd appreciate any independent testing before I release this to the masses. http://www.contrib.andrew.cmu.edu/~murch/cyrus-imapd-2.3.12rc1.tar.gz Notably missing:

Re: Cyrus 2.3.12 RC1

2008-04-09 Thread Bron Gondwana
. -- Bron Gondwana [EMAIL PROTECTED]

Re: Cyrus 2.3.12 RC1

2008-04-09 Thread Bron Gondwana
- ADD DELETECOMMIT ADD - COMMITCOMMIT | v So there's junk between the commits that was part of the ADD from the transaction in item (3) above. Bron. -- Bron Gondwana [EMAIL PROTECTED]

Re: Cyrus 2.3.12 RC1

2008-04-10 Thread Bron Gondwana
On Wed, Apr 09, 2008 at 01:57:01PM -0400, Ken Murchison wrote: Bron Gondwana wrote: On Tue, Apr 08, 2008 at 10:20:57AM -0400, Ken Murchison wrote: I just put together a release candidate for Cyrus 2.3.12. I'd appreciate any independent testing before I release this to the masses. http

Re: Cyrus 2.3.12 RC2

2008-04-19 Thread Bron Gondwana
On Fri, Apr 18, 2008 at 02:32:19PM -0400, Ken Murchison wrote: Unless I hear something major about the current code, I'm going to release 2.3.12 on Monday. I have some new code that I want to commit as the start of 2.3.13. Sounds good to me. I've rebuilt our patches against it (finally).

Re: Cyrus 2.3.12 RC2

2008-04-19 Thread Bron Gondwana
On Sat, Apr 19, 2008 at 09:56:53PM +1000, Bron Gondwana wrote: Um, anyway, as I was saying. I've rebuilt fast_rename and folder_limit patches, creating a transactional version of mboxlist_findall. It's slightly ugly in the extending an interface without refactoring the whole bloody codebase

Linux kernel bug AMD64 - affects skiplists

2008-06-17 Thread Bron Gondwana
I promised I'd have something to say about skiplists soon! (hi Rudy - hope you had a good time off, leaving me here to figure this out _all_by_myself_ ;) ) There's a bug in the linux kernel for amd64 builds only that breaks some skiplist files. Specifically, checkpointing a seen file with a

Re: some cleanups and fixes for Cyrus IMAPd....

2008-07-15 Thread Bron Gondwana
On Mon, Jul 14, 2008 at 05:09:27PM -0400, Greg A. Woods wrote: Here's a whack of cleanups and fixes for Cyrus IMAPd. Many I would consider absolutely critical while some are simply helpful and others are just to shut up the compiler. I may have posted this before, but here it is again,

Re: 2.3.12 transaction problem within skiplist DB-foreach()

2008-08-28 Thread Bron Gondwana
include the database name and key name, and just return DBERROR to the calling code. Bron. -- Bron Gondwana [EMAIL PROTECTED]

Re: 2.3.12 transaction problem within skiplist DB-foreach()

2008-08-28 Thread Bron Gondwana
On Thu, 28 Aug 2008 21:10:19 -0400, John Capo [EMAIL PROTECTED] said: Quoting Bron Gondwana ([EMAIL PROTECTED]): On Thu, 28 Aug 2008 19:52:19 -0400, John Capo [EMAIL PROTECTED] said: I'm convinced this is a foreach() bug. myforeach() is a copy of myfetch() with a loop in the middle

[PATCH] Set lock pointer at the start of foreach (Re: 2.3.12 transaction problem within skiplist DB-foreach())

2008-08-29 Thread Bron Gondwana
On Thu, Aug 28, 2008 at 06:17:44PM -0400, John Capo wrote: Aug 28 14:04:24 m4 syncserver[77241]: Failed to access inbox for yadda Aug 28 14:04:25 m4 syncserver[77241]: Fatal error: Internal error: assertion failed: cyrusdb_skiplist.c: 622: db- lock_status == UNLOCKED Aug 28 14:04:25 m4

Re: On the topic of nested skiplist transactions

2008-09-02 Thread Bron Gondwana
On Tue, 2 Sep 2008 16:29:33 +1000, Bron Gondwana [EMAIL PROTECTED] said: I've been thinking a bit about transactions and skiplists these past few days, since sending the patch that refactors the skiplist locking code. For reference, here's what BDB does: http://www.oracle.com/technology

Re: On the topic of nested skiplist transactions

2008-09-02 Thread Bron Gondwana
On Tue, 2 Sep 2008 16:29:33 +1000, Bron Gondwana [EMAIL PROTECTED] said: I've been thinking a bit about transactions and skiplists these past few days, since sending the patch that refactors the skiplist locking code. Wow, this was scarily simple to write. Really the code changes are so easy

Re: Core dump from cyrusdb_skiplist.c

2008-09-08 Thread Bron Gondwana
the callback; keep going */ 1023 ptr = db-map_base + FORWARD(ptr, 0); 1024 } 1025 } Do you know something about it? Kind Regards, Henryk -- Bron Gondwana [EMAIL PROTECTED]

Time for 2.3.13?

2008-09-10 Thread Bron Gondwana
I just noticed that 2.3.12 was released back in April, and there are a few fixes changes kicking around. I've just compared CVS HEAD to 2.3.12 using trusty old 'diff' and it looks like the big changes are: * sql database support * can not = cannot * capabilities tidy up * cyr_virusscan I'd

Re: Time for 2.3.13?

2008-09-10 Thread Bron Gondwana
patches on top of it. It turns out you have to do ugly complex things with transaction passing without nested transactions, and some of those patches are too complex for their own good! -- Bron Gondwana [EMAIL PROTECTED]

Re: Time for 2.3.13?

2008-09-10 Thread Bron Gondwana
being on disk! Also - do you have split meta? I.e. are the mail files in a different location than the cyrus.* files? Bron. -- Bron Gondwana [EMAIL PROTECTED]

Re: Problem with skiplist

2008-09-11 Thread Bron Gondwana
On Thu, Sep 11, 2008 at 03:48:25PM +0200, DEMBKOWSKI, Henryk (Henryk) wrote: Bron, Thank you for help. No problem. You may have noticed, I sent the wrong version of cyrusdb_skiplist.c. The one I sent was still stable, but had two more patches that aren't candidates for upstream at this

Re: Time for 2.3.13?

2008-09-11 Thread Bron Gondwana
On Wed, Sep 10, 2008 at 09:45:07AM -0400, Wesley Craig wrote: I see 12 items in the bugzilla (one of which is the skiplist foreach bug) which I think can be closed. So, yes, I think we should get these various fixes committed and begin rolling 2.3.13. Can you make sure bugzilla has the

Re: assert

2008-09-18 Thread Bron Gondwana
On Thu, Sep 18, 2008 at 05:00:39PM +0200, DEMBKOWSKI, Henryk (Henryk) wrote: Hi, When I run tool hammer_skiplist to test new version of cyrusdb_skiplist.c I got [EMAIL PROTECTED] ./hammer_skiplist -C /etc/imapd_p.conf -n /home/tsc/dhenryk/hammer.out fatal error: Internal error: assertion

Re: [Cyrus-CVS] src/cyrus/imap by murch

2008-09-23 Thread Bron Gondwana
On Tue, Sep 23, 2008 at 07:15:15PM -0400, Matt Selsky wrote: Quoting [EMAIL PROTECTED]: Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix36.andrew.cmu.edu:/var/tmp/cvs-serv5457 Modified Files: Makefile.in cyr_virusscan.c Log Message: aded code to append a notification

Things for 2.3.13 (was: [Cyrus-CVS] src/cyrus/imap by murch)

2008-09-23 Thread Bron Gondwana
On Tue, Sep 23, 2008 at 10:12:30PM -0400, Ken Murchison wrote: I started working my way through bugzilla today. Should we discuss what we should include in 2.3.13? I committed 3-4 of Bron's fixes today. Thanks, I saw the commits. That's my entire wishlist for 2.3.13 (plus the buffer size

Re: Things for 2.3.13

2008-10-02 Thread Bron Gondwana
On Tue, 30 Sep 2008 22:43:26 +1000, Bron Gondwana [EMAIL PROTECTED] said: Bunch of whingers the lot of you. Here you go... It was pretty trivial - most of the time was finding the original diff to see how it got enabled: https://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/sieve

Re: Cyrus 2.3.13 RC3

2008-10-09 Thread Bron Gondwana
On Thu, Oct 09, 2008 at 10:57:33AM -0400, Ken Murchison wrote: I just put together a third and hopefully FINAL release candidate for Cyrus 2.3.13. I'd appreciate any independent testing before I release this to the masses. Looks good. The syslog deleted change broke the fastrename patch,

Re: Upcoming Cyrus 2.3.13 Release

2008-10-15 Thread Bron Gondwana
On Wed, Oct 15, 2008 at 03:58:25PM -0500, James Miller wrote: Good God man, have you never heard of the axiom NOTING NEW ON FIRDAY? You're tempting the gods and fates. You could just disable your automatically download and install the latest release from cmu without testing it script for the

Re: Problem with stage

2008-10-20 Thread Bron Gondwana
and create directory? What do you think? While cyrus is stopped, it's quite safe to remove the stage. directory (or file!) Bron. -- Bron Gondwana [EMAIL PROTECTED]

Re: Cyrus IMAPd 2.3.13 Released

2008-10-24 Thread Bron Gondwana
On Mon, Oct 20, 2008 at 09:02:38AM -0400, Ken Murchison wrote: I am pleased to announce the release of Cyrus IMAPd 2.3.13. This release should be considered production quality. Noteworthy changes: * Added an experimental sql backend for cyrusdb. Currently MySQL, PostgreSQL, and

Cache truncation bug on aborted appends

2008-12-04 Thread Bron Gondwana
it. Bron. -- Bron Gondwana [EMAIL PROTECTED] Index: cyrus-imapd-2.3.13/imap/append.c === --- cyrus-imapd-2.3.13.orig/imap/append.c 2008-12-05 02:56:42.0 + +++ cyrus-imapd-2.3.13/imap/append.c 2008-12-05 02:56:58.0

Another day, another cyrus bug :(

2009-01-05 Thread Bron Gondwana
This one is a doozy. mboxlist_lookup returns a live pointer to a malloc'ed copy of the acl. So far so good. Except (I presume to reduce memory management effort for callers of the function) this value is overwritten next time you call mboxlist_lookup again. So - user_renameacl was clever. It

Re: Another day, another cyrus bug :(

2009-01-06 Thread Bron Gondwana
On Tue, Jan 06, 2009 at 05:12:13PM -0500, Wesley Craig wrote: This fix looks fine to me. Will you commit it? When I get access ;) I'm just waiting on my password now. I've changed over to using git for all my cyrus work. rebase --interactive and friends are just so nice to work with even

[PATCH 02/13] mailbox default options

2009-01-27 Thread Bron Gondwana
Add a config variable mailbox_default_options which allows you to, for example, enable CONDSTORE on all new mailboxes by default. It's a bitmask, which is on the skanky end of interfaces, but there you go. --- imap/mailbox.c |8 +--- lib/imapoptions |5 + 2 files changed, 10

[PATCH 01/13] Correctly truncate cache file on aborted append

2009-01-27 Thread Bron Gondwana
We were truncating to the size of the mmaped area rather than the length of the file, causing blocks of bogus zero bytes in the resulting cache file after an aborted append. === --- imap/append.c |6 -- imap/append.h |2

[PATCH 03/13] setseen overwrite

2009-01-27 Thread Bron Gondwana
When syncserver gets a setseen_all, it contains an entire skiplist file from the master. What, skiplist you say? Yeah - I'm afraid so. It's sent in binary. That sucks, but here we have it. Fixing that would be a protocol change. But... at least we can just copy the whole thing into place

[PATCH 06/13] Fix sync of non-user mailboxes

2009-01-27 Thread Bron Gondwana
If a non-user mailbox is being considered for promotion to a USER event in sync_client, it trys to xstrdup the folder name starting at the user name - except that's a NULL string and it segfaults. This patch tests the result of mboxname_isusermailbox in the conditional instead, and then makes the

[PATCH 05/13] More logging of DB errors

2009-01-27 Thread Bron Gondwana
We're seeing some DB errors which are probably quota related, but the debugging info isn't very clear. This will make it much more clear exactly what is wrong! --- imap/mboxlist.c |2 +- imap/quota_db.c |9 - 2 files changed, 9 insertions(+), 2 deletions(-) diff --git

[PATCH 07/13] sync mailbox renames for delayed delete

2009-01-27 Thread Bron Gondwana
DelayedDelete and USER events in sync log break bNot a candidate for upstream at this point - needs addional debate/b sync_client optimises its sync list by removing MAILBOX events where there's an associated USER event. This is fine until you have delayed delete, because MAILBOX user.foo

[PATCH 08/13] Syslog about changes to mailbox stats when reconstructing

2009-01-27 Thread Bron Gondwana
From: Bron Gondwana br...@launde.home.brong.net This will help with debugging quota changes, but also finding out anything else odd that's going on in the mailboxes. In _theory_ it should always print nothing if stuff hasn't broken. --- imap/reconstruct.c | 41

[PATCH 12/13] Fix realloc for quotas

2009-01-27 Thread Bron Gondwana
From: Bron Gondwana br...@launde.home.brong.net quotadb_legacyquota was allocing bytes rather than sizeof(char *) and crashing when it got over 100 entries (plus stomping all over the memory after it randomly when over 25 entries) --- lib/cyrusdb_quotalegacy.c |4 ++-- 1 files changed, 2

[PATCH 11/13] Log USER events after renaming a user's INBOX to a new username.

2009-01-27 Thread Bron Gondwana
From: Bron Gondwana br...@launde.home.brong.net --- imap/imapd.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/imap/imapd.c b/imap/imapd.c index 8501c34..0bd144a 100644 --- a/imap/imapd.c +++ b/imap/imapd.c @@ -5305,6 +5305,13 @@ static int renmbox(char *name

[PATCH 10/13] Fix ACL copying when renaming users

2009-01-27 Thread Bron Gondwana
From: Bron Gondwana br...@launde.home.brong.net Gosh mboxlist_lookup provides a dangerous interface! --- imap/user.c | 17 +++-- 1 files changed, 15 insertions(+), 2 deletions(-) diff --git a/imap/user.c b/imap/user.c index 8d439c0..5ae03d7 100644 --- a/imap/user.c +++ b/imap

[PATCH 09/13] sync all mailbox annotations, not just CONDSTORE

2009-01-27 Thread Bron Gondwana
From: Bron Gondwana br...@launde.home.brong.net Rewrite the mailboxopt annotations to be data driven, and use the same struct to process ALL annotations on the mailbox options field during a sync run. Fixes duplicatedeliver and sharedseen synchronisation, and is future-proof. --- imap

[PATCH 13/13] Check subscription database rather than explicit ADDSUB/DELSUB

2009-01-27 Thread Bron Gondwana
We were seeing occasional subscription mismatches at FastMail, and the root cause was traced back to the re-ordering of log files. All the ADDSUB commands would run first, then all the DELSUB commands. If a log file contained a DELSUB followed by an ADDSUB, they would be re-ordered, and the

Re: FastMail.FM cyrus patches for review

2009-01-28 Thread Bron Gondwana
On Wed, Jan 28, 2009 at 08:11:56PM -0500, Jeffrey T Eaton wrote: So - CMU people. Any plan to replace your aging CVS install with something modern? It's on Ken's list to look at replacing our CVS and Bugzilla installations with something better. Suggestions are welcome. Most people

Re: version control

2009-01-29 Thread Bron Gondwana
On Thu, Jan 29, 2009 at 02:49:24PM -0500, Wesley Craig wrote: On 29 Jan 2009, at 11:46, Farzad FARID wrote: I, too, second the use of a modern VCS for Cyrus Imap whether it's a distributed one or not. But let's not forget that the available web interfaces count a lot for the ease of use and

Man, you've got to love edge cases

2009-01-31 Thread Bron Gondwana
(it's 1:38 am, yikes) So I've just been trying for hours to recreate this really rare crash we get. It only occurs with messages that are delivered to users with a sieve script that has a regex match on the body, so we get one every few months. We got one today. It's been causing a segfault

Re: Man, you've got to love edge cases

2009-01-31 Thread Bron Gondwana
On Sun, Feb 01, 2009 at 01:47:37AM +1100, Bron Gondwana wrote: /* regexec() requires a NUL-terminated string */ char *buf = (char *) xstrndup(text, tlen); int r = !regexec((regex_t *) pat, buf, 0, NULL, 0); free(buf); return r; It occurs to me

Re: Man, you've got to love edge cases

2009-01-31 Thread Bron Gondwana
On Sun, Feb 01, 2009 at 11:44:26AM +1100, Bron Gondwana wrote: Does anybody know if the rx library has a length based interface? AC_CHECK_HEADERS(pcreposix.h rxposix.h) I see that rx has regncomp. Annoyingly: http://sources.redhat.com/ml/libc-alpha/2000-01/msg00160.html It's

My Github cyrus copies re-built from direct CVS access

2009-02-01 Thread Bron Gondwana
Hi Everyone, I've rebuilt my github clones from direct copies of the Cyrus CVS repository at CMU. Now that I have a local account at CMU I've been able to do a CVS import in such a way that it can follow CVS as changes get committed, which is much nicer. So - the URLs are the same, but you may

Re: +1

2009-02-01 Thread Bron Gondwana
On Sun, Feb 01, 2009 at 09:39:30PM -0800, Rob Banz wrote: Er, I dunno. +1 is a nice and simple way to demonstrate agreement without getting all verbose about it. ...and seeing that folks are in agreement with something you propose IS mighty helpful. Please, get back to the regular

Re: +1

2009-02-03 Thread Bron Gondwana
On Tue, Feb 03, 2009 at 05:27:28PM -0500, Wesley Craig wrote: On 02 Feb 2009, at 01:32, Bron Gondwana wrote: It does change the regex syntax in sieve, and is probably non- standardly evil! ) Oh? As I (minimally) understand sieve and it's extensions, the regex syntax is thoroughly

Replication broken in CVS

2009-02-04 Thread Bron Gondwana
Hi Ken, Replication is broken in CVS. Using the superpowers of git I have tracked it down to this commit: Author: murch murch Date: Wed Jan 14 15:50:47 2009 + Fixed incompatibility between older ManageSieve clients and newer servers that issue an auto-capability response after

Re: DELAYED DELETE and very long mailboxes = segfault

2009-02-06 Thread Bron Gondwana
On Fri, Feb 06, 2009 at 12:27:48PM -0500, Brian Awood wrote: We have had users that weren't able to delete a mailbox that was close to, or already at, the max name length. Cyrus generates the new name with the DELETED prefix and time stamp suffix, which ends up being longer than the

  1   2   3   4   5   6   7   >