Re: [darcs-devel] darcs patch: fixes for testsuite

2006-01-16 Thread Juliusz Chroboczek
It should be short, to the point, and understandable by itself. ``fixes for testsuite'' is okay, ``fix for issue79'' and ``Issue14 addendum'' are not. This doesn't make sense to me. fix for issue79 is more useful to me than fixes for testsuite, while also being shorter. If I see ``fixes

Re: [darcs-devel] darcs patch: Adds target: api-doc. api-doc is generated by haddock

2006-01-16 Thread Juliusz Chroboczek
* Adds target: api-doc. api-doc is generated by haddock Are we willing to start writing Haddock mark-up in the sources? If we decide we do, there's no going back. Juliusz ___ darcs-devel mailing list

Re: [darcs-devel] Patch Format

2006-01-16 Thread Juliusz Chroboczek
RepoVersion is David's code for versioning repositories. It will allow us to have a Darcs binary able to handle different repository formats and convert patches on the fly, much like Darcs-Git is able to convert between Git and Darcs on the fly. I'm just now getting to this and I don't see

Re: [darcs-devel] Repository.writePatch (issue80)

2006-01-16 Thread Juliusz Chroboczek
Total time (wall clock) orig: 5 hours + no-reread: 6 minutes Peak RES (as measured by top) orig: 940MB no-reread: 950MB Am I reading this correctly? This unoptimisation makes Darcs 50 times faster on large records while not using significantly more memory? This looks like some serious

Re: [darcs-devel] darcs patch: Add support to make_email for optional h... (and 1 more)

2006-01-16 Thread Juliusz Chroboczek
Sat Jan 14 17:58:32 EST 2006 Zachary P. Landau [EMAIL PROTECTED] * Add support to make_email for optional headers Why? (Not complaining, I just want to make sure people actually need a feature before committing it.) Juliusz

Re: [darcs-devel] Repository.writePatch (issue80)

2006-01-16 Thread zooko
Total time (wall clock) orig: 5 hours + no-reread: 6 minutes Peak RES (as measured by top) orig: 940MB no-reread: 950MB Am I reading this correctly? This unoptimisation makes Darcs 50 times faster on large records while not using significantly more memory? At *least* 50 times

Re: [darcs-devel] Repository.writePatch (issue80)

2006-01-16 Thread zooko
Total time (wall clock) orig: 5 hours + no-reread: 6 minutes Peak RES (as measured by top) orig: 940MB no-reread: 950MB Am I reading this correctly? This unoptimisation makes Darcs 50 times faster on large records while not using significantly more memory? At

Re: [darcs-devel] Repository.writePatch (issue80)

2006-01-16 Thread Juliusz Chroboczek
Jason had only 1 GB physical RAM Only? When I was a lad... Juliusz ___ darcs-devel mailing list darcs-devel@darcs.net http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel

Re: [darcs-devel] Repository.writePatch (issue80)

2006-01-16 Thread Juliusz Chroboczek
Jason, could you please repeat this test with a mere 100MB commit? Juliusz ___ darcs-devel mailing list darcs-devel@darcs.net http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel

[darcs-devel] darcs patch: Add newline between long comment and cha... (and 1 more)

2006-01-16 Thread Edwin Thomson
DarcsURL: http://www.abridgegame.org/repos/darcs-unstable MIME-Version: 1.0 Content-Type: multipart/mixed; boundary==_ --=_ Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Wed Nov 23 16:27:17 GMT 2005 [EMAIL PROTECTED] * Add newline between long comment and changed files

Re: [darcs-devel] Repository.writePatch (issue80)

2006-01-16 Thread zooko
Jason had only 1 GB physical RAM Only? When I was a lad... ;-) Last year I bought a second GB of physical RAM in order to avoid running out of physical RAM while using darcs + vmware + web browser + xemacs. Regards, Zooko ___ darcs-devel

Re: [darcs-devel] darcs patch: Save email description file if a send fails

2006-01-16 Thread Erik Schnetter
On Jan 16, 2006, at 08:20:11, Juliusz Chroboczek wrote: So the tradeoff is: - illegally use Old PGP within an attachment, as we do, which makes the signature verifiable outside of the mailer, but not within it; - obey the rules and use PGP/MIME, which will make it impossible to

Re: [darcs-devel] darcs patch: Save email description file if a send fails

2006-01-16 Thread zooko
- illegally use Old PGP within an attachment, as we do, which makes the signature verifiable outside of the mailer, but not within it; - obey the rules and use PGP/MIME, which will make it impossible to verify the signature after the attachment is saved to disk. Does anyone

Re: [darcs-devel] darcs patch: Save email description file if a send fails

2006-01-16 Thread Juliusz Chroboczek
Note that this also happens when no MTA is involved. This is issue 56. Would anyone familiar with the new MIME encoder be willing to have a look at RFC 3156? I'm suddenly realising we are in trouble, and that it's better to leave things in the current state than implement PGP/MIME. There

Re: [darcs-devel] patch: add Windows installation/configuration README

2006-01-16 Thread zooko
[add installation/configuration instructions for Windows users I'm not quite happy with including a raw dump of the automatically generated HTML. In particular, including the Javascript doesn't make sense. My suggestion would be to write a new chapter in the manual, based on this

Re: [darcs-devel] darcs patch: Add support to make_email for optional h... (and 1 more)

2006-01-16 Thread Zachary P. Landau
Sat Jan 14 17:58:32 EST 2006 Zachary P. Landau [EMAIL PROTECTED] * Add support to make_email for optional headers Why? (Not complaining, I just want to make sure people actually need a feature before committing it. Juliusz, I added it because I was looking for a way to add in a

Re: [darcs-devel] Repository.writePatch (issue80)

2006-01-16 Thread Aggelos Economopoulos
On Sunday 15 January 2006 21:24, Jason Dagit wrote: On Jan 15, 2006, at 7:34 AM, Aggelos Economopoulos wrote: On Sunday 15 January 2006 05:04, Jason Dagit wrote: Peak RES (as measured by top) orig: 940MB no-reread: 950MB Peak VIRT (as measured by top) orig: 1756MB no-reread:

Re: [darcs-devel] darcs patch: Save email description file if a send fails (and 3 more)

2006-01-16 Thread Zachary P. Landau
Sat Jan 14 17:06:52 EST 2006 Zachary P. Landau [EMAIL PROTECTED] * Update tests to use --logfile instead of --file Without commenting on the change of option names, I think this patch name says the reverse of what's intended. Indeed it does. I was having a dyslexic day. I can resubmit

Re: [darcs-devel] darcs patch: Adds target: api-doc. api-doc is generated by haddock

2006-01-16 Thread Jason Dagit
On Jan 16, 2006, at 5:34 AM, Juliusz Chroboczek wrote: * Adds target: api-doc. api-doc is generated by haddock Are we willing to start writing Haddock mark-up in the sources? If we decide we do, there's no going back. Yes, I think it would be a good thing. I also don't see it as

Re: [darcs-devel] Repository.writePatch (issue80)

2006-01-16 Thread Jason Dagit
On Jan 16, 2006, at 6:23 AM, Juliusz Chroboczek wrote: Jason, could you please repeat this test with a mere 100MB commit? What would you like me to focus on if I do that? I've done this test with 37MB commit and my findings then were pretty close to my findings here as I recall.

Re: [darcs-devel] Repository.writePatch (issue80)

2006-01-16 Thread Jason Dagit
On Jan 16, 2006, at 5:41 AM, Juliusz Chroboczek wrote: Total time (wall clock) orig: 5 hours + no-reread: 6 minutes Peak RES (as measured by top) orig: 940MB no-reread: 950MB Am I reading this correctly? This unoptimisation makes Darcs 50 times faster on large records while not using

Re: [darcs-devel] darcs patch: Do not reread freshly written patch when recording.

2006-01-16 Thread Juliusz Chroboczek
Sat Jan 14 04:22:52 PST 2006 Jason Dagit [EMAIL PROTECTED] * Do not reread freshly written patch when recording. I've looked at the code again -- and I'm puzzled. I s'pose it's linesPS biting us again. The experimental results are definitely promising, but there's obviously something going

Re: [darcs-devel] darcs patch: Add support to make_email for optional h... (and 1 more)

2006-01-16 Thread Zachary P. Landau
On 1/16/06, Juliusz Chroboczek [EMAIL PROTECTED] wrote: * Add support to make_email for optional headers Why? (Not complaining, I just want to make sure people actually need a feature before committing it. I added it because I was looking for a way to add in a In-Reply-To header.

Re: [darcs-devel] darcs patch: Do not reread freshly written patch when recording.

2006-01-16 Thread Jason Dagit
On Jan 16, 2006, at 8:09 AM, Juliusz Chroboczek wrote: Sat Jan 14 04:22:52 PST 2006 Jason Dagit [EMAIL PROTECTED] * Do not reread freshly written patch when recording. I've looked at the code again -- and I'm puzzled. I s'pose it's linesPS biting us again. Maybe, I had at least one

Re: [darcs-devel] darcs patch: Save email description file if a send fails

2006-01-16 Thread Juliusz Chroboczek
Does anyone see a good way out? For now, I'm closing the report as unfixable. How about we generate and send both kinds of signatures? I'm not very keen on that, unless someone is willing to spend time investigating how mailers react to such things.