On Wed, Apr 01, 2009 at 19:03:14 +0200, Petr Rockai wrote:
Eric Kow ko...@darcs.net writes:
Could you review this one? I expect that I'll be gone for the week when
you around to it.
Eric, I might be confused, but this seems to be already applied? Other than
that, the patch good looks after
Eric Kow ko...@darcs.net writes:
Could you review this one? I expect that I'll be gone for the week when
you around to it.
Eric, I might be confused, but this seems to be already applied? Other than
that, the patch good looks after a cursory review.
Yours,
Petr.
--
Peter Rockai |
Ben Franksen benjamin.frank...@bessy.de writes:
Will try my best. It's kinda like reverse engineering, really. IMO
this whole file path handling should be re-written from scratch. But
for that we would need some precise spec for what is required by the
rest of the program. I have the feeling
On Sat, Mar 28, 2009 at 13:59:50 +1100, Trent W. Buck wrote:
ben.frank...@online.de writes:
Sat Mar 28 00:18:21 CET 2009 ben.frank...@online.de
* Resolve issue1162: makeAbsolute is now a total function
AFAICT this should also move bugs/issue1162_add_nonexistent_slash.sh
into tests/.
Hi Petr,
Could you review this one? I expect that I'll be gone for the week when
you around to it.
I tried to have a look at it, but now I realise I don't have the time
to think about the key active ingredient, i.e. the checking if not (null
dir), before rushing off.
Thanks!
On Sat, Mar 28,
Trent W. Buck wrote:
ben.frank...@online.de writes:
Sat Mar 28 00:18:21 CET 2009 ben.frank...@online.de
* Resolve issue1162: makeAbsolute is now a total function
AFAICT this should also move bugs/issue1162_add_nonexistent_slash.sh
into tests/.
I'll follow up with this. And some more
I /hope/ that there are no more cases where this issue can come up. It is
really hard to say, is_relative infects many other functions with its
partiality. In some of them I documented this by adding a clause that calls
'bug'. This should make it easier to to diagnose the problem if happens again.
Some minor nitpicking:
ben.frank...@online.de writes:
Sat Mar 28 00:18:21 CET 2009 ben.frank...@online.de
* Resolve issue1162: makeAbsolute is now a total function
AFAICT this should also move bugs/issue1162_add_nonexistent_slash.sh
into tests/.
simpleSubPath :: FilePath - Maybe SubPath
