On Sun, Mar 27, 2016 at 11:02 PM, Torsten Bronger <bron...@physik.rwth-aachen.de> wrote: > Hallöchen! > > AlicVB writes: > >> [...] >> >> 2 : Deprecate c&r, and rewrite their features in different iop(s) : >> >> 2.a : merge rotation and perspective inside lensfun () and do a >> special iop for cropping only. It has the advantage to concentrate >> all interpolation inside lensfun iop, we lost the actual c&r ui, >> which works quite well from an user pov > > Just lurking, so maybe I'm missing context, but Lensfun has grown > the ability to do perspective correction and rotation. Thus, PC, > rotation, anti-distortion, and anti-TCA could be done without > leaving floating point space. Moreover, Lensfun's auto-scaling > would take all of them into account. > > Status of rotation and PC: Both are in master but in no release yet. > Lensfun's PC is the most feature-rich as far as I can see (circles, > fine-tuning parameter, see > http://wilson.bronger.org/lensfun/perspective-correction.html) and > covered with tests, but it doesn't have auto detection of lines or > serious performance tests. Yes, that is exactly what i am proposing to replace current c&r features with. That is the best case solution in my opinion.
Caveat 1: "Both are in master but in no release yet." So we will need to keep the same implementation in lens.c, for those lf versions which did not have PC&rotation functionality. Caveat 2: at first i was going to say that lf is currently a soft-dep, but it is a hard-dep, so all good. > Tschö, > Torsten. Roman. > > -- > Torsten Bronger Jabber ID: torsten.bron...@jabber.rwth-aachen.de > > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
