Re: [darktable-dev] Darktable 2.2.X Plugin Enfuse Professional

2017-03-19 Thread Ger Siemerink 
> Translations into other languages are welcome!
>
> ​
>
​​... I will try asap your "plugin", a translations will follow, asap​   (Y)


 --
met vriendelijke groet / kind regards Ger
mailto:g.siemer...@gmail.com website: www.gersiemerink.net

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Darktable 2.2.X Plugin Enfuse Professional

2017-03-19 Thread Colin Adams 
I just tried to do a focus stack using this. I selected fusion preset 1 -
deep focus fusion image, and it made a complete hash of the alignment (I
shot hand-held, as I had no tripod or anything with me. but there was a
window frame in the image, so I was exepecting it would be able to align
OK).
Any hints on what to try? I've never attempted anything like this before.

On Sun, 19 Mar 2017 at 18:28 Holger Klemm 
wrote:

> Hallo,
> together with Ulrich Pegelow I added the support for darktable 2.3 (API
> 5.0.0).
>
> Change report dt plugin Enfuse Professional 2.2.1:
> - changed output from align_image_stack to .local/tmp
> - add support for darktable 2.3 (API 5.0.0) and Lua 5.3
> - fixes for translation
> - add german translation
> Translations into other languages are welcome!
>
> Download:
>
> http://www.multimedia4linux.de/images/darktable/plugins/enfuse_pro-2.1.1.tar
>
> German manual:
>
> http://www.multimedia4linux.de/index.php/bildbearbeitung/darktable/darktable-plugin-enfuse-professional
>
> Holger
>
>
> Am Donnerstag, 16. März 2017, 19:20:51 CET schrieb Pascal Obry:
> > Hi Holger,
> >
> > I did tried the beta2 today.
> >
> > I have proposed a patch on the Lua support to fix this wonderful
> > module. Still waiting to see if my patch is correct though :)
> >
> > Also I found an issue with the location of the ".aligned" at creation
> > time. Fix in the attached patch.
> >
> > Also tested with darktable master so I have added compatibility with
> > 5.0.0 API.
> >
> > Let me know if you have questions.
> >
> > Thanks,
>
>
> ___
> darktable developer mailing list
> to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Darktable 2.2.X Plugin Enfuse Professional

2017-03-19 Thread Holger Klemm 
Hallo,
together with Ulrich Pegelow I added the support for darktable 2.3 (API 
5.0.0).

Change report dt plugin Enfuse Professional 2.2.1:
- changed output from align_image_stack to .local/tmp
- add support for darktable 2.3 (API 5.0.0) and Lua 5.3
- fixes for translation
- add german translation
Translations into other languages are welcome!

Download:
http://www.multimedia4linux.de/images/darktable/plugins/enfuse_pro-2.1.1.tar

German manual:
http://www.multimedia4linux.de/index.php/bildbearbeitung/darktable/darktable-plugin-enfuse-professional

Holger


Am Donnerstag, 16. März 2017, 19:20:51 CET schrieb Pascal Obry:
> Hi Holger,
> 
> I did tried the beta2 today.
> 
> I have proposed a patch on the Lua support to fix this wonderful
> module. Still waiting to see if my patch is correct though :)
> 
> Also I found an issue with the location of the ".aligned" at creation
> time. Fix in the attached patch.
> 
> Also tested with darktable master so I have added compatibility with
> 5.0.0 API.
> 
> Let me know if you have questions.
> 
> Thanks,


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Darktable 2.2.X Plugin Enfuse Professional

2017-03-19 Thread David Houlder 

On 18/03/17 23:40, Holger Klemm wrote:

Hello everybody,
the final version 2.1 of the Enfuse Professional "plugin" for darktable 2.2.X
is finished.
Download:
http://www.multimedia4linux.de/images/darktable/plugins/enfuse_pro-2.1.tar


This certainly looks useful - thanks. I have a few suggestions.

For starters, this looks a bit scary...
 dt.control.execute( "rm ~/.local/tmp/*.tif")
You are making the assumption that all those TIF files are yours - there 
may be other stuff there that you should leave alone. It's also not 
clear why you want to do this in those error cases in create_image_fusion().


Lua has its own os.remove() which you should probably use wherever 
possible instead of executing "rm" (which might not be /usr/bin/rm).


Also bear in mind that every command passed to dt.control.execute() is 
run by system(3), so any filename containing a double-quote character 
and/or shell metacharacter is going to break the assembly of  your 
images_to_align string.  At worst this could end up being a vector for 
shell injection exploits if someone were to use this for processing 
"interestingly named" files, but for typical desktop use, it would 
probably just fail. Given that lua doesn't have anything better than 
os.execute() that lets you pass argv explicitly, you should probably 
escape the following special characters in each double-quoted argument 
string by prefixing them with a backslash:

" \ `$
See 
https://www.gnu.org/software/bash/manual/html_node/Double-Quotes.html#Double-Quotes

Something like this should do the trick:

function shellquote(arg)
  return "\"" .. string.gsub(arg, "([\"\\`$])", "\\%1") .. "\""
end

Also, instead of running "which" to find an executable , you could just 
try to start it inside a pcall() and handle any error that it returns. 
You could also do the version check in that same call.


cheers
David

--
David Houlder
da...@davidhoulder.com
http://davidhoulder.com


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org