[darktable-dev] Darktable on Beignet

2017-02-16 Thread yan . wang
Hi, I am Beignet devloper from Intel. Just I found Beignet is pushed into the blacklist of darktable because of one bug. http://www.darktable.org/2016/12/darktable-2-2-0rc3-released/ I want to fix it but I don't know how to reproduce it. Who could help me? Thanks. yan.w

Re: Re: [darktable-dev] Darktable on Beignet

2017-02-16 Thread yan . wang
Thanks for your tips. I will try it. yan.wang From: Roman Lebedev Date: 2017-02-16 19:37 To: yan.wang CC: darktable-dev Subject: Re: [darktable-dev] Darktable on Beignet On Thu, Feb 16, 2017 at 11:11 AM, yan.wang wrote: > Hi, > I am Beignet devloper from Intel. Hi. > Just I found Be

Re: Re: [darktable-dev] Darktable on Beignet

2017-02-22 Thread yan . wang
I think it may cause if (gval[g] <= thold) section will not be entered because float caluclation may not be used equaltion comparation prcisionlly. I am not familiar with the algorithm of demosaic. If my patch is OK, could you please merge it and remove beignet from black list? Than

Re: Re: [darktable-dev] Darktable on Beignet

2017-02-22 Thread yan . wang
Hi, Sorry. I may misunderstand your previous mail. I will continue to analyze it and try to find the root cause. Thanks. Yan Wang yan.wang From: johannes hanika Date: 2017-02-22 19:00 To: yan.wang CC: darktable-dev Subject: Re: Re: [darktable-dev] Darktable on Beignet hi, sorry

Re: Re: [darktable-dev] Darktable on Beignet

2017-02-23 Thread yan . wang
ntered > because float caluclation may not be used equaltion comparation prcisionlly. > I am not familiar with the algorithm of demosaic. > If my patch is OK, could you please merge it and remove beignet from > black list? > Thanks. > > Yan Wang > > __

Re: Re: [darktable-dev] Darktable on Beignet

2017-02-24 Thread yan . wang
the value "0.0" but gamx is 0.04. >> But thold = gmin + (gmax * 0.5f). if gmin = 0.0f, it may cause thold >> has >> only gmax / 2. >> I think it may cause if (gval[g] <= thold) section will not be entered >> becaus