Dear Johannes
Am 31.07.2017 um 04:18 schrieb johannes hanika:
yeah the solver sucks.
I think I was able to fix it. See
https://github.com/rabauke/darktable/tree/fix_colorchecker
I implemented for darktable the approach to calculate the expansion
coefficients which I outlined in an other
Dear Roman,
Am 31.07.2017 um 17:45 schrieb Roman Lebedev:
I suspect you (or your editor) have run clang-format/etc on that file.
Don't do that.
mentioning clang-format I remember I run clang-format on that file
indeed. I did to ensure that my changes are compatible with darktable
coding
Dear Johannes,
Am 31.07.2017 um 04:18 schrieb johannes hanika:
oh, nice, thanks for looking into this!
i can't parse your diff, it has so many white space changes. could you
maybe fix it or explain what it does? is it just a special case for
the zero-patch case?
yeah the solver sucks.
hi!
oh, nice, thanks for looking into this!
i can't parse your diff, it has so many white space changes. could you
maybe fix it or explain what it does? is it just a special case for
the zero-patch case?
yeah the solver sucks. unfortunately eigen is written in c++, so i'm
hesitant to pull it in
Dear Johannes,
Am 12.07.2017 um 10:06 schrieb johannes hanika:
sounds weird, will try to reproduce. the fitting of this function is
using a spline, which may be prone to ringing, in between the colours
you fixed. it has a linear part that fixes this issue for purely b/w,
but may lead to issues
Hi,
Am 12.07.2017 um 10:06 schrieb johannes hanika:
sounds weird, will try to reproduce. the fitting of this function is
using a spline, which may be prone to ringing, in between the colours
you fixed. it has a linear part that fixes this issue for purely b/w,
but may lead to issues for b/w +
heya,
sounds weird, will try to reproduce. the fitting of this function is
using a spline, which may be prone to ringing, in between the colours
you fixed. it has a linear part that fixes this issue for purely b/w,
but may lead to issues for b/w + single colour.
cheers,
-jo
On Tue, Jul 11, 2017
