Re: [darktable-devel] growing width of level hand panels

2015-01-05 Thread Roman Lebedev
The fix is now merged. Roman. On Sun, Jan 4, 2015 at 11:32 PM, Roman Lebedev wrote: > Awesome, thanks for testing! > > On Sun, Jan 4, 2015 at 11:26 PM, Ulrich Pegelow < > ulrich.pege...@tongareva.de> wrote: > >> Hi Roman, >> >> really looks like this fixes the issue. Thanks! >> >> Ulrich >> >>

Re: [darktable-devel] growing width of level hand panels

2015-01-04 Thread Roman Lebedev
Awesome, thanks for testing! On Sun, Jan 4, 2015 at 11:26 PM, Ulrich Pegelow wrote: > Hi Roman, > > really looks like this fixes the issue. Thanks! > > Ulrich > > Am 04.01.2015 um 21:20 schrieb Roman Lebedev: > >> Ulrich, could you please try this branch: >> https://github.com/LebedevRI/darktabl

Re: [darktable-devel] growing width of level hand panels

2015-01-04 Thread Ulrich Pegelow
Hi Roman, really looks like this fixes the issue. Thanks! Ulrich Am 04.01.2015 um 21:20 schrieb Roman Lebedev: > Ulrich, could you please try this branch: > https://github.com/LebedevRI/darktable/tree/fix-side-panels > Hopefully, i have fixed this issue there. > > Roman. > > On Sun, Jan 4, 2015

Re: [darktable-devel] growing width of level hand panels

2015-01-04 Thread Roman Lebedev
Ulrich, could you please try this branch: https://github.com/LebedevRI/darktable/tree/fix-side-panels Hopefully, i have fixed this issue there. Roman. On Sun, Jan 4, 2015 at 7:57 PM, Ulrich Pegelow wrote: > Hmm, could this be a race condition? In order to correctly shorten the > label string vi

Re: [darktable-devel] growing width of level hand panels

2015-01-04 Thread Roman Lebedev
>Hmm, could this be a race condition? In order to correctly shorten the label string via the ellipsize function the widget needs to be packed with the final size. Could there be a moment in time when the widget is still free to expand? No, that is not it. Basically, GtkGrid handling of expand/fill

Re: [darktable-devel] growing width of level hand panels

2015-01-04 Thread Ulrich Pegelow
Hmm, could this be a race condition? In order to correctly shorten the label string via the ellipsize function the widget needs to be packed with the final size. Could there be a moment in time when the widget is still free to expand? Ulrich Am 04.01.2015 um 14:01 schrieb Roman Lebedev: > Hi.

Re: [darktable-devel] growing width of level hand panels

2015-01-04 Thread Roman Lebedev
Hi. I have finally reproduced it. All panels except the panel on the right needs to be expanded in order for it to happen (at least here, guess it migth depend on screen size) Roman. On Sat, Jan 3, 2015 at 10:53 PM, Ulrich Pegelow wrote: > Am 03.01.2015 um 20:48 schrieb Roman Lebedev: > >> Hm,

Re: [darktable-devel] growing width of level hand panels

2015-01-03 Thread Ulrich Pegelow
Am 03.01.2015 um 20:48 schrieb Roman Lebedev: > Hm, could you please check, is this a regression > since f97032566a03a36b9d48f1d8e36111a6c4f3eef2 or it is reproducible > before that commit too? Good catch! The status preceding this commit does not show the problem. Ulrich ---

Re: [darktable-devel] growing width of level hand panels

2015-01-03 Thread Roman Lebedev
Hm, could you please check, is this a regression since f97032566a03a36b9d48f1d8e36111a6c4f3eef2 or it is reproducible before that commit too? On Sat, Jan 3, 2015 at 10:29 PM, Ulrich Pegelow wrote: > Am 03.01.2015 um 19:31 schrieb Roman Lebedev: > >> Hi. >> >> I can not reproduce with >> "/tmp/1/

Re: [darktable-devel] growing width of level hand panels

2015-01-03 Thread Ulrich Pegelow
Am 03.01.2015 um 19:31 schrieb Roman Lebedev: > Hi. > > I can not reproduce with > "/tmp/1/2/3/4/5/6/7/8/9/a/b/c/d/e/f/1/2/3/4/5/6/7/8/9/a/b/c/d/e/f/test-old.png" > Maybe some screenshots would be helpful. Here you are: https://www.dropbox.com/s/njtd3a6ldr79g7g/screenshots.tar.gz?dl=0 > What GTK

Re: [darktable-devel] growing width of level hand panels

2015-01-03 Thread Roman Lebedev
Hi. I can not reproduce with "/tmp/1/2/3/4/5/6/7/8/9/a/b/c/d/e/f/1/2/3/4/5/6/7/8/9/a/b/c/d/e/f/test-old.png" Maybe some screenshots would be helpful. What GTK+ version is that? PS: i have left you a comment on 3b94cde970c11aa6357d2bd3ac9c5cf35ecfd646

[darktable-devel] growing width of level hand panels

2015-01-03 Thread Ulrich Pegelow
Hi, there's a small quirk with current master in that the width of the left hand panel grows under certain conditions. Root cause seems to be that darktable forgets to ellipse the "full path" field of the image information panel. Here is how to reproduce (the images of your collection need to