Re: [PATCH] Port to Solaris

2011-03-15 Thread Herbert Xu
On Sun, Mar 13, 2011 at 01:25:21AM +, Brian Koropoff wrote: Signed-off-by: Brian Koropoff bkorop...@gmail.com Thanks for the patch. I've made some minor updates before applying: * Remove unnecessary config.h inclusions (already included on command line) * Only check mktemp when tempfile

Re: [PATCH v2] [DEBUG] Use va_copy when reusing a va_list

2011-03-15 Thread Herbert Xu
On Mon, Mar 14, 2011 at 06:29:27AM +, Jonathan Nieder wrote: When tracing (with the DEBUG compile-time option set to 1 or 2), exverror calls TRACEV to print its arguments before passing them on. So the arguments are consumed by the time exvwarning looks for them, resulting in a segfault:

Re: inconsistency with handling of symlinked ttys in background

2011-03-15 Thread Herbert Xu
On Tue, Nov 09, 2010 at 10:18:35AM +, Pádraig Brady wrote: I noticed a bug with dash-0.5.6-2.fc11.i586 in that it doesn't redirect from symlinked ttys correctly for background processes. $ dash -c tty /dev/stdin $ dash -c tty /dev/stdin /dev/pts/3 $ bash -c tty /dev/stdin

Re: shift fatal error

2011-03-15 Thread Jilles Tjoelker
On Thu, Mar 10, 2011 at 08:23:33PM +0100, Guido Berhoerster wrote: * Dan Muresan danm...@gmail.com [2011-03-10 19:41]: Hi, is there some consensus on whether shift should cause a fatal error as reported by Herbert against bash: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=252378