Re: where to obtain dash 0.5.9.1?

On Thu, Mar 9, 2017 at 5:41 AM, Herbert Xu wrote: [...] > I'm in the process of fixing it. For the time being the git tree > is the best place to get the source code. Hi Herbert, any news in getting http://gondor.apana.org.au back up again? BTW, I cloned

Re: Bug? "fstat64(f, ) < 0 && S_ISREG(sb.st_mode)"

Also, inspecting bash code, this seems to be code to figure out if the file was changed from a non-regular file to a regular file between the stat and the open, so I'd say it's indeed a bug, but the problem is not the &&, but testing the wrong return code. >From bash redir.c 631 /* OK, the

Re: Bug? "fstat64(f, ) < 0 && S_ISREG(sb.st_mode)"

I see the change was introduced here http://git.kernel.org/cgit/utils/dash/dash.git/commit/?id=f78674ed6f95b594dcac0e96d6a76c5f64aa2cbf, by importing code from FreeBSD's sh. What I find interesting is testing the contents of 'sb', when the fstat64 call failed. FreeBSD's code has the opposite: